Re: [OMPI devel] rankfile questions

2008-03-19 Thread Jeff Squyres
Yes, you're right -- we should have reviewed this code 2 weeks ago when you asked. Sorry about that. :-\ Per adding lots of affinity code in ompi_mpi_init.c: perhaps those code belongs down in the paffinity (or rmaps?) base. It doesn't have to become part of any specific paffinity compon

Re: [OMPI devel] rankfile questions

2008-03-19 Thread Lenny Verkhovsky
Hi, > -Original Message- > From: devel-boun...@open-mpi.org [mailto:devel-boun...@open-mpi.org] On > Behalf Of Ralph Castain > Sent: Wednesday, March 19, 2008 3:19 AM > To: Open MPI Developers > Subject: Re: [OMPI devel] rankfile questions > > Not trying to pile

Re: [OMPI devel] rankfile questions

2008-03-18 Thread Ralph Castain
Not trying to pile on here...but I do have a question. This commit inserted a bunch of affinity-specific code in ompi_mpi_init.c. Was this truly necessary? It seems to me this violates our code architecture. Affinity-specific code belongs in the opal_p[m]affinity functions. Why aren't we just cal

Re: [OMPI devel] rankfile questions

2008-03-18 Thread Jeff Squyres
On Mar 18, 2008, at 9:32 AM, Jeff Squyres wrote: I notice that rankfile didn't compile properly on some platforms and issued warnings on other platforms. Thanks to Ralph for cleaning it up... 1. I see a getenv("slot_list") in the MPI side of the code; it looks like $slot_list is set by the odl