[OMPI devel] mpirun hang (regression in bffb2b7a4bb49c9188d942201b8a8f04872ff63c)

2014-12-24 Thread Gilles Gouaillardet
Ralph, i tried to debug the issue reported by Siegmar at http://www.open-mpi.org/community/lists/users/2014/12/26052.php i have not been able to try this on an heterogeneous cluster yet, but i could reproduce a hang with 2 nodes and 3 tasks : mpirun -host node0,node1 -np 3 --mca btl tcp,self --m

Re: [OMPI devel] mpirun hang (regression in bffb2b7a4bb49c9188d942201b8a8f04872ff63c)

2014-12-24 Thread Ralph Castain
Looks like someone already took care of it this morning - thanks! > On Dec 23, 2014, at 11:26 PM, Gilles Gouaillardet > wrote: > > Ralph, > > i tried to debug the issue reported by Siegmar at > http://www.open-mpi.org/community/lists/users/2014/12/26052.php > > i have not been able to try thi

Re: [OMPI devel] [OMPI commits] Git: open-mpi/ompi branch master updated. dev-612-g05af80b

2014-12-24 Thread Ralph Castain
Hi Nadezhda I’m afraid this commit is still incorrect as it means that reply can be used without ever being initialized. Somehow, you have to OBJ_NEW reply before you can use it. Could you please correct this? Thanks Ralph > On Dec 24, 2014, at 3:30 AM, git...@crest.iu.edu wrote: > > This is

Re: [OMPI devel] [OMPI commits] Git: open-mpi/ompi branch master updated. dev-612-g05af80b

2014-12-24 Thread Elena Elkina
Hi Ralph, As I remember the idea of this code was to create a reply once (and set flag stored to true) but send this reply multiple times (to each process from the list of requests). Flag stored is set to false earlier in the code. It means that once (for the first request in the loop pmix_server_

Re: [OMPI devel] OMPI devel] [OMPI commits] Git: open-mpi/ompi branch master updated. dev-612-g05af80b

2014-12-24 Thread Gilles Gouaillardet
Ralph, I had second thougts on what i wrote earlier, and i think the code is correct. e.g. reply cannot be used uninitialized. That being said, i think reply should be initialized to null and OBJ_RELEASE'd if not null on exit in order to avoid a memory leak. Sorry for the confusion, Gilles

Re: [OMPI devel] OMPI devel] [OMPI commits] Git: open-mpi/ompi branch master updated. dev-612-g05af80b

2014-12-24 Thread Ralph Castain
The code is awfully hard to follow - I’m refactoring it on a branch now to try and make it more understandable and will deal with the memory leak there. > On Dec 24, 2014, at 7:35 AM, Gilles Gouaillardet > wrote: > > Ralph, > > I had second thougts on what i wrote earlier, and i think the co

Re: [OMPI devel] [OMPI commits] Git: open-mpi/ompi branch master updated. dev-612-g05af80b

2014-12-24 Thread Ralph Castain
Thanks - as per the other note on the thread, I’ve been working to refactor things anyway and will try to make the code a little more readable so this is clearer. > On Dec 24, 2014, at 7:28 AM, Elena Elkina wrote: > > Hi Ralph, > > As I remember the idea of this code was to create a reply onc