Re: [OMPI devel] RFC: calloc instead of malloc in opal_obj_new()

Jeff, Using calloc() only subject to --with-valgrind sounds good to me. If I'd known such a option exists, I'd not have suggested the MCA param idea. -Paul On Fri, Oct 3, 2014 at 3:33 PM, Jeff Squyres (jsquyres) wrote: > How about a compromise -- how about enabling

Re: [OMPI devel] RFC: calloc instead of malloc in opal_obj_new()

Hi Jeff, I'd be okay with this as long as there would be a config option to revert back to using malloc rather than calloc. Howard On 10/3/14 2:54 PM, Jeff Squyres (jsquyres) wrote: WHAT: change the malloc() to calloc() in opal_obj_new() (perhaps only in debug builds?) WHY: Drastically

Re: [OMPI devel] RFC: calloc instead of malloc in opal_obj_new()

How about a compromise -- how about enabling calloc() when --with-valgrind is specified on the command line? I.e., don't tie it to debug builds, but to valgrind-enabled builds? On Oct 3, 2014, at 6:11 PM, Paul Hargrove wrote: > I agree with George that zeroing memory only

Re: [OMPI devel] RFC: calloc instead of malloc in opal_obj_new()

I agree with George that zeroing memory only in the debug builds could hide bugs, and thus would want to see the debug and non-debug builds have the same behavior (both malloc or both calloc). So, I also agree this looks initially like a hard choice. What about using malloc() in non-debug builds

Re: [OMPI devel] RFC: calloc instead of malloc in opal_obj_new()

It’s a tough call. This proposal will create significant differences between the debug and fast builds. As the entire objects will be set to zero this might reduce bugs in the debug build, bugs that will be horribly difficult to track in any non-debug builds. Moreover, if the structures are

Re: [OMPI devel] opal components subject to removal for 1.9 release

On Oct 3, 2014, at 17:06 , Howard wrote: > Hello OMPI folks, > > As part of the code cleanup for release 1.9/2.0, there are several > opal components that are on the radar for possible removal. > > These include: > > mca/btl/template (not clear anyone is maintaining

[OMPI devel] RFC: calloc instead of malloc in opal_obj_new()

WHAT: change the malloc() to calloc() in opal_obj_new() (perhaps only in debug builds?) WHY: Drastically reduces valgrind output WHERE: see https://github.com/open-mpi/ompi/blob/master/opal/class/opal_object.h#L462-L467 TIMEOUT: teleconf, Tue, Oct 14 (there's no rush) MORE DETAIL: I was

Re: [OMPI devel] OMPI@GitHub: (Mostly) Open for business

On 10/03/2014 01:23 PM, Jeff Squyres (jsquyres) wrote: On Oct 3, 2014, at 7:11 AM, Gilles Gouaillardet wrote: I think you're suggesting "git log | grep SVN rxxx", right? i do not think this returns the git commit id, does it ? what i had in mind is : git log

Re: [OMPI devel] OMPI devel] OMPI devel] OMPI@GitHub: (Mostly) Open for business

will do ! Gilles "Jeff Squyres (jsquyres)" wrote: >That's a possibility. IU could probably host this for us. > >Would you mind looking into how hard this would be? > > >On Oct 3, 2014, at 8:41 AM, Gilles Gouaillardet > wrote: > >> Jeff, >>

[OMPI devel] Update your MTT config: nightly master tarballs

Note that the main development area is now called "master", not "trunk". So you need to update your MTT INI file to point to where the new master nightly snapshot tarballs will live. It used to be: ompi_snapshot_url = http://www.open-mpi.org/nightly/trunk Now it needs to be:

Re: [OMPI devel] OMPI devel] OMPI@GitHub: (Mostly) Open for business

That's a possibility. IU could probably host this for us. Would you mind looking into how hard this would be? On Oct 3, 2014, at 8:41 AM, Gilles Gouaillardet wrote: > Jeff, > > What about a bot using github's rich REST api that parses PR and > automatically

Re: [OMPI devel] OMPI devel] OMPI@GitHub: (Mostly) Open for business

Jeff, What about a bot using github's rich REST api that parses PR and automatically sets label/milestone/assignee when a keyword is found ? for example : PR:milestone=v1.8.4:assignee=jsquyres:label=bug or #milestone=v1.8.4 #assignee=@jsquyres #label=bug i can investigate this way if needed

Re: [OMPI devel] OMPI@GitHub: (Mostly) Open for business

Gah. I just did some experimentation and confirmed this behavior: 1. If you do not belong to a repo, you can file issues/pull requests and comment on them. 2. If you have *read* access to a repo, you can do everything from #1, but you're also eligible for @mention auto-complete, and

Re: [OMPI devel] OMPI@GitHub: (Mostly) Open for business

On Oct 3, 2014, at 7:11 AM, Gilles Gouaillardet wrote: > > I think you're suggesting "git log | grep SVN rxxx", right? > > i do not think this returns the git commit id, does it ? > > what i had in mind is : > git log master > and then /r > and manually

Re: [OMPI devel] OMPI@GitHub: (Mostly) Open for business

On Fri, Oct 3, 2014 at 7:29 PM, Jeff Squyres (jsquyres) wrote: > On Oct 2, 2014, at 11:33 PM, Gilles Gouaillardet < > gilles.gouaillar...@iferc.org> wrote: > > > the most painful part is probably to manually retrieve the git commit id > > of a given svn commit id > > > > git

Re: [OMPI devel] OMPI@GitHub: (Mostly) Open for business

Jeff, my point is that label, milestone and assignee are *not* clickable for me (see attached snapshot, "settings" icons are missing Cheers, Gilles On Fri, Oct 3, 2014 at 7:36 PM, Jeff Squyres (jsquyres) wrote: > You can only assign a label and milestone, and assign the

Re: [OMPI devel] OMPI@GitHub: (Mostly) Open for business

Ralph -- I lied, sorry. You can assign the PR to someone (and assign a milestone and labels) *after* you create it. This is different than Trac where you could set the title, body, and all those values and *then* create the ticket. See https://github.com/open-mpi/ompi/wiki/SubmittingBugs for

Re: [OMPI devel] OMPI@GitHub: (Mostly) Open for business

You can only assign a label and milestone, and assign the PR to someone, *after* you create the PR (same with creating issues). See https://github.com/open-mpi/ompi/wiki/SubmittingBugs for details: [cid:41E9C244-C34D-4E68-89F9-6CE6DFE8B729@cisco.com] On Oct 2, 2014, at 11:37 PM, Gilles

Re: [OMPI devel] OMPI@GitHub: (Mostly) Open for business

On Oct 2, 2014, at 11:33 PM, Gilles Gouaillardet wrote: > the most painful part is probably to manually retrieve the git commit id > of a given svn commit id > > git log master, and then search r > /* each commit log has a line like : > This commit was SVN

Re: [OMPI devel] OMPI@GitHub: (Mostly) Open for business

Jeff, i could not find how to apply a label to a PR via the web interface (and i am not sure i can even do that since authority might be required) any idea (maybe a special keyword in the comment ...) ? Cheers, Gilles On 2014/10/03 1:53, Jeff Squyres (jsquyres) wrote: > On Oct 2, 2014, at

Re: [OMPI devel] OMPI@GitHub: (Mostly) Open for business

Ralph, what about cherry-pick ? the most painful part is probably to manually retrieve the git commit id of a given svn commit id git log master, and then search r /* each commit log has a line like : This commit was SVN rx */ and once you got (all) the git commits id of a given CMR,