Re: [dfu-util] New dfu-suffix manipulation tool

2012-03-01 Thread Tormod Volden
Hi, Let me first comment the 0.6 plan: > Once this is in and no problems show up I would want to go for a 0.6 > release. If you, or anyone else, has some fixes around let me know. I have just discovered that the Maple project ships broken firmware (declares itself as 1.1a = dfuse but is really 1

Re: [dfu-util] New dfu-suffix manipulation tool

2012-03-01 Thread Stefan Schmidt
Hello. On Thu, 2012-03-01 at 17:09, Patryk Benderz wrote: > > > Why should they be in a define? The compiler detects if the variables > > are constant and optimizes this case anyway. > I take that argument. I was not aware that present compilers do such > job. It was long ago (20 years) when was

Re: [dfu-util] New dfu-suffix manipulation tool

2012-03-01 Thread Patryk Benderz
[cut] > Well, good practices is in the eye of the beholder. :) To quote Sheldon's mother from "Big Bang Theory": "And that is your opinion." ;) > Why should they be in a define? The compiler detects if the variables > are constant and optimizes this case anyway. I take that argument. I was not awa

Re: [dfu-util] New dfu-suffix manipulation tool

2012-03-01 Thread Stefan Schmidt
Hello. Thanks for taking some time looking into this. On Thu, 2012-03-01 at 11:45, Patryk Benderz wrote: > > I didn't compile this, just looked on logical consistency with DFU > specification I was able to find [1]. If this is not proper one, please > correct me. The USB forum has the specs ava

Re: [dfu-util] New dfu-suffix manipulation tool

2012-03-01 Thread Patryk Benderz
[cut] Hi, I didn't compile this, just looked on logical consistency with DFU specification I was able to find [1]. If this is not proper one, please correct me. First what I have noticed is different bcdDFU field. You have hard-coded 0x0100(=0100h, right?), while [1] document is labeled as DFU_1.