[OpenSIPS-Devel] rls_handle_subscribe() return code when list is not found

2009-08-28 Thread Juha Heinanen
from rls tutorial document: http://www.opensips.org/Resources/Rls i get impression that rls_handle_subscribe() should return to_presence_code, if resource list document is not found in xcap server. however, when i read the code, it has: if(doc== NULL|| service_node==NULL)

Re: [OpenSIPS-Devel] rls_handle_subscribe() return code when list is not found

2009-08-28 Thread Iñaki Baz Castillo
2009/8/28 Juha Heinanen j...@tutpro.com: from rls tutorial document: http://www.opensips.org/Resources/Rls i get impression that rls_handle_subscribe() should return to_presence_code, if resource list document is not found in xcap server. however, when i read the code, it has:            

Re: [OpenSIPS-Devel] rls_handle_subscribe() return code when list is not found

2009-08-28 Thread Juha Heinanen
Iñaki Baz Castillo writes: I haven't inspected the code, but rls_handle_subscribe() does what it's supposed to do (return the preconfigured to $rc when no RL doc is found). inaki, are you sure that it returns pre-configured $rc even when Supported: header includes 'eventlist', but there

Re: [OpenSIPS-Devel] rls_handle_subscribe() return code when list is not found

2009-08-28 Thread Anca Vamanu
Hi Juha, You are right, a Subscribe that contains Supported:eventlist header but for which a list definition is not found, is replied with 404 and not sent to the presence server. It has been the way described in the documentation but changed in a commit on 12 November last year:

[OpenSIPS-Devel] SF.net SVN: opensips:[6040] trunk/modules/rls/subscribe.c

2009-08-28 Thread Anca Vamanu
Revision: 6040 http://opensips.svn.sourceforge.net/opensips/?rev=6040view=rev Author: anca_vamanu Date: 2009-08-28 11:33:40 + (Fri, 28 Aug 2009) Log Message: --- - revert change made in commit rev #4944: return to_presence code for Subscribe messages that contain

[OpenSIPS-Devel] SF.net SVN: opensips:[6041] branches/1.5/modules/rls/subscribe.c

2009-08-28 Thread Anca Vamanu
Revision: 6041 http://opensips.svn.sourceforge.net/opensips/?rev=6041view=rev Author: anca_vamanu Date: 2009-08-28 11:38:22 + (Fri, 28 Aug 2009) Log Message: --- - revert change made in commit rev #4944: return to_presence code for Subscribe messages that contain

[OpenSIPS-Devel] SF.net SVN: opensips:[6041] branches/1.5/modules/rls/subscribe.c

2009-08-28 Thread Juha Heinanen
Anca Vamanu writes: - revert change made in commit rev #4944: return to_presence code for - Subscribe messages that contain Supported:eventlist header but for - which a list definition is not found anca, in case of in-dialog subscribe, the module still returns 404 if document is not

[OpenSIPS-Devel] SF.net SVN: opensips:[6041] branches/1.5/modules/rls/subscribe.c

2009-08-28 Thread Juha Heinanen
anca, regarding in-dialog subscribe requests, perhaps it could be checked in the script if the request is for rls server or not, for example, checking that request uri matches server_address. if so, then rls_handle_subscribe would not need to handle non-list subscribes. -- juha

[OpenSIPS-Devel] SF.net SVN: opensips:[6042] trunk/modules/rls/subscribe.c

2009-08-28 Thread Anca Vamanu
Revision: 6042 http://opensips.svn.sourceforge.net/opensips/?rev=6042view=rev Author: anca_vamanu Date: 2009-08-28 12:35:59 + (Fri, 28 Aug 2009) Log Message: --- - if an indialog Subscribe does not match a known dialog, send the Subscribe to presence server (reported

Re: [OpenSIPS-Devel] SF.net SVN: opensips:[6041] branches/1.5/modules/rls/subscribe.c

2009-08-28 Thread Anca Vamanu
Hi Juha, You are right, I fixed that. Thanks, Anca Juha Heinanen wrote: anca, regarding in-dialog subscribe requests, perhaps it could be checked in the script if the request is for rls server or not, for example, checking that request uri matches server_address. if so, then

[OpenSIPS-Devel] SF.net SVN: opensips:[6043] branches/1.5/modules/rls/subscribe.c

2009-08-28 Thread Anca Vamanu
Revision: 6043 http://opensips.svn.sourceforge.net/opensips/?rev=6043view=rev Author: anca_vamanu Date: 2009-08-28 12:40:44 + (Fri, 28 Aug 2009) Log Message: --- - if an indialog Subscribe does not match a known dialog, send the Subscribe to presence server (reported

[OpenSIPS-Devel] SF.net SVN: opensips:[6043] branches/1.5/modules/rls/subscribe.c

2009-08-28 Thread Juha Heinanen
Anca Vamanu writes: - if an indialog Subscribe does not match a known dialog, send the - Subscribe to presence server (reported by Juha Heinanen) anca, thanks for the fix. after thinking a bit more this, it should be possible to distinguish in script if an initial subscribe possibly is for

Re: [OpenSIPS-Devel] SF.net SVN: opensips:[6043] branches/1.5/modules/rls/subscribe.c

2009-08-28 Thread Adrian Georgescu
On Aug 28, 2009, at 3:01 PM, Juha Heinanen wrote: Anca Vamanu writes: - if an indialog Subscribe does not match a known dialog, send the - Subscribe to presence server (reported by Juha Heinanen) anca, thanks for the fix. after thinking a bit more this, it should be possible to

Re: [OpenSIPS-Devel] SF.net SVN: opensips:[6043] branches/1.5/modules/rls/subscribe.c

2009-08-28 Thread Juha Heinanen
Adrian Georgescu writes: You can subscribe also to users of remote domains and they are not local. sure, but in that case, i'm not calling handle_subscribe, but just t_relay the request. so if target of subscribe is not for a local user, handle it with rls_handle_subscribe and

[OpenSIPS-Devel] [ opensips-Patches-2846288 ] benchmark module fixes

2009-08-28 Thread SourceForge.net
Patches item #2846288, was opened at 2009-08-28 17:00 Message generated for change (Tracker Item Submitted) made by viraptor You can respond by visiting: https://sourceforge.net/tracker/?func=detailatid=1086412aid=2846288group_id=232389 Please note that this message will contain a full copy of