[OpenSIPS-Devel] [opensips] Fix reading password from prompt for PGSQ (#477)

2015-04-22 Thread satishdotpatel
root@dopensips:/etc/opensips# opensipsdbctl create INFO: creating database opensips ... Password for user postgres: Password for user postgres: Password for user postgres: NOTICE: CREATE TABLE / UNIQUE will create implicit index "version_t_name_idx" for table "version" Password for user postgres:

[OpenSIPS-Devel] [opensips] Fix reading password from prompt for PGSQ (#476)

2015-04-22 Thread satishdotpatel
It will read password from shell and store in PGPASSWORD variable You can view, comment on, or merge this pull request online at: https://github.com/OpenSIPS/opensips/pull/476 -- Commit Summary -- * Fix reading password from prompt for PGSQ -- File Changes -- M scripts/opensipsdbctl.p

Re: [OpenSIPS-Devel] [opensips] resolve inet6 records for hosts and prefer them if dns_try_ipv6 is set (#474)

2015-04-22 Thread Jarrod Baumann
This should take care of the performance issue. Also, we were talking and wondered about the best way to set the chosen address family for the destination so we can offer the proper SDP from the branch_route. Perhaps adding a new pvar and setting it once this determination is made? --- Reply

Re: [OpenSIPS-Devel] [opensips] resolve inet6 records for hosts and prefer them if dns_try_ipv6 is set (#474)

2015-04-22 Thread Jarrod Baumann
I guess I had intended on providing the results for both address families down the road to enable user to have more granularity with controls, but now that you mention it, I agree that should not be the default behavior. I can update to @etamme's suggestions --- Reply to this email directly or

Re: [OpenSIPS-Devel] [opensips] resolve inet6 records for hosts and prefer them if dns_try_ipv6 is set (#474)

2015-04-22 Thread Eric Tamme
It looks like the commit actually attempts both - ipv4 first, then if ipv6 is enabled do ipv6. I think @bogdan-iancu is right and the logic should be serial as follows: if (ipv6_preferred==true){ do IPV6 lookup if (no IPV6 result){ do IPV4 lookup } } else { do IPV4 lookup i

Re: [OpenSIPS-Devel] [opensips] resolve inet6 records for hosts and prefer them if dns_try_ipv6 is set (#474)

2015-04-22 Thread Bogdan Andrei IANCU
@jarrodb , the idea is good, but isn't that a bit of a performance killer by doing 2 DNS queries (if v6 enabled) ? Actually not sure how to read your "both address families are attempted and ipv6 is preferred" - you actually do v4 and v6 and then look into response ? or first v6 and if no respon

[OpenSIPS-Devel] OpenSIPS 2.1 Release Candidate 2

2015-04-22 Thread Răzvan Crainea
Hello, All! We've just released the second Release Candidate for OpenSIPS 2.1[1]. This release contains all the fixes you guys have found during the last month, since the RC1. Thank you all for your efforts in deploying and testing the new version of OpenSIPS 2.1. There are two more weeks un

[OpenSIPS-Devel] [OpenSIPS/opensips] cb3ec2: Increase version to 2.1-rc2

2015-04-22 Thread Razvan Crainea
Branch: refs/heads/2.1 Home: https://github.com/OpenSIPS/opensips Commit: cb3ec2754ca616806ed5cb3a2591faaf5166fb5a https://github.com/OpenSIPS/opensips/commit/cb3ec2754ca616806ed5cb3a2591faaf5166fb5a Author: Razvan Crainea Date: 2015-04-22 (Wed, 22 Apr 2015) Changed paths:

[OpenSIPS-Devel] [OpenSIPS/opensips] cb3ec2: Increase version to 2.1-rc2

2015-04-22 Thread Razvan Crainea
Branch: refs/tags/2.1-rc2 Home: https://github.com/OpenSIPS/opensips Commit: cb3ec2754ca616806ed5cb3a2591faaf5166fb5a https://github.com/OpenSIPS/opensips/commit/cb3ec2754ca616806ed5cb3a2591faaf5166fb5a Author: Razvan Crainea Date: 2015-04-22 (Wed, 22 Apr 2015) Changed path

Re: [OpenSIPS-Devel] [opensips] db_sqlite3 sql statements not escaped (#473)

2015-04-22 Thread Jarrod Baumann
As we discussed in IRC these are the results I'm having with the latest commit (which is great improvement). I like how you enabled both options. Using the default setup (without SQLITE_BIND) I get a core dump when fork=no and no core when fork=yes, but it still crashes. ## SQLITE_BIND=0 , for

Re: [OpenSIPS-Devel] [opensips] modules/db_sqlite: error loading drouting (#471)

2015-04-22 Thread Jarrod Baumann
Confirmed that @ionutrazvanionita fixed the issue. Thanks! --- Reply to this email directly or view it on GitHub: https://github.com/OpenSIPS/opensips/issues/471#issuecomment-95189643___ Devel mailing list Devel@lists.opensips.org http://lists.opensips.

Re: [OpenSIPS-Devel] [opensips] append '\0' null character to the end of db_url in macro init_db_url (#475)

2015-04-22 Thread Jarrod Baumann
> @@ -454,6 +454,7 @@ int estimate_available_rows( int payload_size, int > column_count); > } else {\ > _db_url.len = strlen(_db_url.s); \ > } \ > + _db_url.s[_db_url.len+1] = '\0'; \ Lol, where is your sense of adventure @razvancraine

Re: [OpenSIPS-Devel] [opensips] modules/db_sqlite: error loading drouting (#471)

2015-04-22 Thread Jarrod Baumann
Closed #471. --- Reply to this email directly or view it on GitHub: https://github.com/OpenSIPS/opensips/issues/471#event-287277064___ Devel mailing list Devel@lists.opensips.org http://lists.opensips.org/cgi-bin/mailman/listinfo/devel

Re: [OpenSIPS-Devel] [opensips] append '\0' null character to the end of db_url in macro init_db_url (#475)

2015-04-22 Thread Ionut Ionita
fixed https://github.com/OpenSIPS/opensips/commit/0b6402cf96727f4fefc268fc8d5d7069c01b1327 --- Reply to this email directly or view it on GitHub: https://github.com/OpenSIPS/opensips/pull/475#issuecomment-95179257___ Devel mailing list Devel@lists.opens

Re: [OpenSIPS-Devel] [opensips] db_sqlite3 sql statements not escaped (#473)

2015-04-22 Thread Ionut Ionita
fixed https://github.com/OpenSIPS/opensips/commit/52d3ec68081728af35d992394abe9ee491f5c034 --- Reply to this email directly or view it on GitHub: https://github.com/OpenSIPS/opensips/issues/473#issuecomment-95180247___ Devel mailing list Devel@lists.ope

Re: [OpenSIPS-Devel] [opensips] modules/db_sqlite: error loading drouting (#471)

2015-04-22 Thread Ionut Ionita
fixed 0b6402c --- Reply to this email directly or view it on GitHub: https://github.com/OpenSIPS/opensips/issues/471#issuecomment-95179737___ Devel mailing list Devel@lists.opensips.org http://lists.opensips.org/cgi-bin/mailman/listinfo/devel

[OpenSIPS-Devel] [OpenSIPS/opensips] 0b6402: fixed url '\0' issue

2015-04-22 Thread ionutrazvanionita
Branch: refs/heads/master Home: https://github.com/OpenSIPS/opensips Commit: 0b6402cf96727f4fefc268fc8d5d7069c01b1327 https://github.com/OpenSIPS/opensips/commit/0b6402cf96727f4fefc268fc8d5d7069c01b1327 Author: ionutrazvanionita Date: 2015-04-22 (Wed, 22 Apr 2015) Changed p

Re: [OpenSIPS-Devel] [opensips] resolve inet6 records for hosts and prefer them if dns_try_ipv6 is set (#474)

2015-04-22 Thread Eric Tamme
very much looking forward to discussion/merging of this commit :) --- Reply to this email directly or view it on GitHub: https://github.com/OpenSIPS/opensips/pull/474#issuecomment-95169149___ Devel mailing list Devel@lists.opensips.org http://lists.opens

Re: [OpenSIPS-Devel] [opensips] append '\0' null character to the end of db_url in macro init_db_url (#475)

2015-04-22 Thread Jarrod Baumann
Closed #475. --- Reply to this email directly or view it on GitHub: https://github.com/OpenSIPS/opensips/pull/475#event-287156533___ Devel mailing list Devel@lists.opensips.org http://lists.opensips.org/cgi-bin/mailman/listinfo/devel

[OpenSIPS-Devel] [OpenSIPS/opensips] 6081ec: F_MALLOC: suppress warnings for free(NULL)

2015-04-22 Thread Liviu Chircu
Branch: refs/heads/1.8 Home: https://github.com/OpenSIPS/opensips Commit: 6081ec96471c03fecbd04beca7f8c853ef59012f https://github.com/OpenSIPS/opensips/commit/6081ec96471c03fecbd04beca7f8c853ef59012f Author: Liviu Chircu Date: 2015-04-22 (Wed, 22 Apr 2015) Changed paths:

[OpenSIPS-Devel] [OpenSIPS/opensips] a6ece8: F_MALLOC: suppress warnings for free(NULL)

2015-04-22 Thread Liviu Chircu
Branch: refs/heads/1.11 Home: https://github.com/OpenSIPS/opensips Commit: a6ece8d54634f9633bcaeb5736c15158525234ec https://github.com/OpenSIPS/opensips/commit/a6ece8d54634f9633bcaeb5736c15158525234ec Author: Liviu Chircu Date: 2015-04-22 (Wed, 22 Apr 2015) Changed paths:

[OpenSIPS-Devel] [OpenSIPS/opensips] 692ae6: F_MALLOC: suppress warnings for free(NULL)

2015-04-22 Thread Liviu Chircu
Branch: refs/heads/2.1 Home: https://github.com/OpenSIPS/opensips Commit: 692ae66c0025f21bcd52a243ce4d6abeceabcb3f https://github.com/OpenSIPS/opensips/commit/692ae66c0025f21bcd52a243ce4d6abeceabcb3f Author: Liviu Chircu Date: 2015-04-22 (Wed, 22 Apr 2015) Changed paths:

[OpenSIPS-Devel] [OpenSIPS/opensips] 015a3b: F_MALLOC: suppress warnings for free(NULL)

2015-04-22 Thread Liviu Chircu
Branch: refs/heads/1.10 Home: https://github.com/OpenSIPS/opensips Commit: 015a3b98255a815c1d3275b8bba2dd84e5406e91 https://github.com/OpenSIPS/opensips/commit/015a3b98255a815c1d3275b8bba2dd84e5406e91 Author: Liviu Chircu Date: 2015-04-22 (Wed, 22 Apr 2015) Changed paths:

[OpenSIPS-Devel] [OpenSIPS/opensips] 17d639: F_MALLOC: suppress warnings for free(NULL)

2015-04-22 Thread Liviu Chircu
Branch: refs/heads/master Home: https://github.com/OpenSIPS/opensips Commit: 17d639b9f11b415d51062005aadb86dd6c2375e2 https://github.com/OpenSIPS/opensips/commit/17d639b9f11b415d51062005aadb86dd6c2375e2 Author: Liviu Chircu Date: 2015-04-22 (Wed, 22 Apr 2015) Changed paths:

Re: [OpenSIPS-Devel] [opensips] append '\0' null character to the end of db_url in macro init_db_url (#475)

2015-04-22 Thread Răzvan Crainea
> @@ -454,6 +454,7 @@ int estimate_available_rows( int payload_size, int > column_count); > } else {\ > _db_url.len = strlen(_db_url.s); \ > } \ > + _db_url.s[_db_url.len+1] = '\0'; \ I think this is a bit broken: 1. _db_url.s - is al