[OpenSIPS-Devel] [opensips] New assert script keyword for script debugging (#313)

2014-08-26 Thread David Sanders
Allows for assertions which can be enabled or disabled for easier script debugging. Usage: assert($var(foo) == 42, quot;Whoops, var(foo) wasn#39;t equal to 42quot;); You can merge this Pull Request by running: git pull https://github.com/dsanders11/opensips master Or you can

Re: [OpenSIPS-Devel] [opensips] New assert script keyword for script debugging (#313)

2014-08-26 Thread Walter Doekes
Nice! I always wanted something like that. Does the string-part get it's pv's expanded? I'd want to put var(foo) is $var(foo) and not 42 in there. (And I'd prefer a few more spaces between every operator in the code.) --- Reply to this email directly or view it on GitHub:

Re: [OpenSIPS-Devel] [opensips] New assert script keyword for script debugging (#313)

2014-08-26 Thread David Sanders
Unfortunately the PVs don't get expanded. I'm not enough of an OpenSIPS expert to know what needs to be done to allow that without a good amount of investigating, but you're right, that would be very useful. --- Reply to this email directly or view it on GitHub:

Re: [OpenSIPS-Devel] [opensips] New assert script keyword for script debugging (#313)

2014-08-26 Thread Liviu Chircu
Code looks ok, coding style is close to ideal, except for a couple of spaces between operators (no harm done). Also, since the format expansion feature seems useful, it will go on the [TODO list](http://www.opensips.org/About/Version-1-12-0). Thank you for the contribution, Damien! --- Reply

Re: [OpenSIPS-Devel] [opensips] New assert script keyword for script debugging (#313)

2014-08-26 Thread Liviu Chircu
Merged #313. --- Reply to this email directly or view it on GitHub: https://github.com/OpenSIPS/opensips/pull/313#event-157245088___ Devel mailing list Devel@lists.opensips.org http://lists.opensips.org/cgi-bin/mailman/listinfo/devel