[OpenSIPS-Devel] [opensips] RTPPROXY module: compatibility with topology hiding (#238)

2014-05-21 Thread Nick Altmann
RTPPROXY module: workaround to run rtpproxy when we use dialog topology hiding and thus we have not 2nd via in reply It fixes autobridging for rtpproxy when using topology hiding. The problem is reply doesn#39;t have second via. We used this patch on production system about 7 months without any

Re: [OpenSIPS-Devel] [opensips] RTPPROXY module: compatibility with topology hiding (#238)

2014-05-21 Thread Walter Doekes
} else { - LM_ERR(can't extract 2nd via found reply\n); + if (parse_headers(msg, HDR_VIA2_F, 0) != -1 Hi! I believe I did suggest moving this `if` into the `else`

Re: [OpenSIPS-Devel] [opensips] RTPPROXY module: compatibility with topology hiding (#238)

2014-05-21 Thread Nick Altmann
} else { - LM_ERR(can't extract 2nd via found reply\n); + if (parse_headers(msg, HDR_VIA2_F, 0) != -1 I like this syntax. It's easier to read. --- Reply to this

Re: [OpenSIPS-Devel] [opensips] RTPPROXY module: compatibility with topology hiding (#238)

2014-05-21 Thread Bogdan Andrei IANCU
Closed #238. --- Reply to this email directly or view it on GitHub: https://github.com/OpenSIPS/opensips/pull/238#event-123410979___ Devel mailing list Devel@lists.opensips.org http://lists.opensips.org/cgi-bin/mailman/listinfo/devel

Re: [OpenSIPS-Devel] [opensips] RTPPROXY module: compatibility with topology hiding (#238)

2014-05-21 Thread Bogdan Andrei IANCU
Hi @nikbyte , there are couple of issues with this patch: 1) first, you assume the rtpproxy modules binds all the time to the dialog module; but this happens only if engage_rtpproxy() is used; so, the dialog api may not be available to you all the time; This can be fixed by trying to bind