Re: [OpenSIPS-Devel] [opensips] presence_dialoginfo: Fix bounds checking by using a helper function. (#177)

2014-03-26 Thread Bogdan Andrei IANCU
Merged #177. --- Reply to this email directly or view it on GitHub: https://github.com/OpenSIPS/opensips/pull/177___ Devel mailing list Devel@lists.opensips.org http://lists.opensips.org/cgi-bin/mailman/listinfo/devel

[OpenSIPS-Devel] [opensips] presence_dialoginfo: Fix bounds checking by using a helper function. (#177)

2014-03-12 Thread Walter Doekes
Reported by: dsandras gt; About the bound checking error, the code was cutamp;pasted from another gt; place in the same file where the same error is still present: gt; ... Also I replaced a heap str with a stack one in build_dialoginfo. This one wasn#39;t freed either unless an error condition

Re: [OpenSIPS-Devel] [opensips] presence_dialoginfo: Fix bounds checking by using a helper function. (#177)

2014-03-12 Thread Walter Doekes
return NULL; - } - memcpy(buf, sip:, 4); - memcpy(buf+4, pres_user-s, pres_user-len); - buf[pres_user-len+4] = '@'; - memcpy(buf + pres_user-len + 5, pres_domain-s, pres_domain-len); - buf[pres_user-len + 5 + pres_domain-len]= '\0'; - - pres_uri =

Re: [OpenSIPS-Devel] [opensips] presence_dialoginfo: Fix bounds checking by using a helper function. (#177)

2014-03-12 Thread Walter Doekes
@@ -444,10 +429,6 @@ str* build_dialoginfo(str* pres_user, str* pres_domain) xmlCleanupParser(); return body; error: - if ( pres_uri ) - { - pkg_free(pres_uri); Here it was freed, but it wasn't when the function returned succesfully. --- Reply to this