Re: [OpenSIPS-Devel] [opensips] presence_dialoginfo: Fix memory leak in dlginfo_agg_nbody. (#174)

2014-03-14 Thread Damien Sandrs
Hi, Yes. However, it seems to me that the probability for those leaks to appear was very weak (only in case of error). The leak was on pres_user not always being freed, which is not possible anymore as it is not dynamically allocated anymore. Le 12/03/14 21:59, Bogdan Andrei IANCU a écrit :

Re: [OpenSIPS-Devel] [opensips] presence_dialoginfo: Fix memory leak in dlginfo_agg_nbody. (#174)

2014-03-12 Thread Bogdan Andrei IANCU
Hi @dsandras , could you also confirm that the applied patch fixes the mem leaks you are aware about ? Thanks and regards, Bogdan --- Reply to this email directly or view it on GitHub:

Re: [OpenSIPS-Devel] [opensips] presence_dialoginfo: Fix memory leak in dlginfo_agg_nbody. (#174)

2014-03-11 Thread Damien Sandrs
Hi, The leak was fixed in my local branch, and I apparently forgot to push it. Apologies. About the bound checking error, the code was cutpasted from another place in the same file where the same error is still present: Line 165: /* create the new NOTIFY body */ if (

Re: [OpenSIPS-Devel] [opensips] presence_dialoginfo: Fix memory leak in dlginfo_agg_nbody. (#174)

2014-03-10 Thread Bogdan Andrei IANCU
Merged #174. --- Reply to this email directly or view it on GitHub: https://github.com/OpenSIPS/opensips/pull/174___ Devel mailing list Devel@lists.opensips.org http://lists.opensips.org/cgi-bin/mailman/listinfo/devel

Re: [OpenSIPS-Devel] [opensips] presence_dialoginfo: Fix memory leak in dlginfo_agg_nbody. (#174)

2014-03-10 Thread Bogdan Andrei IANCU
Many thanks @wdoekes for this fix ! --- Reply to this email directly or view it on GitHub: https://github.com/OpenSIPS/opensips/pull/174#issuecomment-37238127___ Devel mailing list Devel@lists.opensips.org

Re: [OpenSIPS-Devel] [opensips] presence_dialoginfo: Fix memory leak in dlginfo_agg_nbody. (#174)

2014-03-06 Thread Walter Doekes
(I squashes the two commits into one, just now.) --- Reply to this email directly or view it on GitHub: https://github.com/OpenSIPS/opensips/pull/174#issuecomment-36837723___ Devel mailing list Devel@lists.opensips.org