Re: [Git][NTPsec/ntpsec][master] Tweak the documentation on minpoll to admit minpoll=0.

2016-09-24 Thread Gary E. Miller
Yo Eric! On Sat, 24 Sep 2016 21:56:19 -0400 "Eric S. Raymond" wrote: > Gary E. Miller : > > Yo Eric! > > > > This needs to be reverted, or fixed. I fixed the main config > > code to allow minpoll=0, I did NOT change any specific refclock that > > overrules the basic rules.o > > > > refclock_j

Re: Word size assumptions

2016-09-24 Thread Hal Murray
e...@thyrsus.com said: > Well, if we still need ntp_calendar.c I thinmk you probably should not > delete tests/libntp/calendar.c - thats its unit test, no? Thanks. (good thing I asked) tests/libntp/calendar also tested some stuff in libntp/calyearstart.c I removed that code. -- These are my

Re: Word size assumptions

2016-09-24 Thread Eric S. Raymond
Hal Murray : > > e...@thyrsus.com said: > >> What part of NTP needs calendar code? That seems like the sort of code > you > >> would be trying to rip out. > > > The implicit premise is that in the real world maximum clock skew of any two > > live systems is bounded to within a fairly small amou

Re: Fw: [Git][NTPsec/ntpsec][master] Tweak the documentation on minpoll to admit minpoll=0.

2016-09-24 Thread Eric S. Raymond
Gary E. Miller : > Yo Eric! > > This needs to be reverted, or fixed. I fixed the main config > code to allow minpoll=0, I did NOT change any specific refclock that > overrules the basic rules.o > > refclock_jyy is one such driver: > > refclock_jjy.c: if ( peer->minpoll < 8 ) { > refclock_

Re: Something broken with minpoll/maxpoll

2016-09-24 Thread Hal Murray
g...@rellim.com said: > Yes. That was me. I was wondering how long until someone noticed. Please don't push code that is known to be broken. If there is a good reason, please tell us what/why etc. The only good reason I can think of would be fixing something else that is more broken. --

Re: Word size assumptions

2016-09-24 Thread Hal Murray
e...@thyrsus.com said: >> What part of NTP needs calendar code? That seems like the sort of code you >> would be trying to rip out. > The implicit premise is that in the real world maximum clock skew of any two > live systems is bounded to within a fairly small amount. So when you > interpret a

Re: Something broken with minpoll/maxpoll

2016-09-24 Thread Gary E. Miller
Yo Hal! On Sat, 24 Sep 2016 13:30:29 -0700 Hal Murray wrote: > Some of my PPS refclocks are now ramping up the poll interval. > I think there used to be some code that set maxpoll to minpoll for > refclocks. Did you break that? Yes. That was me. I was wondering how long until someone noticed.

Something broken with minpoll/maxpoll

2016-09-24 Thread Hal Murray
Some of my PPS refclocks are now ramping up the poll interval. *GPS_NMEA(0) .GPS.0 l4 64 3770.000 -61.938 91.790 oPPS(0) .PPS.0 l2 256 3770.0003.679 1.919 *NMEA(0) .GPS.0 l 252 256 3770.0008.697 5.0

Fw: [Git][NTPsec/ntpsec][master] Tweak the documentation on minpoll to admit minpoll=0.

2016-09-24 Thread Gary E. Miller
Yo Eric! This needs to be reverted, or fixed. I fixed the main config code to allow minpoll=0, I did NOT change any specific refclock that overrules the basic rules.o refclock_jyy is one such driver: refclock_jjy.c: if ( peer->minpoll < 8 ) { refclock_jjy.c: /* minpoll must be greater o