Re: pyflakes

2017-01-04 Thread Sanjeev Gupta
On Thu, Jan 5, 2017 at 8:08 AM, Mark Atwood wrote: > > https://pypi.python.org/pypi/pep8 > > pep8 is a tool to check your Python code against most of the style and > formatting conventions in "PEP 8" Hal, PEP8 is for contributions to the core Python language. It is not at all required to be u

Re: uncrustify

2017-01-04 Thread Daniel Poirot
...pretty much a 'fork' from which there is no recovery... > On Jan 4, 2017, at 7:18 PM, Mark Atwood wrote: > >> On Wed, Jan 4, 2017 at 4:50 PM Daniel Poirot wrote: >> Uncrustify is both useful and has a clever name! > > Running uncrustify against NTPsec is good idea, but it needs to be a f

Re: pyflakes

2017-01-04 Thread Hal Murray
> I agree in principle, but with so many styles of C, tough to agree on one. Easy. Let Mark pick one. Plan B is throw a dart. The key point is that uniform not-great formatting is better than random. Is there a default or sample shipped with uncrustify? -- These are my opinions. I hate spa

uncrustify

2017-01-04 Thread Mark Atwood
On Wed, Jan 4, 2017 at 4:50 PM Daniel Poirot wrote: > Uncrustify is both useful and has a clever name! Running uncrustify against NTPsec is good idea, but it needs to be a flag day, because it will be a huge patch. ..m ___ devel mailing list devel@n

Re: pyflakes

2017-01-04 Thread Gary E. Miller
Yo Hal! On Wed, 04 Jan 2017 16:43:03 -0800 Hal Murray wrote: > fallenpega...@gmail.com said: > > pep8 is a tool to check your Python code against most of the style > > and formatting conventions in "PEP 8" > > Is there a pretty printing tool for python and/or c? For Python there is autopep8

Re: pyflakes

2017-01-04 Thread Gary E. Miller
Yo Hal! On Wed, 04 Jan 2017 15:38:53 -0800 Hal Murray wrote: > g...@rellim.com said: > > All of the current code passes pyflakes, and pep8. With a few > > documented exceptions. > > What is pep8? See: https://www.python.org/dev/peps/pep-0008/ pep8 is a python program that checks that your

Re: pyflakes

2017-01-04 Thread Daniel Poirot
Uncrustify is both useful and has a clever name! > On Jan 4, 2017, at 6:43 PM, Hal Murray wrote: > > > fallenpega...@gmail.com said: >> pep8 is a tool to check your Python code against most of the style and >> formatting conventions in "PEP 8" > > Is there a pretty printing tool for python a

Re: pyflakes

2017-01-04 Thread Hal Murray
fallenpega...@gmail.com said: > pep8 is a tool to check your Python code against most of the style and > formatting conventions in "PEP 8" Is there a pretty printing tool for python and/or c? The c code is an interesting collection for formatting. I think it would help readability if we "fixe

Re: "Why does ntpkeygen pass a low entropy ignored seed into SystemRandom?""

2017-01-04 Thread Gary E. Miller
Yo Greg! On Wed, 04 Jan 2017 04:19:58 + Greg Rubin wrote: > I'll admit that I'm not a python expert by any means, but I'm pretty > certain that the seed is ignored: > http://svn.python.org/projects/python/tags/r30rc1/Lib/random.py Now that I have caught up on other things, I have drilled in

Re: pyflakes

2017-01-04 Thread Mark Atwood
> what is pep8? https://pypi.python.org/pypi/pep8 pep8 is a tool to check your Python code against most of the style and formatting conventions in "PEP 8" A "PEP" is a "Python Enhancement Proposal". Think of it as an "RFC" in the Python Community. PEP 8 is a specification of a "best practices" f

Re: pyflakes

2017-01-04 Thread Hal Murray
g...@rellim.com said: > All of the current code passes pyflakes, and pep8. With a few documented > exceptions. What is pep8? Fedora ships a pyflakes package so I don't have to work very hard to figure out where to get it and what it does. -- These are my opinions. I hate spam.

Re: NTPsec leap second experience

2017-01-04 Thread Mark Atwood
Thank you Achim On Wed, Jan 4, 2017 at 11:53 AM Achim Gratz wrote: > > I've kept to rasPi running through the leap second. > > The first was following the PTB servers as a stratum2 and monitoring > both a DCF77 and a GPS (via USB). This one correctly announced the leap > second and kept the tim

Re: pyflakes

2017-01-04 Thread Gary E. Miller
Yo Hal! On Wed, 04 Jan 2017 14:47:04 -0800 Hal Murray wrote: > > We do not take patches that fail pyflakes. > > If that's the policy, it should be announced and documented. All of the current code passes pyflakes, and pep8. With a few documented exceptions. I guess I should have been more

Re: pyflakes

2017-01-04 Thread Mark Atwood
Pyflakes test requirement has been added to .../devel/hacking.txt On Wed, Jan 4, 2017 at 2:47 PM Hal Murray wrote: > > We do not take patches that fail pyflakes. > > If that's the policy, it should be announced and documented. > > Are there other similar policies? > > > -- > These are my opinion

pyflakes

2017-01-04 Thread Hal Murray
> We do not take patches that fail pyflakes. If that's the policy, it should be announced and documented. Are there other similar policies? -- These are my opinions. I hate spam. ___ devel mailing list devel@ntpsec.org http://lists.ntpsec.org/mai

Re: ntpkeygen patch

2017-01-04 Thread Gary E. Miller
Yo Greg! On Wed, 04 Jan 2017 22:00:12 + Greg Rubin wrote: > Very weird. Especially as I don't actually make changes which should > cause the errors you provided. I'd rather go forward, than look backward. If you have a way that obviously includes the entropy that was intended then we'd lov

Re: ntpkeygen patch

2017-01-04 Thread Greg Rubin
Very weird. Especially as I don't actually make changes which should cause the errors you provided. $ pyflakes ntpkeygen $ pyflakes ntpkeygen.new $ diff -u ntpkeygen ntpkeygen.new --- ntpkeygen 2017-01-04 17:50:18.051264022 + +++ ntpkeygen.new 2017-01-04 17:50:08.367264001 + @@ -88

NTPsec leap second experience

2017-01-04 Thread Achim Gratz
I've kept to rasPi running through the leap second. The first was following the PTB servers as a stratum2 and monitoring both a DCF77 and a GPS (via USB). This one correctly announced the leap second and kept the time. The second one was configured as a stratum1 (via GPS w/ PPS) and monitoring

Re: Nonworking scalarization patch

2017-01-04 Thread Eric S. Raymond
Hal Murray : > > l_fp is used 2 places. One is scattered throughout the code. That's the > stuff you are trying to clean up. > > The other is on the wire. > > The wire is big endian. Intel is little endian. On Intel, you need to do an > 8 byte swap rather than 2 4 byte swaps. > > I have w

Re: Nonworking scalarization patch

2017-01-04 Thread Hal Murray
l_fp is used 2 places. One is scattered throughout the code. That's the stuff you are trying to clean up. The other is on the wire. The wire is big endian. Intel is little endian. On Intel, you need to do an 8 byte swap rather than 2 4 byte swaps. I have working code, but I'll let you cle