Re: Generic doesn't log into clockstat

Yo Achim! On Sun, 19 Feb 2017 13:18:12 +0100 Achim Gratz wrote: > It seems that the generic clock driver doesn't log into clockstats. > The GPS NMEA driver on the other hand does. If there's a flag or > configuration option to enable that seperately, I've not found it. > I'm

Re: [Bug] 1361811cb botches unused macro

Yo Achim! On Sun, 19 Feb 2017 13:50:16 +0100 Achim Gratz wrote: > While hunting for changes that might have affected the DCF driver I've > come across this gem: > > --8<---cut here---start->8--- > @@ -433,7 +433,13 @@ struct peer { >

clockvar reporting from generic (DCF77)

The CV reporting from the generic drivers (tested with DCF77) needs some attention. Before the clock first synchronizes, the output is severely broken: --8<---cut here---start->8--- associd=30868 status= no events, clk_unspec, device="RAW DCF77 CODE

Re: DCF77 driver seems to be broken

Achim Gratz writes: > So, while the above gets the code to recognize the refclock time again, > there's some timeout somewhere that makes the clock lose reach in the > time between each successful detection of the minute. That's probably > somewhere where a constant should now be multiplied by

Re: DCF77 driver seems to be broken

Achim Gratz writes: > I believe that the definition of timestamp_t as a union of timeval and > l_fp in parse.h is the root of these troubles. If some code somewhere > in parseclock assigns a timespec to that union instead, that would > overwrite some stuff past that memory, I think. That turned

[Bug] 1361811cb botches unused macro

While hunting for changes that might have affected the DCF driver I've come across this gem: --8<---cut here---start->8--- @@ -433,7 +433,13 @@ struct peer { #define CRYPTO_TO_ZERO(p) ((char *)&((p)->clear_to_zero)) #define END_CRYPTO_TO_ZERO(p) ((char

Re: DCF77 driver seems to be broken

Achim Gratz writes: > Achim Gratz writes: > I believe that the definition of timestamp_t as a union of timeval and > l_fp in parse.h is the root of these troubles. If some code somewhere > in parseclock assigns a timespec to that union instead, that would > overwrite some stuff past that memory,

Generic doesn't log into clockstat

It seems that the generic clock driver doesn't log into clockstats. The GPS NMEA driver on the other hand does. If there's a flag or configuration option to enable that seperately, I've not found it. I'm not sure if that was ever working, however I think it should be fixed anyway. Regards,