Re: [Open-FCoE] [PATCH 6/6] libfc: notify LLD when an FC_ID is assigned to the local port.

2009-09-14 Thread Joe Eykholt
Robert Love wrote: > On Thu, 2009-09-10 at 18:31 -0700, Joe Eykholt wrote: >> Robert Love wrote: >>> On Wed, 2009-09-09 at 10:14 -0700, Chris Leech wrote: This looks pretty good. What I put into fcoe with the overriding of the elsct_send hook does have a potential issue in that it will s

Re: [Open-FCoE] [PATCH 6/6] libfc: notify LLD when an FC_ID is assigned to the local port.

2009-09-11 Thread Joe Eykholt
Robert Love wrote: > On Thu, 2009-09-10 at 18:31 -0700, Joe Eykholt wrote: >> Robert Love wrote: >>> On Wed, 2009-09-09 at 10:14 -0700, Chris Leech wrote: This looks pretty good. What I put into fcoe with the overriding of the elsct_send hook does have a potential issue in that it will s

Re: [Open-FCoE] [PATCH 6/6] libfc: notify LLD when an FC_ID is assigned to the local port.

2009-09-11 Thread Robert Love
On Thu, 2009-09-10 at 18:31 -0700, Joe Eykholt wrote: > Robert Love wrote: > > On Wed, 2009-09-09 at 10:14 -0700, Chris Leech wrote: > >> This looks pretty good. What I put into fcoe with the overriding of the > >> elsct_send hook does have a potential issue in that it will set a new > >> MAC addr

Re: [Open-FCoE] [PATCH 6/6] libfc: notify LLD when an FC_ID is assigned to the local port.

2009-09-10 Thread Joe Eykholt
Robert Love wrote: > On Wed, 2009-09-09 at 10:14 -0700, Chris Leech wrote: >> This looks pretty good. What I put into fcoe with the overriding of the >> elsct_send hook does have a potential issue in that it will set a new >> MAC address before knowing that libfc actually accepted the fc_id. >> >>

Re: [Open-FCoE] [PATCH 6/6] libfc: notify LLD when an FC_ID is assigned to the local port.

2009-09-10 Thread Robert Love
On Wed, 2009-09-09 at 10:14 -0700, Chris Leech wrote: > This looks pretty good. What I put into fcoe with the overriding of the > elsct_send hook does have a potential issue in that it will set a new > MAC address before knowing that libfc actually accepted the fc_id. > > Chris > > On Tue,

Re: [Open-FCoE] [PATCH 6/6] libfc: notify LLD when an FC_ID is assigned to the local port.

2009-09-09 Thread Joe Eykholt
Chris Leech wrote: > This looks pretty good. What I put into fcoe with the overriding of the > elsct_send hook does have a potential issue in that it will set a new > MAC address before knowing that libfc actually accepted the fc_id. Thanks. I didn't go so far as to change fcoe.c. Maybe you cou

Re: [Open-FCoE] [PATCH 6/6] libfc: notify LLD when an FC_ID is assigned to the local port.

2009-09-09 Thread Chris Leech
This looks pretty good. What I put into fcoe with the overriding of the elsct_send hook does have a potential issue in that it will set a new MAC address before knowing that libfc actually accepted the fc_id. Chris On Tue, Sep 08, 2009 at 06:38:57PM -0700, Joe Eykholt wrote: > The fnic

[Open-FCoE] [PATCH 6/6] libfc: notify LLD when an FC_ID is assigned to the local port.

2009-09-08 Thread Joe Eykholt
The fnic driver needs to push the assigned FC_ID to firmware. It currently does this by intercepting the FLOGI responses, and in order to make that code more common with FIP and NPIV, it makes more sense to wait until the local port has completely handled the FLOGI or FDISC response. Also, when we