[Devel] Re: [ckrm-tech] [PATCH 1/9] Containers (V9): Basic container framework

2007-05-01 Thread Paul Jackson
Balbir wrote: > Would it be possible to extract those test cases and integrate them > with a testing framework like LTP? Do you have any regression test > suite for cpusets that can be made available publicly so that > any changes to cpusets can be validated? There are essentially two sorts of cpu

[Devel] Re: [ckrm-tech] [PATCH 1/9] Containers (V9): Basic container framework

2007-05-01 Thread Balbir Singh
Paul Jackson wrote: [[ I have bcc'd one or more batch scheduler experts on this post. They will know who they are, and should be aware that they are not listed in the public cc list of this message. - pj ]] Balbir Singh, responding to Paul Menage's Container patch set on lkml, wr

[Devel] Re: [NETLINK] Don't attach callback to a going-away netlink socket

2007-05-01 Thread Herbert Xu
On Sat, Apr 28, 2007 at 11:18:49PM -0700, David Miller wrote: > > Herbert, could you refresh this refinement to the current > tree? Dave, thanks for reminding me. Here it is. [NETLINK]: Kill CB only when socket is unused Since we can still receive packets until all references to the socket are

[Devel] Re: [ckrm-tech] [PATCH 3/9] Containers (V9): Add tasks file interface

2007-05-01 Thread Balbir Singh
Paul Menage wrote: On 5/1/07, Balbir Singh <[EMAIL PROTECTED]> wrote: > + if (container_is_removed(cont)) { > + retval = -ENODEV; > + goto out2; > + } Can't we make this check prior to kmalloc() and copy_from_user()? We could but I'm not sure what it would buy

[Devel] Re: [ckrm-tech] [PATCH 3/9] Containers (V9): Add tasks file interface

2007-05-01 Thread Srivatsa Vaddagiri
On Tue, May 01, 2007 at 08:25:35PM -0700, Paul Menage wrote: > >- Walk the task table and find relevant members > > That doesn't seem like a terrible solution to me, unless you expect > the class limit to be changing incredibly frequently. yeah i agree. Group limit(s) should not be changi

[Devel] Re: [ckrm-tech] [PATCH 3/9] Containers (V9): Add tasks file interface

2007-05-01 Thread Paul Menage
On 5/1/07, Srivatsa Vaddagiri <[EMAIL PROTECTED]> wrote: For the CPU controller I was working on, (a fast access to) such a list would have been valuable. Basically each task has a weight associated with it (p->load_weight) which is made to depend upon its class limit. Whenever the class limit c

[Devel] Re: [ckrm-tech] [PATCH 3/9] Containers (V9): Add tasks file interface

2007-05-01 Thread Srivatsa Vaddagiri
On Tue, May 01, 2007 at 01:37:24PM -0700, Paul Menage wrote: > > Any chance we could get a per-container task list? It will > > help subsystem writers as well. > > It would be possible, yes - but we probably wouldn't want the overhead > (additional ref counts and list manipulations on every fork/e

[Devel] Re: [ckrm-tech] [PATCH 3/9] Containers (V9): Add tasks file interface

2007-05-01 Thread Paul Menage
On 5/1/07, Balbir Singh <[EMAIL PROTECTED]> wrote: > + if (container_is_removed(cont)) { > + retval = -ENODEV; > + goto out2; > + } Can't we make this check prior to kmalloc() and copy_from_user()? We could but I'm not sure what it would buy us - we'd be optimiz

[Devel] Re: [ckrm-tech] [PATCH 1/9] Containers (V9): Basic container framework

2007-05-01 Thread Paul Jackson
[[ I have bcc'd one or more batch scheduler experts on this post. They will know who they are, and should be aware that they are not listed in the public cc list of this message. - pj ]] Balbir Singh, responding to Paul Menage's Container patch set on lkml, wrote: > > > +*** notif

[Devel] Re: [PATCH 3/9] Containers (V9): Add tasks file interface

2007-05-01 Thread Balbir Singh
+static int attach_task_by_pid(struct container *cont, char *pidbuf) +{ + pid_t pid; + struct task_struct *tsk; + int ret; + + if (sscanf(pidbuf, "%d", &pid) != 1) + return -EIO; + + if (pid) { + read_lock(&tasklist_lock); You could just

[Devel] Re: [PATCH 1/9] Containers (V9): Basic container framework

2007-05-01 Thread Balbir Singh
[EMAIL PROTECTED] wrote: This patch adds the main containers framework - the container filesystem, and the basic structures for tracking membership and associating subsystem state objects to tasks. [snip] +*** notify_on_release is disabled in the current patch set. It may be +*** reactivated

[Devel] Re: [PATCH 2/9] Containers (V9): Example CPU accounting subsystem

2007-05-01 Thread Balbir Singh
[EMAIL PROTECTED] wrote: + +/* Lazily update the load calculation if necessary. Called with ca locked */ +static void cpuusage_update(struct cpuacct *ca) +{ + u64 now = get_jiffies_64(); + /* If we're not due for an update, return */ + if (ca->next_interval_check > now) +

[Devel] Re: [PATCH 1/9] Containers (V9): Basic container framework

2007-05-01 Thread Paul Menage
On 5/1/07, Balbir Singh <[EMAIL PROTECTED]> wrote: [EMAIL PROTECTED] wrote: > This patch adds the main containers framework - the container > filesystem, and the basic structures for tracking membership and > associating subsystem state objects to tasks. [snip] > +*** notify_on_release is disab

[Devel] Re: [PATCH] ia64 sn xpc: Convert to use kthread API.

2007-05-01 Thread Dean Nelson
On Fri, Apr 27, 2007 at 02:33:32PM -0600, Eric W. Biederman wrote: > Dean Nelson <[EMAIL PROTECTED]> writes: > > > On Fri, Apr 27, 2007 at 12:34:02PM -0600, Eric W. Biederman wrote: > >> Dean Nelson <[EMAIL PROTECTED]> writes: > >> > > >> > XPC is in need of threads that can block indefinitely, wh

[Devel] Re: [PATCH] s390/scsi/zfcp_erp: Convert to use the kthread API

2007-05-01 Thread Swen Schillig
On Sunday 22 April 2007 22:17, Christoph Hellwig wrote: > On Thu, Apr 19, 2007 at 01:58:42AM -0600, Eric W. Biederman wrote: > > From: Eric W. Biederman <[EMAIL PROTECTED]> > > > > Modify zfcperp%s to be started with kthread_run not > > a combination of kernel_thread, daemonize and siginitsetinv >

[Devel] Re: [PATCH] ia64 sn xpc: Convert to use kthread API.

2007-05-01 Thread Dean Nelson
On Fri, Apr 27, 2007 at 12:34:02PM -0600, Eric W. Biederman wrote: > Dean Nelson <[EMAIL PROTECTED]> writes: > > > > Christoph is correct in that XPC has a single thread that exists throughout > > its lifetime, another set of threads that exist for the time that active > > contact with other XPCs r

[Devel] Re: [PATCH] ia64 sn xpc: Convert to use kthread API.

2007-05-01 Thread Dean Nelson
On Thu, Apr 19, 2007 at 01:58:44AM -0600, Eric W. Biederman wrote: > From: Eric W. Biederman <[EMAIL PROTECTED]> > > This patch starts the xpc kernel threads using kthread_run > not a combination of kernel_thread and daemonize. Resuling > in slightly simpler and more maintainable code. > > Cc: J

[Devel] Re: [PATCH] ia64 sn xpc: Convert to use kthread API.

2007-05-01 Thread Dean Nelson
On Thu, Apr 19, 2007 at 04:51:03PM -0700, Andrew Morton wrote: > Another driver which should be fully converted to the kthread API: > kthread_stop() and kthread_should_stop(). > > And according to my logs, this driver was added to the tree more than > a year _after_ the kthread interface was made