[Devel] Re: [0/1] [patch -mm] Add containerstats (v3)

2007-06-08 Thread Balbir Singh
Andrew Morton wrote: > On Fri, 08 Jun 2007 23:43:46 +0530 > Balbir Singh <[EMAIL PROTECTED]> wrote: > >> This patch implements per container statistics infrastructure and re-uses >> code from the taskstats interface. > > boggle. > > Symbol: CONTAINERS [=y] > Selected by: CONTAINER_DEBUG || CPU

[Devel] Re: [PATCH] Virtual ethernet tunnel (v.2)

2007-06-08 Thread Ben Greear
Carl-Daniel Hailfinger wrote: On 08.06.2007 19:00, Ben Greear wrote: I have another sysfs patch that allows setting a default skb->mark for an interface so that you can set the skb->mark before it hits the connection tracking logic, but I'm been told this one has very little chance of getting in

[Devel] Re: [ckrm-tech] [PATCH 00/10] Containers(V10): Generic Process Containers

2007-06-08 Thread Serge E. Hallyn
Quoting Paul Menage ([EMAIL PROTECTED]): > On 6/8/07, Serge E. Hallyn <[EMAIL PROTECTED]> wrote: > > > >I do fear that that could become a maintenance nightmare. For instance > >right now there's the call to fsnotify_mkdir(). Other such hooks might > >be placed at vfs_mkdir, which we'd then likel

[Devel] Re: [ckrm-tech] [PATCH 00/10] Containers(V10): Generic Process Containers

2007-06-08 Thread Paul Jackson
Serge wrote: > Paul (Jackson), is this comment added in cpusets close enough to what > you were asking for? This comment? + * Currently we refuse to set up the container - thereby + * refusing the task to be entered, and as a result refusing + * the sys_unshare() or clone() which initiated it - i

[Devel] Re: [PATCH -mm 2/2] user namespace : add unshare

2007-06-08 Thread Andrew Morton
On Fri, 08 Jun 2007 17:14:12 +0200 Cedric Le Goater <[EMAIL PROTECTED]> wrote: > Changelog: Fix !CONFIG_USER_NS clone with CLONE_NEWUSER so it returns -EINVAL > rather than 0, so that userspace knows they didn't get a new user > namespace. This changelog doesn't seem to match this pat

[Devel] Re: [0/1] [patch -mm] Add containerstats (v3)

2007-06-08 Thread Andrew Morton
On Fri, 08 Jun 2007 23:43:46 +0530 Balbir Singh <[EMAIL PROTECTED]> wrote: > This patch implements per container statistics infrastructure and re-uses > code from the taskstats interface. boggle. Symbol: CONTAINERS [=y] Selected by: CONTAINER_DEBUG || CPUSETS && SMP || CONTAINER_CPUACCT Paul,

[Devel] Re: [PATCH -mm 1/2] user namespace : add unshare

2007-06-08 Thread Andrew Morton
On Fri, 08 Jun 2007 17:14:07 +0200 Cedric Le Goater <[EMAIL PROTECTED]> wrote: > Basically, it will allow a process to unshare its user_struct table, resetting > at the same time its own user_struct and all the associated accounting. > > A new root user (uid == 0) is added to the user namespace u

[Devel] Re: [ckrm-tech] [PATCH 00/10] Containers(V10): Generic Process Containers

2007-06-08 Thread Paul Menage
On 6/8/07, Serge E. Hallyn <[EMAIL PROTECTED]> wrote: I do fear that that could become a maintenance nightmare. For instance right now there's the call to fsnotify_mkdir(). Other such hooks might be placed at vfs_mkdir, which we'd then likely want to have placed in our container_mkdir() and co

[Devel] [0/1] [patch -mm] Add containerstats (v3)

2007-06-08 Thread Balbir Singh
Changelog (v3) 1. Use the container iterator (Paul Menage) 2. delayacct_set_flag() has now been moved to delayacct_blkio_start (Andrew Morton) Changelog (v2) 1. Instead of parsing long container path's use the dentry to match the container for which stats are

[Devel] [1/1] [PATCH -mm] Update getdelays to become containerstats aware

2007-06-08 Thread Balbir Singh
Update the getdelays utility to become containerstats aware. A new -C option has been added. It takes in a container path and prints out a summary of task states in the container. Signed-off-by: Balbir Singh <[EMAIL PROTECTED]> --- Documentation/accounting/getdelays.c | 43 +

[Devel] Re: [ckrm-tech] [PATCH 00/10] Containers(V10): Generic Process Containers

2007-06-08 Thread Serge E. Hallyn
Quoting Paul Menage ([EMAIL PROTECTED]): > On 6/8/07, Serge E. Hallyn <[EMAIL PROTECTED]> wrote: > > > >The problem is container_clone() doesn't call ->create explicitly, it > >does vfs_mkdir. So we have no real way of passing in clone_task. > > > > Good point. > > Looking at vfs_mkdir(), it's p

[Devel] Re: [PATCH 0/8] RSS controller based on process containers (v3.1)

2007-06-08 Thread Vaidyanathan Srinivasan
Herbert Poetzl wrote: > On Fri, Jun 08, 2007 at 04:39:28PM +0400, Pavel Emelianov wrote: >> Herbert Poetzl wrote: >>> On Mon, Jun 04, 2007 at 05:25:25PM +0400, Pavel Emelianov wrote: [snip] When this usage exceeds the limit set some pages are reclaimed from the owning container. In case

[Devel] Re: [ckrm-tech] [PATCH 00/10] Containers(V10): Generic Process Containers

2007-06-08 Thread Paul Jackson
> Anyway the patch I sent is simple enough, and if users end up demanding > the ability to better deal with exclusive cpusets, the patch will be > simple enough to extend by changing cpuset_auto_setup(), so let's > stick with that patch since it's your preference (IIUC). Yeah - probably so. W

[Devel] Re: [PATCH 0/8] RSS controller based on process containers (v3.1)

2007-06-08 Thread Balbir Singh
Herbert Poetzl wrote: > On Fri, Jun 08, 2007 at 04:39:28PM +0400, Pavel Emelianov wrote: >> Herbert Poetzl wrote: >>> On Mon, Jun 04, 2007 at 05:25:25PM +0400, Pavel Emelianov wrote: Adds RSS accounting and control within a container. Changes from v3 - comments across the code

[Devel] Re: [ckrm-tech] [PATCH 00/10] Containers(V10): Generic Process Containers

2007-06-08 Thread Serge E. Hallyn
Quoting Paul Menage ([EMAIL PROTECTED]): > On 6/8/07, Serge E. Hallyn <[EMAIL PROTECTED]> wrote: > > > >Anyway the patch I sent is simple enough, and if users end up demanding > >the ability to better deal with exclusive cpusets, the patch will be > >simple enough to extend by changing cpuset_auto_

[Devel] Re: [PATCH] Virtual ethernet tunnel (v.2)

2007-06-08 Thread Ben Greear
Pavel Emelianov wrote: Ben Greear wrote: [snip] I would also like some way to identify veth from other device types, preferably something like a value in sysfs. However, that should not hold up We can do this with ethtool. It can get and print the driver name of the device.

[Devel] Re: [ckrm-tech] [PATCH 00/10] Containers(V10): Generic Process Containers

2007-06-08 Thread Paul Menage
On 6/8/07, Serge E. Hallyn <[EMAIL PROTECTED]> wrote: The problem is container_clone() doesn't call ->create explicitly, it does vfs_mkdir. So we have no real way of passing in clone_task. Good point. Looking at vfs_mkdir(), it's pretty simple, and really the only bits that apply to contain

[Devel] [PATCH 2/2] signal c/r: implement /proc/pid/sig writing

2007-06-08 Thread Serge E. Hallyn
>From 0fc34dcb54fe80ea720225825ad1dcb1b847d8ab Mon Sep 17 00:00:00 2001 From: Serge E. Hallyn <[EMAIL PROTECTED]> Date: Thu, 17 May 2007 17:28:07 -0400 Subject: [PATCH 2/2] signal c/r: implement /proc/pid/sig writing Allow restore through writes to /proc/pid/sig/*, except for the waiters file. Wa

[Devel] Re: [PATCH] Virtual ethernet tunnel (v.2)

2007-06-08 Thread Pavel Emelianov
Ben Greear wrote: [snip] >>> I would also like some way to identify veth from other device types, >>> preferably >>> something like a value in sysfs. However, that should not hold up >>> >> >> We can do this with ethtool. It can get and print the driver name of >> the device. >> > I thi

[Devel] [PATCH 1/2] signal checkpoint: define /proc/pid/sig/

2007-06-08 Thread Serge E. Hallyn
As I mentioned earlier, I don't know what sort of approach we want to take to guide checkpoint and restart. I.e. do we want it to be a mostly userspace-orchestrated affair, or entirely done in the kernel using the freezer or some other mechanism in response to a single syscall or containerfs file

Re: [Devel] breakfast at ols?

2007-06-08 Thread Paul Menage
On 6/5/07, Serge E. Hallyn <[EMAIL PROTECTED]> wrote: Last year we all met for breakfast at OLS. Now we've all pretty much all already met so maybe it's less exciting, but do people (who will be at OLS) care to meet for breakfast on the thursday or friday? Sounds good to me. Paul ___

[Devel] Re: [ckrm-tech] [PATCH 00/10] Containers(V10): Generic Process Containers

2007-06-08 Thread Paul Menage
On 6/8/07, Serge E. Hallyn <[EMAIL PROTECTED]> wrote: Anyway the patch I sent is simple enough, and if users end up demanding the ability to better deal with exclusive cpusets, the patch will be simple enough to extend by changing cpuset_auto_setup(), so let's stick with that patch since it's yo

[Devel] Re: [PATCH 0/8] RSS controller based on process containers (v3.1)

2007-06-08 Thread Herbert Poetzl
On Fri, Jun 08, 2007 at 04:39:28PM +0400, Pavel Emelianov wrote: > Herbert Poetzl wrote: > > On Mon, Jun 04, 2007 at 05:25:25PM +0400, Pavel Emelianov wrote: > >> Adds RSS accounting and control within a container. > >> > >> Changes from v3 > >> - comments across the code > >> - git-bisect safe s

[Devel] Re: [PATCH -mm 1/2] user namespace : add unshare

2007-06-08 Thread Cedric Le Goater
oops, wrong subject. it should be : "user namespace : add the framework" Sorry about that, C. Cedric Le Goater wrote: > Basically, it will allow a process to unshare its user_struct table, resetting > at the same time its own user_struct and all the associated accounting. > > A new roo

[Devel] [PATCH -mm 2/2] user namespace : add unshare

2007-06-08 Thread Cedric Le Goater
From: Serge E. Hallyn <[EMAIL PROTECTED]> Changelog: Fix !CONFIG_USER_NS clone with CLONE_NEWUSER so it returns -EINVAL rather than 0, so that userspace knows they didn't get a new user namespace. Signed-off-by: Serge E. Hallyn <[EMAIL PROTECTED]> Signed-off-by: Cedric Le Goater <

[Devel] [PATCH -mm 1/2] user namespace : add unshare

2007-06-08 Thread Cedric Le Goater
Basically, it will allow a process to unshare its user_struct table, resetting at the same time its own user_struct and all the associated accounting. A new root user (uid == 0) is added to the user namespace upon creation. Such root users have full privileges and it seems that theses privileges

[Devel] Re: [ckrm-tech] [PATCH 00/10] Containers(V10): Generic Process Containers

2007-06-08 Thread Serge E. Hallyn
Quoting Paul Jackson ([EMAIL PROTECTED]): > > > The set of people using exclusive cpusets is roughly some subset of > > > those running multiple, cpuset isolated, non-cooperating jobs on big > > > iron, usually with the aid of a batch scheduler. > > > > Unfortunately I would imagine these users to

[Devel] Re: [PATCH][RFC] Cleanup in namespaces unsharing

2007-06-08 Thread Serge E. Hallyn
Quoting Pavel Emelianov ([EMAIL PROTECTED]): > Cedric Le Goater wrote: > > Pavel Emelianov wrote: > >> Cedric Le Goater wrote: > >>> Pavel Emelianov wrote: > > [snip] > > Did I miss something in the design or this patch worth merging? > >>> I've sent a more brutal patch in the past removing

Re: [Devel] breakfast at ols?

2007-06-08 Thread Cedric Le Goater
Serge E. Hallyn wrote: > Quoting Kirill Korotaev ([EMAIL PROTECTED]): >> My apologies, but I won't be able to visit OLS this year :/ >> I think Kirill Kolyshkin and Denis Lunev will be glad to meet you again! >> Hope Pavel Emelianov will be able to join as well. > > I take it based on Cedric's cul

Re: [Devel] breakfast at ols?

2007-06-08 Thread Serge E. Hallyn
Quoting Kirill Korotaev ([EMAIL PROTECTED]): > My apologies, but I won't be able to visit OLS this year :/ > I think Kirill Kolyshkin and Denis Lunev will be glad to meet you again! > Hope Pavel Emelianov will be able to join as well. I take it based on Cedric's culinary requirements we should not

[Devel] Re: [PATCH][RFC] Cleanup in namespaces unsharing

2007-06-08 Thread Pavel Emelianov
Cedric Le Goater wrote: > Pavel Emelianov wrote: >> Cedric Le Goater wrote: >>> Pavel Emelianov wrote: [snip] Did I miss something in the design or this patch worth merging? >>> I've sent a more brutal patch in the past removing CONFIG_IPC_NS >>> and CONFIG_UTS_NS. Might be a better idea ?

[Devel] Re: [PATCH 0/8] RSS controller based on process containers (v3.1)

2007-06-08 Thread Pavel Emelianov
Herbert Poetzl wrote: > On Mon, Jun 04, 2007 at 05:25:25PM +0400, Pavel Emelianov wrote: >> Adds RSS accounting and control within a container. >> >> Changes from v3 >> - comments across the code >> - git-bisect safe split >> - lost places to move the page between active/inactive lists >> >> Por

[Devel] Re: [PATCH 0/8] RSS controller based on process containers (v3.1)

2007-06-08 Thread Herbert Poetzl
On Mon, Jun 04, 2007 at 05:25:25PM +0400, Pavel Emelianov wrote: > Adds RSS accounting and control within a container. > > Changes from v3 > - comments across the code > - git-bisect safe split > - lost places to move the page between active/inactive lists > > Ported above Paul's containers V1

[Devel] Re: [PATCH][RFC] Cleanup in namespaces unsharing

2007-06-08 Thread Cedric Le Goater
Pavel Emelianov wrote: > Cedric Le Goater wrote: >> Pavel Emelianov wrote: >>> Currently we have two funtions to copy the namespaces: >>> copy_namespaces() and unshare_nsproxy_namespaces(). The >>> second one checks for unsupported functionality with >>> >>> #ifndef CONFIG_IPC_NS >>> if (unshar

[Devel] [PATCH -mm] remove CONFIG_UTS_NS and CONFIG_IPC_NS

2007-06-08 Thread Cedric Le Goater
CONFIG_UTS_NS and CONFIG_IPC_NS have very little value as they only deactivate the unshare of the uts and ipc namespaces and do not improve performance. Signed-off-by: Cedric Le Goater <[EMAIL PROTECTED]> Acked-by: "Serge E. Hallyn" <[EMAIL PROTECTED]> Cc: Eric W. Biederman <[EMAIL PROTECTED]> Cc:

[Devel] Re: [PATCH][RFC] Cleanup in namespaces unsharing

2007-06-08 Thread Pavel Emelianov
Cedric Le Goater wrote: > Pavel Emelianov wrote: >> Currently we have two funtions to copy the namespaces: >> copy_namespaces() and unshare_nsproxy_namespaces(). The >> second one checks for unsupported functionality with >> >> #ifndef CONFIG_IPC_NS >> if (unshare_flags & CLONE_NEWIPC) >>

[Devel] Re: [ckrm-tech] Per container statistics (containerstats)

2007-06-08 Thread Balbir Singh
Balbir Singh wrote: > Balbir Singh wrote: return *(pid_t *)a - *(pid_t *)b; diff -puN kernel/sched.c~containers-taskstats kernel/sched.c --- linux-2.6.22-rc2-mm1/kernel/sched.c~containers-taskstats 2007-06-05 17:21:57.0 +0530 +++ linux-2.6.22-rc2-mm1-balbi

[Devel] Re: [ckrm-tech] Per container statistics (containerstats)

2007-06-08 Thread Balbir Singh
Balbir Singh wrote: >>> return *(pid_t *)a - *(pid_t *)b; >>> diff -puN kernel/sched.c~containers-taskstats kernel/sched.c >>> --- linux-2.6.22-rc2-mm1/kernel/sched.c~containers-taskstats >>> 2007-06-05 17:21:57.0 +0530 >>> +++ linux-2.6.22-rc2-mm1-balbir/kernel/sched.c 200

[Devel] Re: [PATCH][RFC] Cleanup in namespaces unsharing

2007-06-08 Thread Cedric Le Goater
Pavel Emelianov wrote: > Currently we have two funtions to copy the namespaces: > copy_namespaces() and unshare_nsproxy_namespaces(). The > second one checks for unsupported functionality with > > #ifndef CONFIG_IPC_NS > if (unshare_flags & CLONE_NEWIPC) > return -EINVAL; > #en

[Devel] [PATCH][RFC] Cleanup in namespaces unsharing

2007-06-08 Thread Pavel Emelianov
Currently we have two funtions to copy the namespaces: copy_namespaces() and unshare_nsproxy_namespaces(). The second one checks for unsupported functionality with #ifndef CONFIG_IPC_NS if (unshare_flags & CLONE_NEWIPC) return -EINVAL; #endif -like constructions, while the

[Devel] Re: [PATCH 2/6] user namespace : add unshare

2007-06-08 Thread Pavel Emelianov
Serge E. Hallyn wrote: >>From nobody Mon Sep 17 00:00:00 2001 > From: Serge E. Hallyn <[EMAIL PROTECTED]> > Date: Thu, 5 Apr 2007 13:00:47 -0400 > Subject: [PATCH 2/6] user namespace : add unshare > > Changelog: Fix !CONFIG_USER_NS clone with CLONE_NEWUSER so it returns -EINVAL > rather than

[Devel] Re: [PATCH 1/6] user namespace : add the framework

2007-06-08 Thread Pavel Emelianov
Serge E. Hallyn wrote: >>From nobody Mon Sep 17 00:00:00 2001 > From: Cedric Le Goater <[EMAIL PROTECTED]> > Date: Thu, 5 Apr 2007 12:51:51 -0400 > Subject: [PATCH 1/6] user namespace : add the framework > > Add the user namespace struct and framework > > Basically, it will allow a process to uns