On Feb 19, 2008 9:17 PM, Paul Jackson <[EMAIL PROTECTED]> wrote:
>
> Perhaps my primary concern with these *.api files was that I did not
> understand who or what the critical use or user was; who found this
> essential, not just nice to have.
>
Right now, no-one would find it essential. If/when a
Paul M wrote:
> I guess it's not essential, I just figured that if we had that
> information, it made sense to make it available to userspace. I guess
> I'm happy with dropping the actual exposed cgroup.api file for now as
> long as we can work towards reducing the number of control files that
> ju
On Feb 18, 2008 12:39 AM, Li Zefan <[EMAIL PROTECTED]> wrote:
> Misc fixes and updates, make the doc consistent with current
> cgroup implementation.
>
> Signed-off-by: Li Zefan <[EMAIL PROTECTED]>
Acked-by: Paul Menage <[EMAIL PROTECTED]>
Thanks for these cleanups.
Paul
> ---
> Documentation/
On Feb 17, 2008 9:49 PM, Li Zefan <[EMAIL PROTECTED]> wrote:
> opts.release_agent is not kfree()ed in all necessary places.
>
> Signed-off-by: Li Zefan <[EMAIL PROTECTED]>
Acked-by: Paul Menage <[EMAIL PROTECTED]>
Good catch, although hopefully something that would be extremely rare
in practice.
On Feb 17, 2008 9:49 PM, Li Zefan <[EMAIL PROTECTED]> wrote:
> The list head res->tasks gets initialized twice in find_css_set().
>
> Signed-off-by: Li Zefan <[EMAIL PROTECTED]>
Acked-by: Paul Menage <[EMAIL PROTECTED]>
> ---
> kernel/cgroup.c |1 -
> 1 files changed, 0 insertions(+), 1 dele
On Feb 17, 2008 9:49 PM, Li Zefan <[EMAIL PROTECTED]> wrote:
> fix:
> - comments about need_forkexit_callback
> - comments about release agent
> - typo and comment style, etc.
>
> Signed-off-by: Li Zefan <[EMAIL PROTECTED]>
> ---
> include/linux/cgroup.h |2 +-
> kernel/cgroup.c| 44
On Feb 17, 2008 9:49 PM, Li Zefan <[EMAIL PROTECTED]> wrote:
> Cgroup uses unsigned long for subsys bitops, not unsigned long long.
>
> Signed-off-by: Li Zefan <[EMAIL PROTECTED]>
Acked-by: Paul Menage <[EMAIL PROTECTED]>
> ---
> kernel/cgroup.c |4 ++--
> 1 files changed, 2 insertions(+), 2
On Feb 17, 2008 9:49 PM, Li Zefan <[EMAIL PROTECTED]> wrote:
> - replace old name 'cont' with 'cgrp' (Paul Menage did this cleanup for
> cgroup.c in commit bd89aabc6761de1c35b154fe6f914a445d301510)
> - remove a duplicate declaration of cgroup_path()
>
> Signed-off-by: Li Zefan <[EMAIL PROTECTED]>
On Feb 18, 2008 1:45 AM, Li Zefan <[EMAIL PROTECTED]> wrote:
> >
>
> But we don't have /proc/proc.api or /sys/sysfs.api ...
True. And /proc is a bit of a mess. Having a similar API file for
sysfs sounds like a good idea to me.
>
> And is it better to describe the debug subsystem too?
>
Yes, prob
On Feb 19, 2008 1:57 PM, Paul Jackson <[EMAIL PROTECTED]> wrote:
>
> Finally, it goes against the one thingie per file (at most, one scalar
> vector) that has worked well for us when tried.
Right, I like the idea of keeping things simple. But if you're going
to accept that a vector is useful, then
On Tue, 2008-02-19 at 18:16 +0100, Nadia Derbey wrote:
> +#define MAX_MSGQUEUES 16 /* MSGMNI as defined in linux/msg.h */
> +
It's not quite the maximum anymore, is it? More like the minumum
maximum ;). A better name might better document what the test is
actually trying to do.
One ques
Li Zefan wrote:
> It seems to me this is a little messy.
Agreed. It looks too finicky to base real software on; that is, I
doubt that any robust application or user level software is going to
depend on it for serious automated self-configuration.
I haven't seen a serious problem with cpuset doc
Subrata Modak wrote:
Nadia Derbey wrote:
Andrew Morton wrote:
On Mon, 11 Feb 2008 15:16:47 +0100 [EMAIL PROTECTED] wrote:
[PATCH 01/08]
This patch computes msg_ctlmni to make it scale with the amount of
lowmem.
msg_ctlmni is now set to make the message queues occupy 1/32 of the
availa
Daniel Lezcano wrote:
Denis V. Lunev wrote:
On Tue, 2008-02-19 at 10:51 +0100, Daniel Lezcano wrote:
Denis V. Lunev wrote:
On Tue, 2008-02-19 at 10:14 +0100, Daniel Lezcano wrote:
Denis V. Lunev wrote:
Default ARP parameters should be findable regardless of the context.
Required to make inet
Denis V. Lunev wrote:
They do exactly the same job.
Signed-off-by: Denis V. Lunev <[EMAIL PROTECTED]>
---
net/ipv4/netfilter/ipt_MASQUERADE.c | 14 ++
1 files changed, 2 insertions(+), 12 deletions(-)
Looks fine.
___
Devel mailing lis
release_net is missed on the error path in pneigh_lookup.
Signed-off-by: Denis V. Lunev <[EMAIL PROTECTED]>
---
net/core/neighbour.c |1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/net/core/neighbour.c b/net/core/neighbour.c
index 7bb6a9a..174e29e 100644
--- a/net/core/ne
Denis V. Lunev wrote:
On Tue, 2008-02-19 at 10:51 +0100, Daniel Lezcano wrote:
Denis V. Lunev wrote:
On Tue, 2008-02-19 at 10:14 +0100, Daniel Lezcano wrote:
Denis V. Lunev wrote:
Default ARP parameters should be findable regardless of the context.
Required to make inetdev_event working.
Sig
On Tue, 2008-02-19 at 10:51 +0100, Daniel Lezcano wrote:
> Denis V. Lunev wrote:
> > On Tue, 2008-02-19 at 10:14 +0100, Daniel Lezcano wrote:
> >> Denis V. Lunev wrote:
> >>> Default ARP parameters should be findable regardless of the context.
> >>> Required to make inetdev_event working.
> >>>
> >
Denis V. Lunev wrote:
On Tue, 2008-02-19 at 10:14 +0100, Daniel Lezcano wrote:
Denis V. Lunev wrote:
Default ARP parameters should be findable regardless of the context.
Required to make inetdev_event working.
Signed-off-by: Denis V. Lunev <[EMAIL PROTECTED]>
---
net/core/neighbour.c |4 +
On Tue, 2008-02-19 at 10:14 +0100, Daniel Lezcano wrote:
> Denis V. Lunev wrote:
> > Default ARP parameters should be findable regardless of the context.
> > Required to make inetdev_event working.
> >
> > Signed-off-by: Denis V. Lunev <[EMAIL PROTECTED]>
> > ---
> > net/core/neighbour.c |4 +
Denis V. Lunev wrote:
Default ARP parameters should be findable regardless of the context.
Required to make inetdev_event working.
Signed-off-by: Denis V. Lunev <[EMAIL PROTECTED]>
---
net/core/neighbour.c |4 +---
1 files changed, 1 insertions(+), 3 deletions(-)
diff --git a/net/core/neig
> Nadia Derbey wrote:
> > Andrew Morton wrote:
> >
> >> On Mon, 11 Feb 2008 15:16:47 +0100 [EMAIL PROTECTED] wrote:
> >>
> >>
> >>> [PATCH 01/08]
> >>>
> >>> This patch computes msg_ctlmni to make it scale with the amount of
> >>> lowmem.
> >>> msg_ctlmni is now set to make the message queues occ
22 matches
Mail list logo
