[Devel] Re: [LTP] [PATCH 1/8] Scaling msgmni to the amount of lowmem

2008-02-21 Thread Nadia Derbey
Subrata Modak wrote: Nadia Derbey wrote: Matt Helsley wrote: On Tue, 2008-02-19 at 18:16 +0100, Nadia Derbey wrote: +#define MAX_MSGQUEUES 16 /* MSGMNI as defined in linux/msg.h */ + It's not quite the maximum anymore, is it? More like the minumum maximum ;). A better name migh

[Devel] Re: [PATCH 2/7] cgroup: fix comments

2008-02-21 Thread Paul Menage
On Wed, Feb 20, 2008 at 6:14 PM, Li Zefan <[EMAIL PROTECTED]> wrote: > Paul Menage wrote: > > I think that docbook-style function comments need /** at the start of > > the comment block. > > > > Yes, I didn't notice it. I revised the patch to fix it. > > > --- > > > fix: > - comments about n

[Devel] Re: [PATCH 4/4] The control group itself

2008-02-21 Thread Paul Menage
On Thu, Feb 7, 2008 at 5:01 AM, Pavel Emelyanov <[EMAIL PROTECTED]> wrote: > + > +[cb] :(|*) [r-][w-] > + ^ ^ ^ > + | | | > + | | +--- access rights (1) > + | | > + | +-- device major and minor numbers (2)

[Devel] Automatic Load Balancing Virtual Machine for OpenVZ

2008-02-21 Thread Jonathan 'Arrouan' ROUZAUD-CORNABAS
At SSTIC (french security conference), Jonathan ROUZAUD-CORNABAS will present another approach of LBVM proposal that support fully automatic live migration on a grid of computer. The virtualization is based on OpenVZ and apply for Secured Remote Desktop. More info: http://www.sstic.org/ Jonath

[Devel] Re: [LTP] [PATCH 1/8] Scaling msgmni to the amount of lowmem

2008-02-21 Thread Subrata Modak
> Nadia Derbey wrote: > > Matt Helsley wrote: > > > >> On Tue, 2008-02-19 at 18:16 +0100, Nadia Derbey wrote: > >> > >> > >> > >>> +#define MAX_MSGQUEUES 16 /* MSGMNI as defined in linux/msg.h */ > >>> + > >> > >> > >> > >> It's not quite the maximum anymore, is it? More like the minumum >

[Devel] Re: [LTP] [PATCH 1/8] Scaling msgmni to the amount of lowmem

2008-02-21 Thread Nadia Derbey
Nadia Derbey wrote: Matt Helsley wrote: On Tue, 2008-02-19 at 18:16 +0100, Nadia Derbey wrote: +#define MAX_MSGQUEUES 16 /* MSGMNI as defined in linux/msg.h */ + It's not quite the maximum anymore, is it? More like the minumum maximum ;). A better name might better document what t

[Devel] Re: [PATCH] Don't limit the number of tunnels with generic name explicitly.

2008-02-21 Thread Patrick McHardy
Pavel Emelyanov wrote: Patrick McHardy wrote: Pavel Emelyanov wrote: Patrick McHardy wrote: It would be nicer to replace the entire hand-made name allocation to remove the 100 device limit. Actually, I thought the same, but fixing % in names looks like a BUG-fix for 2.6.25, while removing t

[Devel] Re: [LTP] [PATCH 1/8] Scaling msgmni to the amount of lowmem

2008-02-21 Thread Nadia Derbey
Matt Helsley wrote: > On Tue, 2008-02-19 at 18:16 +0100, Nadia Derbey wrote: > > > >>+#define MAX_MSGQUEUES 16 /* MSGMNI as defined in linux/msg.h */ >>+ > > > It's not quite the maximum anymore, is it? More like the minumum > maximum ;). A better name might better document what the test

[Devel] [PATCH] Don't limit the number of tunnels with generic name explicitly.

2008-02-21 Thread Pavel Emelyanov
Patrick McHardy wrote: > Pavel Emelyanov wrote: >> Patrick McHardy wrote: >> >>> It would be nicer to replace the entire hand-made name >>> allocation to remove the 100 device limit. >>> >> Actually, I thought the same, but fixing % in names looks like a >> BUG-fix for 2.6.25, while removing the h

[Devel] Re: [PATCH] Don't create tunnels with '%' in name.

2008-02-21 Thread Patrick McHardy
Pavel Emelyanov wrote: Patrick McHardy wrote: It would be nicer to replace the entire hand-made name allocation to remove the 100 device limit. Actually, I thought the same, but fixing % in names looks like a BUG-fix for 2.6.25, while removing the hand-made name allocation looks like an en

[Devel] Re: [PATCH] Don't create tunnels with '%' in name.

2008-02-21 Thread Pavel Emelyanov
Patrick McHardy wrote: > Pavel Emelyanov wrote: >> Four tunnel drivers (ip_gre, ipip, ip6_tunnel and sit) can >> receive a pre-defined name for a device from the userspace. >> Since these drivers call the register_netdevice() after this >> (rtnl_lock is held), the device's name may contain a '%'

[Devel] Re: [PATCH] Don't create tunnels with '%' in name.

2008-02-21 Thread Patrick McHardy
Pavel Emelyanov wrote: Four tunnel drivers (ip_gre, ipip, ip6_tunnel and sit) can receive a pre-defined name for a device from the userspace. Since these drivers call the register_netdevice() after this (rtnl_lock is held), the device's name may contain a '%' character. Not sure how bad is th

[Devel] [PATCH] Don't create tunnels with '%' in name.

2008-02-21 Thread Pavel Emelyanov
Four tunnel drivers (ip_gre, ipip, ip6_tunnel and sit) can receive a pre-defined name for a device from the userspace. Since these drivers call the register_netdevice() after this (rtnl_lock is held), the device's name may contain a '%' character. Not sure how bad is this to have a device with a

[Devel] Re: [LTP] [PATCH 1/8] Scaling msgmni to the amount of lowmem

2008-02-21 Thread Nadia Derbey
Matt Helsley wrote: > On Tue, 2008-02-19 at 18:16 +0100, Nadia Derbey wrote: > > > >>+#define MAX_MSGQUEUES 16 /* MSGMNI as defined in linux/msg.h */ >>+ > > > It's not quite the maximum anymore, is it? More like the minumum > maximum ;). A better name might better document what the test