[Devel] Re: [RFC][PATCH 5/5] Add a Signal Control Group Subsystem

2008-04-24 Thread Paul Menage
I don't think you need cgroup_signal.h. It's only included in cgroup_signal.c, and doesn't really contain any useful definitions anyway. You should just use a cgroup_subsys_state object as your state object, since you'll never need to do anything with it anyway. >+static struct cgroup_subsys_state

[Devel] Re: [RFC][PATCH 3/5] Container Freezer: Implement freezer cgroup subsystem

2008-04-24 Thread Paul Menage
>+static const char *freezer_state_strs[] = { >+ "RUNNING\n", >+ "FREEZING\n" , >+ "FROZEN\n" >+}; I think it might be cleaner to not include the \n characters in this array. >+static inline int cgroup_frozen(struct task_struct *task) >+{ >+ struct cgroup *cgroup = task_cgroup

[Devel] Re: Checkpoint/restart (was Re: [PATCH 0/4] - v2 - Object creation with a specified id)

2008-04-24 Thread Oren Laadan
Dave Hansen wrote: > On Thu, 2008-04-24 at 11:00 +0400, Kirill Korotaev wrote: >> Yeah... we talked with Andrew yesterday. He mostly agrees with a black >> box. >> He also said an interesting idea, that if you need compatibility >> between the kernels (like we for example, support for migration f

[Devel] Re: [RFC][PATCH 5/5] Add a Signal Control Group Subsystem

2008-04-24 Thread Paul Jackson
> +static struct cftype kill_file = { > + .name = "kill", The name "kill" seems ambiguous to me. It suggests that any write will send some default signal (TERM or KILL?) to all tasks in the cgroup, rather like the 'killall' command. I'm guessing that more people, on seeing this file in a cgr

[Devel] Re: Checkpoint/restart (was Re: [PATCH 0/4] - v2 - Object creation with a specified id)

2008-04-24 Thread Dave Hansen
On Thu, 2008-04-24 at 11:00 +0400, Kirill Korotaev wrote: > Yeah... we talked with Andrew yesterday. He mostly agrees with a black > box. > He also said an interesting idea, that if you need compatibility > between the kernels (like we for example, support for migration from > 2.6.9 to 2.6.18 in Op

[Devel] Utility tool for dm-ioband.

2008-04-24 Thread KAIZUKA Hiroyuki
Hi everyone, I made a utility tool for dm-ioband version 0.0.4, named iobandctl. It enables you to easily apply I/O bandwidth control to an entire disk, and manage it. It helps you set the percentage of bandwidth to give each partition, and each user, process, group, or cgroup. (You are not able

[Devel] [PATCH 2/2] dm-ioband: I/O bandwidth controller v0.0.4: Document

2008-04-24 Thread Ryo Tsuruta
Here is the document of dm-ioband. Based on 2.6.25 Signed-off-by: Ryo Tsuruta <[EMAIL PROTECTED]> Signed-off-by: Hirokazu Takahashi <[EMAIL PROTECTED]> diff -uprN linux-2.6.25.orig/Documentation/device-mapper/ioband.txt linux-2.6.25/Documentation/device-mapper/ioband.txt --- linux-2.6.25.orig/Do

[Devel] [PATCH 1/2] dm-ioband: I/O bandwidth controller v0.0.4: Source code and patch

2008-04-24 Thread Ryo Tsuruta
Here is the patch of dm-ioband. Based on 2.6.25 Signed-off-by: Ryo Tsuruta <[EMAIL PROTECTED]> Signed-off-by: Hirokazu Takahashi <[EMAIL PROTECTED]> diff -uprN linux-2.6.25.orig/drivers/md/dm-ioband-ctl.c linux-2.6.25/drivers/md/dm-ioband-ctl.c --- linux-2.6.25.orig/drivers/md/dm-ioband-ctl.c

[Devel] [PATCH 0/2] dm-ioband: I/O bandwidth controller v0.0.4: Introduction

2008-04-24 Thread Ryo Tsuruta
Hi everyone, This is dm-ioband version 0.0.4 release. Dm-ioband is an I/O bandwidth controller implemented as a device-mapper driver, which gives specified bandwidth to each job running on the same physical device. Changes since 0.0.3 (5th February): - Improve the performance when many proces

[Devel] Re: [RFC][PATCH 1/5] Container Freezer: Add TIF_FREEZE flag to all architectures

2008-04-24 Thread Pavel Machek
On Wed 2008-04-23 23:47:57, Matt Helsley wrote: > This patch is the first step in making the refrigerator() available > to all architectures, even for those without power management. > > The purpose of such a change is to be able to use the refrigerator() > in a new control group subsystem whic

[Devel] Re: Checkpoint/restart (was Re: [PATCH 0/4] - v2 - Object creation with a specified id)

2008-04-24 Thread Kirill Korotaev
Yeah... we talked with Andrew yesterday. He mostly agrees with a black box. He also said an interesting idea, that if you need compatibility between the kernels (like we for example, support for migration from 2.6.9 to 2.6.18 in OpenVZ) you can do image conversion in user-space... Though I think w

[Devel] Re: [RFC PATCH 5/5] Add a Signal Control Group Subsystem

2008-04-24 Thread Matt Helsley
On Wed, 2008-04-23 at 08:37 -0700, Paul Menage wrote: > On Wed, Apr 23, 2008 at 8:17 AM, Cedric Le Goater <[EMAIL PROTECTED]> wrote: > > Hello Matt ! > > > > > Add a signal control group subsystem that allows us to send signals to > > all tasks > > > in the control group by writing the desired

[Devel] [RFC][PATCH 3/5] Container Freezer: Implement freezer cgroup subsystem

2008-04-24 Thread Matt Helsley
This patch implements a new freezer subsystem for Paul Menage's control groups framework. It provides a way to stop and resume execution of all tasks in a cgroup by writing in the cgroup filesystem. This is the basic mechanism which should do the right thing for user space tasks in a simple sc

[Devel] [RFC][PATCH 2/5] Container Freezer: Make refrigerator always available

2008-04-24 Thread Matt Helsley
Now that the TIF_FREEZE flag is available in all architectures, extract the refrigerator() and freeze_task() from kernel/power/process.c and make it available to all. The refrigerator() can now be used in a control group subsystem implementing a control group freezer. Signed-off-by: Cedric Le Go