[Devel] Re: [RFC][PATCH 3/5] Container Freezer: Implement freezer cgroup subsystem

2008-04-30 Thread Matt Helsley
On Wed, 2008-04-30 at 14:28 -0700, Matt Helsley wrote: > On Wed, 2008-04-23 at 23:47 -0700, Matt Helsley wrote: > > > > + cgroup_lock(); > > + > > + if (cgroup_is_removed(cgroup)) { > > + retval = -ENODEV; > > + goto unlock; > > + } > > I think this was copy/paste'd f

[Devel] Re: [PATCH 10/10] sysfs: user namespaces: add ns to user_struct

2008-04-30 Thread Eric W. Biederman
"Serge E. Hallyn" <[EMAIL PROTECTED]> writes: > Quoting Eric W. Biederman ([EMAIL PROTECTED]): >> "Serge E. Hallyn" <[EMAIL PROTECTED]> writes: >> >> >> > Index: linux-mm/include/linux/sched.h >> >> > === >> >> > --- linux-mm.orig/in

[Devel] Re: [RFC][PATCH 3/5] Container Freezer: Implement freezer cgroup subsystem

2008-04-30 Thread Matt Helsley
On Wed, 2008-04-23 at 23:47 -0700, Matt Helsley wrote: > +static ssize_t freezer_write(struct cgroup *cgroup, > + struct cftype *cft, > + struct file *file, > + const char __user *userbuf, > + si

[Devel] Re: [RFC][PATCH 5/5] Add a Signal Control Group Subsystem

2008-04-30 Thread Matt Helsley
On Fri, 2008-04-25 at 13:41 +0200, Cedric Le Goater wrote: > Matt Helsley wrote: > > Add a signal control group subsystem that allows us to send signals to all > > tasks > > in the control group by writing the desired signal(7) number to the kill > > file. > > > > NOTE: We don't really need per

[Devel] Re: [PATCH 10/10] sysfs: user namespaces: add ns to user_struct

2008-04-30 Thread Serge E. Hallyn
Quoting Eric W. Biederman ([EMAIL PROTECTED]): > "Serge E. Hallyn" <[EMAIL PROTECTED]> writes: > > >> > Index: linux-mm/include/linux/sched.h > >> > === > >> > --- linux-mm.orig/include/linux/sched.h > >> > +++ linux-mm/include/linux/

[Devel] Re: [RFC][PATCH 3/5] Container Freezer: Implement freezer cgroup subsystem

2008-04-30 Thread Matt Helsley
On Thu, 2008-04-24 at 22:51 -0700, Paul Menage wrote: > >+static const char *freezer_state_strs[] = { > >+"RUNNING\n", > >+"FREEZING\n" , > >+"FROZEN\n" > >+}; > > I think it might be cleaner to not include the \n characters in this array. Sure. Though that might produce weird output

[Devel] Re: [RFC][PATCH 2/5] Container Freezer: Make refrigerator always available

2008-04-30 Thread Matt Helsley
On Fri, 2008-04-25 at 13:04 +0200, Pavel Machek wrote: > Hi! > > > Now that the TIF_FREEZE flag is available in all architectures, > > extract the refrigerator() and freeze_task() from kernel/power/process.c > > and make it available to all. > > > > The refrigerator() can now be used in a contro

[Devel] Re: [RFC][PATCH 5/5] Add a Signal Control Group Subsystem

2008-04-30 Thread Matt Helsley
On Thu, 2008-04-24 at 23:01 -0700, Paul Menage wrote: > I don't think you need cgroup_signal.h. It's only included in > cgroup_signal.c, and doesn't really contain any useful definitions > anyway. You should just use a cgroup_subsys_state object as your state > object, since you'll never need to d

[Devel] Re: [RFC][PATCH 5/5] Add a Signal Control Group Subsystem

2008-04-30 Thread Paul Jackson
Matt wrote: > OK, I renamed it signal.send I'm not familiar with the cgroup subsystem naming conventions, but modulo that, this looks good to me - thanks! -- I won't rest till it's the best ... Programmer, Linux Scalability Paul Jackson <[EMA

[Devel] Re: [RFC][PATCH 5/5] Add a Signal Control Group Subsystem

2008-04-30 Thread Matt Helsley
On Thu, 2008-04-24 at 14:30 -0500, Paul Jackson wrote: > > +static struct cftype kill_file = { > > + .name = "kill", > > The name "kill" seems ambiguous to me. It suggests that any write > will send some default signal (TERM or KILL?) to all tasks in the > cgroup, rather like the 'killall' com