Paul Menage wrote:
> On Tue, Jul 1, 2008 at 11:16 PM, Li Zefan <[EMAIL PROTECTED]> wrote:
>> kernel/res_counter.c: In function 'res_counter_memparse_write_strategy':
>> kernel/res_counter.c:115: error: implicit declaration of function
>> 'PAGE_ALIGN'
>>
>> Signed-off-by: Li Zefan <[EMAIL PROTECTED
On Tue, Jul 1, 2008 at 11:16 PM, Li Zefan <[EMAIL PROTECTED]> wrote:
> kernel/res_counter.c: In function 'res_counter_memparse_write_strategy':
> kernel/res_counter.c:115: error: implicit declaration of function 'PAGE_ALIGN'
>
> Signed-off-by: Li Zefan <[EMAIL PROTECTED]>
Acked-by: Paul Menage <[E
kernel/res_counter.c: In function 'res_counter_memparse_write_strategy':
kernel/res_counter.c:115: error: implicit declaration of function 'PAGE_ALIGN'
Signed-off-by: Li Zefan <[EMAIL PROTECTED]>
---
should follow
cgroup-files-convert-res_counter_write-to-be-a-cgroups-write_string-handler.patc
Hello,
Eric W. Biederman wrote:
>>> A directory displaying only a single tag is an necessary constraint for
>>> a large number of reasons.
>> Okay, that isn't exactly the impression I get but... well. Let's see.
>
> Well one of those reasons is not having duplicate entries in your directory
> l
Tejun Heo <[EMAIL PROTECTED]> writes:
> Hello,
>
> Eric W. Biederman wrote:
>> What we are implementing is not, a sb with a set of tags that are displayed,
>> but directories with a single tag that is displayed. The sb just happens
>> to hold the state for the directories.
>>
>> A directory disp
Hello,
Eric W. Biederman wrote:
> What we are implementing is not, a sb with a set of tags that are displayed,
> but directories with a single tag that is displayed. The sb just happens
> to hold the state for the directories.
>
> A directory displaying only a single tag is an necessary constrai
On Tue, Jul 01, 2008 at 11:48:31PM +0200, Andrea Righi wrote:
> Li Zefan wrote:
>> CC: Paul Jackson <[EMAIL PROTECTED]>
>>
>> Dhaval Giani wrote:
>>> [put in the wrong alias for containers list correcting it.]
>>>
>>> On Tue, Jul 01, 2008 at 03:15:45PM +0530, Dhaval Giani wrote:
Hi Paul,
Li Zefan wrote:
> CC: Paul Jackson <[EMAIL PROTECTED]>
>
> Dhaval Giani wrote:
>> [put in the wrong alias for containers list correcting it.]
>>
>> On Tue, Jul 01, 2008 at 03:15:45PM +0530, Dhaval Giani wrote:
>>> Hi Paul,
>>>
>>> Attaching PID 0 to a cgroup caused the current task to be attached
On Tue, Jul 1, 2008 at 3:28 AM, Li Zefan <[EMAIL PROTECTED]> wrote:
>
> Why is it unexpected? it follows the behavior of cpuset, so this patch will
> break backward compatibility of cpuset.
Agreed. I think we want to keep this behaviour.
Paul
___
Contai
> But it's better to document this.
Good idea.
Acked-by: Paul Jackson <[EMAIL PROTECTED]>
You (Li Zefan) might want to resend this as a patch, in case Andrew
doesn't happen to see this embedded here.
Something like the following:
Subject: [PATCH] cgroup: document zero pid means current task
Tejun Heo <[EMAIL PROTECTED]> writes:
> Hello,
>
> Eric W. Biederman wrote:
>>> Having enumed tag types limits that a sb can have map to only one tag
>>> but it doesn't really prevent multiple possibly visible entries which is
>>> the real unnecessary degrees of freedom. That said, I don't really
On Tue, Jul 01, 2008 at 06:28:07PM +0800, Li Zefan wrote:
> CC: Paul Jackson <[EMAIL PROTECTED]>
>
> Dhaval Giani wrote:
> > [put in the wrong alias for containers list correcting it.]
> >
> > On Tue, Jul 01, 2008 at 03:15:45PM +0530, Dhaval Giani wrote:
> >> Hi Paul,
> >>
> >> Attaching PID 0 to
CC: Paul Jackson <[EMAIL PROTECTED]>
Dhaval Giani wrote:
> [put in the wrong alias for containers list correcting it.]
>
> On Tue, Jul 01, 2008 at 03:15:45PM +0530, Dhaval Giani wrote:
>> Hi Paul,
>>
>> Attaching PID 0 to a cgroup caused the current task to be attached to
>> the cgroup. Looking a
Hello,
Eric W. Biederman wrote:
>> Having enumed tag types limits that a sb can have map to only one tag
>> but it doesn't really prevent multiple possibly visible entries which is
>> the real unnecessary degrees of freedom. That said, I don't really
>> think it's an issue.
>
> Having a single t
[put in the wrong alias for containers list correcting it.]
On Tue, Jul 01, 2008 at 03:15:45PM +0530, Dhaval Giani wrote:
> Hi Paul,
>
> Attaching PID 0 to a cgroup caused the current task to be attached to
> the cgroup. Looking at the code,
>
> if (pid) {
> rcu_read_lock
Tejun Heo <[EMAIL PROTECTED]> writes:
> Hello, Eric.
>
> Eric W. Biederman wrote:
>>> It's still dynamic from sysfs's POV and I think that will make
>>> maintenance more difficult.
>>
>> Potentially. I have no problem make it clear that things are more static.
>
> Great. :-)
>
> Having enumed t
On Tue, 01 Jul 2008 16:43:30 +0800 Li Zefan <[EMAIL PROTECTED]> wrote:
> > The whole patch doesn't do anything. Perhaps there's another patch in
> > the pipeline somewhere which adds one or more ->subsys_depend
> > implementations, but I cannot find it. If so, I'd have expected this
> > patch to
>> +int subsys_depend(struct cgroup_subsys *ss, unsigned long subsys_bits)
>> +
>> +Called when a cgroup subsystem wants to check if some other subsystems
>> +are also present in the proposed hierarchy. If this method returns error,
>> +the mount of the cgroup filesystem will fail.
>
> OK, but the
Andrew Morton wrote:
>>> Reviewed-by: Paul Menage <[EMAIL PROTECTED]>
>> Thanks for the review!
>>
>
> yup, thanks.
>
> I'll duck the patch until we have some code which uses it. Please
> retain Paul's Reviewed-by: for that occasion.
Sure, I'll keep the reviewed-by around. I might move over to
On Sat, 21 Jun 2008 13:35:38 +0530 Balbir Singh <[EMAIL PROTECTED]> wrote:
> Paul Menage wrote:
> > On Wed, Jun 18, 2008 at 6:48 AM, Balbir Singh <[EMAIL PROTECTED]> wrote:
> >> Some of the common code has been factored into heap_adjust() a.k.a heapify
> >> in data structures terminology.
> >>
> >
On Thu, 19 Jun 2008 09:51:36 +0800 Li Zefan <[EMAIL PROTECTED]> wrote:
> This allows one subsystem to require that it only be mounted when some
> other subsystems are also present in the proposed hierarchy.
>
> For example if subsystem foo depends on bar, the following will fail:
> # mount -t cg
"Serge E. Hallyn" <[EMAIL PROTECTED]> writes:
> Now that the iproute2 patch is upstream, this patchset really is the
> only thing keeping us from using network namespaces. Given that the
> details of the tagging are trivially changeable with no abi changes, I'd
> personally much rather see the pa
"Serge E. Hallyn" <[EMAIL PROTECTED]> writes:
> Quoting Eric W. Biederman ([EMAIL PROTECTED]):
>>
>> The very important points are that it is a remount of an existing mount
>> so that we don't have to worry about corrupted filesystem attacks, and
>> that authentication is performed at mount time.
23 matches
Mail list logo
