[Devel] Re: [PATCH 1/1] mm_owner: fix cgroup null dereference

2008-08-19 Thread KAMEZAWA Hiroyuki
On Wed, 20 Aug 2008 13:20:40 +0800 Li Zefan <[EMAIL PROTECTED]> wrote: > Balbir Singh wote: > > * Jiri Slaby <[EMAIL PROTECTED]> [2008-08-14 22:16:53]: > > > >> Hi, > >> > >> found this in mmotm, a fix for > >> mm-owner-fix-race-between-swap-and-exit.patch > >> > > > > Does the patch below fix y

[Devel] Re: RFC: Attaching threads to cgroups is OK?

2008-08-19 Thread Takuya Yoshikawa
Thank you for comments and links! Balbir Singh wrote: > KAMEZAWA Hiroyuki wrote: >>> I mean, in the current implementation, threads created before the >>> attachement of the parent process are not treated eaqually to those >>> created after. >>> >>> Could you tell me if you know something about

[Devel] Re: [PATCH 4/7] bio-cgroup: Split the cgroup memory subsystem into two parts

2008-08-19 Thread Hirokazu Takahashi
Hi, > I'm now writing remove-lock-page-cgroup patches. it works well. > please wait for a while... > >>> I'm looking forward to those patches. > >>> > >>> By the way, I'm glad if memory-cgroup has a feature which can make a > >>> page_cgroup move between cgroups with small overhead. It m

[Devel] Re: [PATCH 1/1] mm_owner: fix cgroup null dereference

2008-08-19 Thread Li Zefan
Balbir Singh wote: > * Jiri Slaby <[EMAIL PROTECTED]> [2008-08-14 22:16:53]: > >> Hi, >> >> found this in mmotm, a fix for >> mm-owner-fix-race-between-swap-and-exit.patch >> > > Does the patch below fix your problem, it's against mmotm 19th August > 2008. > I just triggered this bug. I think y

[Devel] Re: [PATCH 09/15] sysfs: Implement sysfs tagged directory support.

2008-08-19 Thread Greg KH
On Thu, Jul 03, 2008 at 06:16:08PM -0700, Eric W. Biederman wrote: > > The problem. When implementing a network namespace I need to be able > to have multiple network devices with the same name. Currently this > is a problem for /sys/class/net/*, /sys/devices/virtual/net/*, and > potentially a f

[Devel] patch sysfs-sysfs_get_dentry-add-a-sb-parameter.patch added to gregkh-2.6 tree

2008-08-19 Thread gregkh
This is a note to let you know that I've just added the patch titled Subject: sysfs: sysfs_get_dentry add a sb parameter to my gregkh-2.6 tree. Its filename is sysfs-sysfs_get_dentry-add-a-sb-parameter.patch This tree can be found at http://www.kernel.org/pub/linux/kernel/people/

[Devel] patch sysfs-support-for-preventing-unmounts.patch added to gregkh-2.6 tree

2008-08-19 Thread gregkh
This is a note to let you know that I've just added the patch titled Subject: sysfs: Support for preventing unmounts. to my gregkh-2.6 tree. Its filename is sysfs-support-for-preventing-unmounts.patch This tree can be found at http://www.kernel.org/pub/linux/kernel/people/gregkh/

[Devel] patch sysfs-sysfs_chmod_file-handle-multiple-superblocks.patch added to gregkh-2.6 tree

2008-08-19 Thread gregkh
This is a note to let you know that I've just added the patch titled Subject: sysfs: sysfs_chmod_file handle multiple superblocks to my gregkh-2.6 tree. Its filename is sysfs-sysfs_chmod_file-handle-multiple-superblocks.patch This tree can be found at http://www.kernel.org/pub/li

[Devel] patch sysfs-rename-support-multiple-superblocks.patch added to gregkh-2.6 tree

2008-08-19 Thread gregkh
This is a note to let you know that I've just added the patch titled Subject: sysfs: Rename Support multiple superblocks to my gregkh-2.6 tree. Its filename is sysfs-rename-support-multiple-superblocks.patch This tree can be found at http://www.kernel.org/pub/linux/kernel/people/

[Devel] patch sysfs-introduce-sysfs_sd_setattr-and-fix-sysfs_chmod.patch added to gregkh-2.6 tree

2008-08-19 Thread gregkh
This is a note to let you know that I've just added the patch titled Subject: sysfs: Introduce sysfs_sd_setattr and fix sysfs_chmod to my gregkh-2.6 tree. Its filename is sysfs-introduce-sysfs_sd_setattr-and-fix-sysfs_chmod.patch This tree can be found at http://www.kernel.org/pu

[Devel] patch sysfs-implement-__sysfs_get_dentry.patch added to gregkh-2.6 tree

2008-08-19 Thread gregkh
This is a note to let you know that I've just added the patch titled Subject: sysfs: Implement __sysfs_get_dentry to my gregkh-2.6 tree. Its filename is sysfs-implement-__sysfs_get_dentry.patch This tree can be found at http://www.kernel.org/pub/linux/kernel/people/gregkh/gregkh-

[Devel] patch kobject-cleanup-kobject_rename-and-config_sysfs.patch added to gregkh-2.6 tree

2008-08-19 Thread gregkh
This is a note to let you know that I've just added the patch titled Subject: kobject: Cleanup kobject_rename and !CONFIG_SYSFS to my gregkh-2.6 tree. Its filename is kobject-cleanup-kobject_rename-and-config_sysfs.patch This tree can be found at http://www.kernel.org/pub/linux/k

[Devel] [PATCH 6/6] Container Freezer: Document the cgroup freezer subsystem.

2008-08-19 Thread Matt Helsley
Describe why we need the freezer subsystem and how to use it in a documentation file. Since the cgroups.txt file is focused on the subsystem-agnostic portions of cgroups make a directory and move the old cgroups.txt file at the same time. Signed-off-by: Matt Helsley <[EMAIL PROTECTED]> Cc: Andrew

[Devel] [PATCH 3/6] Container Freezer: Make freezer state names less generic

2008-08-19 Thread Matt Helsley
Rename cgroup freezer states to be less generic to avoid any name collisions while also better describing what each state is. Signed-off-by: Matt Helsley <[EMAIL PROTECTED]> Cc: Andrew Morton <[EMAIL PROTECTED]> --- kernel/cgroup_freezer.c | 56

[Devel] [PATCH 5/6] Container Freezer: Rename check_if_frozen()

2008-08-19 Thread Matt Helsley
check_if_frozen() sounds like it should return something when in fact it's just updating the freezer state. Signed-off-by: Matt Helsley <[EMAIL PROTECTED]> Cc: Andrew Morton <[EMAIL PROTECTED]> --- kernel/cgroup_freezer.c | 12 1 file changed, 8 insertions(+), 4 deletions(-) Index

[Devel] [PATCH 0/6] Container Freezer: fixes for -mm

2008-08-19 Thread Matt Helsley
Hi Andrew, These patches stack on top of the series you already have for the container freezer patches. I believe they address all of the comments from you and Rafael so far. Please consider these for -mm. [PATCH 1/6] Container Freezer: Fix freezer Kconfig [PATCH 2/6] Container

[Devel] [PATCH 4/6] Container Freezer: Cleanup comment.

2008-08-19 Thread Matt Helsley
Make this comment clearer. Signed-off-by: Matt Helsley <[EMAIL PROTECTED]> Cc: Andrew Morton <[EMAIL PROTECTED]> --- Andrew was wondering if the comment was in the right place. I think it is but suspect it could stand to be clarified. kernel/cgroup_freezer.c |4 ++-- 1 file changed, 2 insert

[Devel] [PATCH 2/6] Container Freezer: uninline thaw_process()

2008-08-19 Thread Matt Helsley
Now that the cgroup freezer system also calls thaw_process() inlining these functions uses more space. Uninlining returns some space: Before: textdatabss dec hex filename 4260872 275532 290816 4827220 49a854 vmlinux After: textdatabss dec

[Devel] [PATCH 1/6] Container Freezer: Fix freezer Kconfig

2008-08-19 Thread Matt Helsley
kernel/power/Kconfig is not sourced from all architectures but the freezer code should be available to all architectures for the cgroup freezer subsystem. Sourcing a new kernel/Kconfig.freezer has the added advantage of keeping the config definition close to its use in the kernel/Makefile. Signed-

[Devel] Re: [PATCH 1/1] mm_owner: fix cgroup null dereference

2008-08-19 Thread Balbir Singh
* Jiri Slaby <[EMAIL PROTECTED]> [2008-08-14 22:16:53]: > Hi, > > found this in mmotm, a fix for > mm-owner-fix-race-between-swap-and-exit.patch > Does the patch below fix your problem, it's against mmotm 19th August 2008. Reported-by: [EMAIL PROTECTED] Jiri reported a problem and saw an oop

[Devel] Re: [PATCH 4/7] bio-cgroup: Split the cgroup memory subsystem into two parts

2008-08-19 Thread Balbir Singh
Hirokazu Takahashi wrote: > Hi, > I'm now writing remove-lock-page-cgroup patches. it works well. please wait for a while... >>> I'm looking forward to those patches. >>> >>> By the way, I'm glad if memory-cgroup has a feature which can make a >>> page_cgroup move between cgroups with sm

[Devel] Re: RFC: Attaching threads to cgroups is OK?

2008-08-19 Thread Fernando Luis Vázquez Cao
Hi Balbir, Kamezawa-san! On Tue, 2008-08-19 at 17:57 +0530, Balbir Singh wrote: > >> Tsuruta-san, how about your bio-cgroup's tracking concerning this? > >> If we want to use your tracking functions for each threads seperately, > >> there seems to be a problem. > >> ===cf. mm_get_bio_cgroup()

[Devel] Re: [PATCH 4/7] bio-cgroup: Split the cgroup memory subsystem into two parts

2008-08-19 Thread Hirokazu Takahashi
Hi, > >> I'm now writing remove-lock-page-cgroup patches. it works well. > >> please wait for a while... > > > > I'm looking forward to those patches. > > > > By the way, I'm glad if memory-cgroup has a feature which can make a > > page_cgroup move between cgroups with small overhead. It makes >

[Devel] [PATCH] cgroup: memory.force_empty can make system slowdown

2008-08-19 Thread IKEDA, Munehiro
Cgroup's memory controller has a control file "memory.force_empty" to reset usage account charged to a cgroup. The account shouldn't be reset if one or more processes are attached to the cgroup (at least for memory controller, IMHO). So mem_cgroup_force_empty() is implemented to return -EBUSY and

[Devel] Re: RFC: Attaching threads to cgroups is OK?

2008-08-19 Thread Balbir Singh
KAMEZAWA Hiroyuki wrote: > On Tue, 19 Aug 2008 19:38:14 +0900 > Takuya Yoshikawa <[EMAIL PROTECTED]> wrote: > >> Hi everyone, >> >> I have a question about cgroup's policy concerning the treatment of >> threads. Please consider that we want to attach an application which has >> some threads alre

[Devel] Opinion about cgroup network controller

2008-08-19 Thread 김재열
I'm interested in cgroup network controller. As I know, currently announced network controllers are two. One is Andrea's network throttle and the other is Ranjit's TC(Traffic Control) cgroups subsystem(http://lkml.org/lkml/2008/7/22/361). Two implementations is totally different each other.

[Devel] Re: RFC: Attaching threads to cgroups is OK?

2008-08-19 Thread KAMEZAWA Hiroyuki
On Tue, 19 Aug 2008 19:38:14 +0900 Takuya Yoshikawa <[EMAIL PROTECTED]> wrote: > Hi everyone, > > I have a question about cgroup's policy concerning the treatment of > threads. Please consider that we want to attach an application which has > some threads already to a certain cgroup. If we echo

[Devel] RFC: Attaching threads to cgroups is OK?

2008-08-19 Thread Takuya Yoshikawa
Hi everyone, I have a question about cgroup's policy concerning the treatment of threads. Please consider that we want to attach an application which has some threads already to a certain cgroup. If we echo the pid of this application to the "tasks" file connected to this cgroup the threads be

[Devel] Re: [PATCH 1/1] mm_owner: fix cgroup null dereference

2008-08-19 Thread Balbir Singh
Jiri Slaby wrote: > On 08/19/2008 05:37 AM, Balbir Singh wrote: >> Could you please help me with the steps to reproduce the problem. I don't >> seem >> to be hitting the mm->owner changed callback. I did have a test case for it >> when >> I developed mm->owner functionality, but it does not trig

[Devel] Re: [PATCH 1/1] mm_owner: fix cgroup null dereference

2008-08-19 Thread Jiri Slaby
On 08/19/2008 05:37 AM, Balbir Singh wrote: > Could you please help me with the steps to reproduce the problem. I don't > seem > to be hitting the mm->owner changed callback. I did have a test case for it > when > I developed mm->owner functionality, but it does not trigger an oops for me. I ha