[Devel] Re: [RFC] IO Controller

2009-05-04 Thread Gui Jianfeng
Nauman Rafique wrote: ... > Hi Gui, > This patch should solve the problems reported by you. Please let me know if > it does not work. > @Vivek, this has a few more changes after the patch I sent you separately. > Hi Nauman, I'v tried your patch, seems the bug has been fixed. thanks! > DESC

[Devel] Re: [PATCH 2/2] pidns 2/2: rewrite copy_pid_ns()

2009-05-04 Thread Sukadev Bhattiprolu
Alexey Dobriyan [adobri...@gmail.com] wrote: | copy_pid_ns() is a perfect example of a case where unwinding leads to more | code and makes it less clear. Watch the diffstat. Yes, its cleaner this way :-) | | Signed-off-by: Alexey Dobriyan Acked-by: Sukadev Bhattiprolu | --- | kernel/pid_nam

[Devel] Re: [PATCH 1/2] pidns 1/2: make create_pid_namespace() accept parentpidns

2009-05-04 Thread Sukadev Bhattiprolu
Alexey Dobriyan [adobri...@gmail.com] wrote: | create_pid_namespace() creates everything, but caller has to assign parent | pidns by hand, which is unnatural. At the moment of call new ->level has | to be taken from somewhere and parent pidns is already available. | | Signed-off-by: Alexey Dobriya

[Devel] Re: [RFC][PATCH 04/36] btrfs: Add checkpoint file operations

2009-05-04 Thread Matt Helsley
On Mon, May 04, 2009 at 05:25:13PM -0500, Serge E. Hallyn wrote: > Quoting Oren Laadan (or...@cs.columbia.edu): > > > > Serge E. Hallyn wrote: > > > Quoting Matt Helsley (matth...@us.ibm.com): > > > > > > ... > > > > > >> diff --git a/fs/btrfs/super.c b/fs/btrfs/super.c > > >> index a7acfe6..f16

[Devel] Re: [PATCH 4/7] io-throttle controller infrastructure

2009-05-04 Thread Paul E. McKenney
On Sun, May 03, 2009 at 01:36:20PM +0200, Andrea Righi wrote: > This is the core of the io-throttle kernel infrastructure. It creates > the basic interfaces to the cgroup subsystem and implements the I/O > measurement and throttling functionality. Looks good from an RCU perspective!

[Devel] [PATCH][RFC] freezer: Add CHECKPOINTING state to safeguard container checkpoint

2009-05-04 Thread Matt Helsley
The CHECKPOINTING state prevents userspace from unfreezing tasks until sys_checkpoint() is finished. When doing container checkpoint userspace will do: echo FROZEN > /cgroups/my_container/freezer.state ... rc = sys_checkpoint( ); To ensure a consistent checkpoint image userspace should not be al

[Devel] Re: [PATCH 4/7] blkio-cgroup: The body of blkio-cgroup

2009-05-04 Thread Ryo Tsuruta
Hi Andrea, From: Andrea Righi Subject: Re: [PATCH 4/7] blkio-cgroup: The body of blkio-cgroup Date: Mon, 4 May 2009 14:05:45 +0200 > On Tue, Apr 28, 2009 at 09:46:04PM +0900, Ryo Tsuruta wrote: > > The body of bio-cgroup. > > > > Based on 2.6.30-rc3-git3 > > Signed-off-by: Hirokazu Takahashi >

[Devel] Re: [PATCH] range-bw: Another I/O scheduling policy of dm-ioband supporting the predicable I/O bandwidth (range bandwidth)

2009-05-04 Thread Ryo Tsuruta
Hi Dong-Jae From: Dong-Jae Kang Subject: Re: [PATCH] range-bw: Another I/O scheduling policy of dm-ioband supporting the predicable I/O bandwidth (range bandwidth) Date: Mon, 4 May 2009 20:23:04 +0900 > Hi, Ryo > > I released bug-fixed range-bw(V1) controller several minutes ago > > Although

[Devel] Re: [RFC][PATCH 04/36] btrfs: Add checkpoint file operations

2009-05-04 Thread Serge E. Hallyn
Quoting Oren Laadan (or...@cs.columbia.edu): > > Serge E. Hallyn wrote: > > Quoting Matt Helsley (matth...@us.ibm.com): > > > > ... > > > >> diff --git a/fs/btrfs/super.c b/fs/btrfs/super.c > >> index a7acfe6..f16be9d 100644 > >> --- a/fs/btrfs/super.c > >> +++ b/fs/btrfs/super.c > >> @@ -686,6

[Devel] Re: [RFC][PATCH 04/36] btrfs: Add checkpoint file operations

2009-05-04 Thread Oren Laadan
Serge E. Hallyn wrote: > Quoting Matt Helsley (matth...@us.ibm.com): > > ... > >> diff --git a/fs/btrfs/super.c b/fs/btrfs/super.c >> index a7acfe6..f16be9d 100644 >> --- a/fs/btrfs/super.c >> +++ b/fs/btrfs/super.c >> @@ -686,6 +686,7 @@ static const struct file_operations btrfs_ctl_fops = { >>

[Devel] Re: [RFC][PATCH 04/36] btrfs: Add checkpoint file operations

2009-05-04 Thread Serge E. Hallyn
Quoting Matt Helsley (matth...@us.ibm.com): ... > diff --git a/fs/btrfs/super.c b/fs/btrfs/super.c > index a7acfe6..f16be9d 100644 > --- a/fs/btrfs/super.c > +++ b/fs/btrfs/super.c > @@ -686,6 +686,7 @@ static const struct file_operations btrfs_ctl_fops = { > .unlocked_ioctl = btrfs_contro

[Devel] [RFC][PATCH 04/36] btrfs: Add checkpoint file operations

2009-05-04 Thread Matt Helsley
Add the checkpoint operation for btrfs files and directories. Signed-off-by: Matt Helsley Cc: linux-fsde...@vger.kernel.org --- fs/btrfs/file.c |1 + fs/btrfs/inode.c |1 + fs/btrfs/super.c |1 + 3 files changed, 3 insertions(+), 0 deletions(-) diff --git a/fs/btrfs/file.c b/fs/bt

[Devel] [RFC][PATCH 36/36] hostfs: Add checkpoint file operations

2009-05-04 Thread Matt Helsley
Add checkpoint operations for UML host filesystem files and directories. Signed-off-by: Matt Helsley Cc: Jeff Dike Cc: user-mode-linux-de...@lists.sourceforge.net --- fs/hostfs/hostfs_kern.c |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/fs/hostfs/hostfs_kern.c b/fs/

[Devel] [RFC][PATCH 29/36] minix: Add checkpoint file operations

2009-05-04 Thread Matt Helsley
Add checkpoint operation for minix filesystem files and directories. Signed-off-by: Matt Helsley --- fs/minix/dir.c |1 + fs/minix/file.c |1 + 2 files changed, 2 insertions(+), 0 deletions(-) diff --git a/fs/minix/dir.c b/fs/minix/dir.c index d4946c4..79c8759 100644 --- a/fs/minix/di

[Devel] [RFC][PATCH 18/36] openpromfs: Add checkpoint file operations

2009-05-04 Thread Matt Helsley
Add the checkpoint operation for openromfs directories. Explicitly skip the properties for now. Signed-off-by: Matt Helsley Cc: linux-fsde...@vger.kernel.org --- fs/openpromfs/inode.c |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/fs/openpromfs/inode.c b/fs/openpromf

[Devel] [RFC][PATCH 08/36] freevxfs: Add checkpoint file operations

2009-05-04 Thread Matt Helsley
Add the checkpoint operation for freevxfs directories. Signed-off-by: Matt Helsley Cc: linux-fsde...@vger.kernel.org --- fs/freevxfs/vxfs_lookup.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/fs/freevxfs/vxfs_lookup.c b/fs/freevxfs/vxfs_lookup.c index aee049c..3a0913

[Devel] [RFC][PATCH 21/36] romfs: Add checkpoint file operations

2009-05-04 Thread Matt Helsley
Add the checkpoint operation for romfs directories. Signed-off-by: Matt Helsley Cc: linux-fsde...@vger.kernel.org --- fs/romfs/mmap-nommu.c |1 + fs/romfs/super.c |1 + 2 files changed, 2 insertions(+), 0 deletions(-) diff --git a/fs/romfs/mmap-nommu.c b/fs/romfs/mmap-nommu.c inde

[Devel] [RFC][PATCH 19/36] qnx4: Add checkpoint file operations

2009-05-04 Thread Matt Helsley
Add the checkpoint operation for qnx4 files and directories. Signed-off-by: Matt Helsley Cc: linux-fsde...@vger.kernel.org --- fs/qnx4/dir.c |1 + fs/qnx4/file.c |1 + 2 files changed, 2 insertions(+), 0 deletions(-) diff --git a/fs/qnx4/dir.c b/fs/qnx4/dir.c index ea9ffef..2905691 10

[Devel] [RFC][PATCH 14/36] jffs2: Add checkpoint file operations

2009-05-04 Thread Matt Helsley
Add the checkpoint operation for jffs2 files and directories. Signed-off-by: Matt Helsley Cc: linux-fsde...@vger.kernel.org --- fs/jffs2/dir.c |1 + fs/jffs2/file.c |1 + 2 files changed, 2 insertions(+), 0 deletions(-) diff --git a/fs/jffs2/dir.c b/fs/jffs2/dir.c index 6f60cc9..c2b64

[Devel] [RFC][PATCH 22/36] squashfs: Add checkpoint file operations

2009-05-04 Thread Matt Helsley
Add the checkpoint operation for squashfs directories. Signed-off-by: Matt Helsley Cc: Phillip Lougher Cc: linux-fsde...@vger.kernel.org --- fs/squashfs/dir.c |3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/fs/squashfs/dir.c b/fs/squashfs/dir.c index 566b0ea..b0c5336

[Devel] [RFC][PATCH 30/36] omfs: Add checkpoint file operations

2009-05-04 Thread Matt Helsley
Add checkpoint operations for omfs files and directories. Signed-off-by: Matt Helsley --- fs/omfs/dir.c |1 + fs/omfs/file.c |1 + 2 files changed, 2 insertions(+), 0 deletions(-) diff --git a/fs/omfs/dir.c b/fs/omfs/dir.c index c7275cf..5ed9cb3 100644 --- a/fs/omfs/dir.c +++ b/fs/omf

[Devel] [RFC][PATCH 31/36] ufs: Add checkpoint file operations

2009-05-04 Thread Matt Helsley
Add checkpoint operations for ufs files and directories. Signed-off-by: Matt Helsley --- fs/ufs/dir.c |1 + fs/ufs/file.c |1 + 2 files changed, 2 insertions(+), 0 deletions(-) diff --git a/fs/ufs/dir.c b/fs/ufs/dir.c index dbbbc46..6842025 100644 --- a/fs/ufs/dir.c +++ b/fs/ufs/dir.c

[Devel] [RFC][PATCH 12/36] hppfs: Add checkpoint file operations

2009-05-04 Thread Matt Helsley
Add the checkpoint operation for hppfs files and directories. Signed-off-by: Matt Helsley Cc: linux-fsde...@vger.kernel.org --- fs/hppfs/hppfs.c |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/fs/hppfs/hppfs.c b/fs/hppfs/hppfs.c index a5089a6..f132fa2 100644 --- a/fs/h

[Devel] [RFC][PATCH 24/36] ubifs: Add checkpoint file operations

2009-05-04 Thread Matt Helsley
Add the checkpoint operation for ubifs files and directories. I think the debug files will also work with the generic file checkpoint helper but it needs a bit more investigation to be certain. Signed-off-by: Matt Helsley Cc: Artem Bityutskiy Cc: Adrian Hunter Cc: linux-...@lists.infradead.or

[Devel] [RFC][PATCH 32/36] ramfs: Add checkpoint file operations

2009-05-04 Thread Matt Helsley
Add checkpoint operations for ramfs files. NOTE: since simple_dir_operations are shared between multiple filesystems including ramfs, it's not currently possible to checkpoint open ramfs directories. Signed-off-by: Matt Helsley --- fs/ramfs/file-mmu.c |1 + fs/ramfs/file-nommu.c |1

[Devel] [RFC][PATCH 25/36] udf: Add checkpoint file operations

2009-05-04 Thread Matt Helsley
Add the checkpoint operation for udf filesystem files and directories. Signed-off-by: Matt Helsley Cc: Jan Kara Cc: linux-fsde...@vger.kernel.org --- fs/udf/dir.c |1 + fs/udf/file.c |1 + 2 files changed, 2 insertions(+), 0 deletions(-) diff --git a/fs/udf/dir.c b/fs/udf/dir.c inde

[Devel] [RFC][PATCH 01/36] affs: Add checkpoint file operations

2009-05-04 Thread Matt Helsley
Enable checkpoint of files and directories on affs. Signed-off-by: Matt Helsley Cc: linux-fsde...@vger.kernel.org --- fs/affs/dir.c |1 + fs/affs/file.c |1 + 2 files changed, 2 insertions(+), 0 deletions(-) diff --git a/fs/affs/dir.c b/fs/affs/dir.c index 7b36904..c5110a1 100644 --- a

[Devel] [RFC][PATCH 15/36] jfs: Add checkpoint file operations

2009-05-04 Thread Matt Helsley
Add the checkpoint operation for jfs files and directories. Signed-off-by: Matt Helsley Cc: Dave Kleikamp Cc: jfs-discuss...@lists.sourceforge.net Cc: linux-fsde...@vger.kernel.org --- fs/jfs/file.c |1 + fs/jfs/namei.c |1 + 2 files changed, 2 insertions(+), 0 deletions(-) diff --gi

[Devel] [RFC][PATCH 35/36] nilfs2: Add checkpoint file operations

2009-05-04 Thread Matt Helsley
Add the checkpoint operation to nilfs2 files and directories. Signed-off-by: Matt Helsley Cc: KONISHI Ryusuke Cc: us...@nilfs.org Cc: linux-fsde...@vger.kernel.org --- fs/nilfs2/dir.c |2 +- fs/nilfs2/file.c |1 + 2 files changed, 2 insertions(+), 1 deletions(-) diff --git a/fs/nilfs

[Devel] [RFC][PATCH 27/36] efs: Add checkpoint file operations

2009-05-04 Thread Matt Helsley
Add checkpoint operation for efs directories. Signed-off-by: Matt Helsley --- fs/efs/dir.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/fs/efs/dir.c b/fs/efs/dir.c index 49308a2..3322f56 100644 --- a/fs/efs/dir.c +++ b/fs/efs/dir.c @@ -13,6 +13,7 @@ static int efs_re

[Devel] [RFC][PATCH 16/36] nfs: Add checkpoint file operations

2009-05-04 Thread Matt Helsley
Add the checkpoint operation for regular nfs files and directories. Skip the various /proc files for now. Signed-off-by: Matt Helsley Cc: Trond Myklebust Cc: linux-...@vger.kernel.org Cc: linux-fsde...@vger.kernel.org --- fs/nfs/dir.c |1 + fs/nfs/file.c |1 + 2 files changed, 2 inse

[Devel] [RFC][PATCH 34/36] exofs: Add checkpoint file operations

2009-05-04 Thread Matt Helsley
Add the checkpoint operation to exofs files and directories. Signed-off-by: Matt Helsley Cc: Boaz Harrosh Cc: Avishay Traeger Cc: linux-fsdevel --- fs/exofs/dir.c |1 + fs/exofs/file.c |1 + 2 files changed, 2 insertions(+), 0 deletions(-) diff --git a/fs/exofs/dir.c b/fs/exofs/dir

[Devel] [RFC][PATCH 23/36] sysv: Add checkpoint file operations

2009-05-04 Thread Matt Helsley
Add the checkpoint operation for sysv filesystem files and directories. Signed-off-by: Matt Helsley Cc: Christoph Hellwig Cc: linux-fsde...@vger.kernel.org --- fs/sysv/dir.c |1 + fs/sysv/file.c |1 + 2 files changed, 2 insertions(+), 0 deletions(-) diff --git a/fs/sysv/dir.c b/fs/s

[Devel] [RFC][PATCH 03/36] bfs: Add checkpoint file operations

2009-05-04 Thread Matt Helsley
Add the checkpoint operation for bfs files and directories. Signed-off-by: Matt Helsley Cc: linux-fsde...@vger.kernel.org --- fs/bfs/dir.c |1 + fs/bfs/file.c |1 + 2 files changed, 2 insertions(+), 0 deletions(-) diff --git a/fs/bfs/dir.c b/fs/bfs/dir.c index 4dd1b62..dd34403 100644

[Devel] [RFC][PATCH 07/36] fat: Add checkpoint file operations

2009-05-04 Thread Matt Helsley
Add the checkpoint operation for fat files and directories. Signed-off-by: Matt Helsley Cc: linux-fsde...@vger.kernel.org --- fs/fat/dir.c |1 + fs/fat/file.c |1 + 2 files changed, 2 insertions(+), 0 deletions(-) diff --git a/fs/fat/dir.c b/fs/fat/dir.c index 3a7f603..3baecf8 100644

[Devel] [RFC][PATCH 02/36] befs: Add checkpoint file operations

2009-05-04 Thread Matt Helsley
Add the checkpoint operation for befs directories. Signed-off-by: Matt Helsley Cc: linux-fsde...@vger.kernel.org --- fs/befs/linuxvfs.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/fs/befs/linuxvfs.c b/fs/befs/linuxvfs.c index 76afd0d..7b4a4dc 100644 --- a/fs/befs/li

[Devel] [RFC][PATCH 20/36] reiserfs: Add checkpoint file operations

2009-05-04 Thread Matt Helsley
Add the checkpoint operation for reiserfs files and directories. Signed-off-by: Matt Helsley Cc: reiserfs-de...@vger.kernel.org Cc: linux-fsde...@vger.kernel.org --- fs/reiserfs/dir.c |1 + fs/reiserfs/file.c |1 + 2 files changed, 2 insertions(+), 0 deletions(-) diff --git a/fs/reise

[Devel] [RFC][PATCH 11/36] hpfs: Add checkpoint file operations

2009-05-04 Thread Matt Helsley
Add the checkpoint operation for hpfs files and directories. Signed-off-by: Matt Helsley Cc: linux-fsde...@vger.kernel.org --- fs/hpfs/dir.c |1 + fs/hpfs/file.c |1 + 2 files changed, 2 insertions(+), 0 deletions(-) diff --git a/fs/hpfs/dir.c b/fs/hpfs/dir.c index 6916c41..e88bde6 10

[Devel] [RFC][PATCH 17/36] ntfs: Add checkpoint file operations

2009-05-04 Thread Matt Helsley
Add the checkpoint operation for ntfs directories. Signed-off-by: Matt Helsley Cc: Anton Altaparmakov Cc: linux-ntfs-...@lists.sourceforge.net Cc: linux-fsde...@vger.kernel.org --- fs/ntfs/dir.c |1 + fs/ntfs/file.c |1 + 2 files changed, 2 insertions(+), 0 deletions(-) diff --git a/

[Devel] [RFC][PATCH 06/36] ecryptfs: Add checkpoint file operations

2009-05-04 Thread Matt Helsley
Add the checkpoint operation for ecryptfs files and directories. Signed-off-by: Matt Helsley Cc: linux-fsde...@vger.kernel.org --- fs/ecryptfs/file.c|2 ++ fs/ecryptfs/miscdev.c |1 + 2 files changed, 3 insertions(+), 0 deletions(-) diff --git a/fs/ecryptfs/file.c b/fs/ecryptfs/fil

[Devel] [RFC][PATCH 09/36] hfs: Add checkpoint file operations

2009-05-04 Thread Matt Helsley
Add the checkpoint operation for hfs files and directories. Signed-off-by: Matt Helsley Cc: linux-fsde...@vger.kernel.org --- fs/hfs/dir.c |1 + fs/hfs/inode.c |1 + 2 files changed, 2 insertions(+), 0 deletions(-) diff --git a/fs/hfs/dir.c b/fs/hfs/dir.c index 7c69b98..8d90a24 10064

[Devel] [RFC][PATCH 10/36] hfsplus: Add checkpoint file operations

2009-05-04 Thread Matt Helsley
Add the checkpoint operation for hfsplus files and directories. Signed-off-by: Matt Helsley Cc: linux-fsde...@vger.kernel.org --- fs/hfsplus/dir.c |1 + fs/hfsplus/inode.c |1 + 2 files changed, 2 insertions(+), 0 deletions(-) diff --git a/fs/hfsplus/dir.c b/fs/hfsplus/dir.c index 5f

[Devel] [RFC][PATCH 33/36] adfs: Add checkpoint file operations

2009-05-04 Thread Matt Helsley
Add the checkpoint operation for adfs files and directories. Signed-off-by: Matt Helsley Cc: linux-fsde...@vger.kernel.org --- fs/adfs/dir.c |1 + fs/adfs/file.c |1 + 2 files changed, 2 insertions(+), 0 deletions(-) diff --git a/fs/adfs/dir.c b/fs/adfs/dir.c index e867ccf..c05783a 10

[Devel] [RFC][PATCH 13/36] isofs: Add checkpoint file operations

2009-05-04 Thread Matt Helsley
Add the checkpoint operation for iso directories. Signed-off-by: Matt Helsley Cc: linux-fsde...@vger.kernel.org --- fs/isofs/dir.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/fs/isofs/dir.c b/fs/isofs/dir.c index 2f0dc5a..a9fa99e 100644 --- a/fs/isofs/dir.c +++ b/fs

[Devel] [RFC][PATCH 26/36] xfs: Add checkpoint file operations

2009-05-04 Thread Matt Helsley
Add the checkpoint operation for xfs files and directories. Signed-off-by: Matt Helsley Cc: xfs-mast...@oss.sgi.com Cc: x...@oss.sgi.com Cc: linux-fsde...@vger.kernel.org --- fs/xfs/linux-2.6/xfs_file.c |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/fs/xfs/linux-2.6/x

[Devel] [RFC][PATCH 05/36] cramfs: Add checkpoint file operations

2009-05-04 Thread Matt Helsley
Add the checkpoint operation for cramfs directories. Signed-off-by: Matt Helsley Cc: linux-fsde...@vger.kernel.org --- fs/cramfs/inode.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/fs/cramfs/inode.c b/fs/cramfs/inode.c index dd3634e..0927503 100644 --- a/fs/cramfs/i

[Devel] [RFC][PATCH 28/36] read_write.c | 1 +: Add checkpoint file operations

2009-05-04 Thread Matt Helsley
Add the checkpoint operation for generic, read-only files. At present, some/all files of the following filesystems use this generic definition: freevxfs, romfs, efs, cramfs, isofs, squashfs, befs This generic filesystem operation definition includes a seek operation and is thus restarta

[Devel] [RFC][PATCH 00/36] Add checkpoint file operations

2009-05-04 Thread Matt Helsley
Enable checkpoint of files and directories on various filesystems. These are the easy ones where we know we have seekable files which can be checkpointed via tools like rsync. For filesystems in this series the "magic" lies in appropriately remounting things like ramfs and hostfs after tools like r

[Devel] Re: [RFC v14][PATCH 00/54] Kernel based checkpoint/restart

2009-05-04 Thread Oren Laadan
Serge E. Hallyn wrote: > Quoting Oren Laadan (or...@cs.columbia.edu): >>> I see one drawback with this approach if you allow checkpoint of >>> application that is not isolated in a container. In that case, you may >>> want to select which IPC objects to dump to not dump all the IPC objects >>> li

[Devel] Re: [PATCH] utsns: extract creeate_uts_ns()

2009-05-04 Thread Serge E. Hallyn
Quoting Alexey Dobriyan (adobri...@gmail.com): > create_uts_ns() will be used by C/R to create fresh uts_ns. > > Signed-off-by: Alexey Dobriyan Acked-by: Serge Hallyn thanks, -serge > --- > kernel/utsname.c | 13 +++-- > 1 files changed, 11 insertions(+), 2 deletions(-) > > diff -

[Devel] Re: [RFC][PATCH 3/7] Add target_pid parameter to alloc_pidmap()

2009-05-04 Thread Serge E. Hallyn
Quoting suka...@linux.vnet.ibm.com (suka...@linux.vnet.ibm.com): > From: Sukadev Bhattiprolu > > > Signed-off-by: Sukadev Bhattiprolu > --- > kernel/pid.c | 28 ++-- > 1 files changed, 26 insertions(+), 2 deletions(-) > > diff --git a/kernel/pid.c b/kernel/pid.c > in

[Devel] Re: [RFC v14][PATCH 00/54] Kernel based checkpoint/restart

2009-05-04 Thread Oren Laadan
Dave, I've addressed the feedback on ckpt-v14 and pushed it to ckpt-v15. (There is no point in reposting the entire chain). Main changes are use kmalloc/kfree in ckpt_hdr_get/put() implementation (discard hbuf/hpos), move vdso patch early, fixes to s390, and added support for /dev/null, /dev/zero

[Devel] Re: [RFC][PATCH 6/7] Define do_fork_with_pids()

2009-05-04 Thread Sukadev Bhattiprolu
| > +long do_fork(unsigned long clone_flags, | > + unsigned long stack_start, | > + struct pt_regs *regs, | > + unsigned long stack_size, | > + int __user *parent_tidptr, | > + int __user *child_tidptr) | > +{ | > + return do_fork_with_pids(clone_flags, sta

[Devel] Re: [RFC][PATCH 2/7] Have alloc_pidmap() return actual error code

2009-05-04 Thread Sukadev Bhattiprolu
Matt Helsley [matth...@us.ibm.com] wrote: | > @@ -159,8 +160,10 @@ static int alloc_pidmap(struct pid_namespace *pid_ns) | > map = &pid_ns->pidmap[pid/BITS_PER_PAGE]; | > max_scan = (pid_max + BITS_PER_PAGE - 1)/BITS_PER_PAGE - !offset; | > for (i = 0; i <= max_scan; ++i) { | > -

[Devel] Re: [RFC][PATCH 1/7] Factor out code to allocate pidmap page

2009-05-04 Thread Sukadev Bhattiprolu
| OK, I'm having trouble not with your patch but the original code. This | test of map->page outside the spinlock looks like an incorrect fix to a | race. If map->page can be NULL right after we release the lock then it | can become NULL after this test just as easily. The map->page is not freed o

[Devel] Re: [RFC][PATCH 6/7] Define do_fork_with_pids()

2009-05-04 Thread Matt Helsley
On Mon, May 04, 2009 at 01:17:44AM -0700, suka...@linux.vnet.ibm.com wrote: > From: Sukadev Bhattiprolu > > do_fork_with_pids() is same as do_fork(), except that it takes an > additional, target_pids, parameter. This parameter, currently unused, > specifies the target_pids of the process in each

[Devel] Re: [RFC][PATCH 1/7] Factor out code to allocate pidmap page

2009-05-04 Thread Matt Helsley
On Mon, May 04, 2009 at 01:17:39AM -0700, suka...@linux.vnet.ibm.com wrote: > From: Sukadev Bhattiprolu > > > Signed-off-by: Sukadev Bhattiprolu > --- > kernel/pid.c | 43 --- > 1 files changed, 28 insertions(+), 15 deletions(-) > > diff --git a/kerne

[Devel] Re: [PATCH 1/2] netns 1/2: don't get/put old netns on CLONE_NEWNET

2009-05-04 Thread David Miller
From: Alexey Dobriyan Date: Mon, 4 May 2009 03:28:25 +0400 > copy_net_ns() doesn't copy anything, it creates fresh netns, so get/put of old > netns isn't needed. > > Signed-off-by: Alexey Dobriyan > Acked-by: Serge Hallyn Applied to net-next-2.6 ___

[Devel] Re: [RFC][PATCH 2/7] Have alloc_pidmap() return actual error code

2009-05-04 Thread Matt Helsley
On Mon, May 04, 2009 at 01:17:40AM -0700, suka...@linux.vnet.ibm.com wrote: > From: Sukadev Bhattiprolu > > alloc_pidmap() can fail either because all pid numbers are in use or > we can't allocate memory. With support for setting a specific pid > number, alloc_pidmap() would also fail if either t

[Devel] Re: IO Controller per cgroup request descriptors (Re: [PATCH 01/10] Documentation)

2009-05-04 Thread IKEDA, Munehiro
Nauman Rafique wrote: > On Fri, May 1, 2009 at 3:45 PM, Vivek Goyal wrote: >> On Fri, May 01, 2009 at 06:04:39PM -0400, IKEDA, Munehiro wrote: >>> Vivek Goyal wrote: >> +TODO >> + >> +- Lots of cleanups, testing, bug fixing, optimizations, benchmarking >> etc... >> +- Conv

[Devel] [RFC][PATCH 2/7] Have alloc_pidmap() return actual error code

2009-05-04 Thread sukadev
From: Sukadev Bhattiprolu alloc_pidmap() can fail either because all pid numbers are in use or we can't allocate memory. With support for setting a specific pid number, alloc_pidmap() would also fail if either the given pid number is invalid or in use. Rather than have caller assume -ENOMEM, hav

[Devel] [RFC][PATCH 7/7] Define clone_with_pids syscall

2009-05-04 Thread sukadev
From: Sukadev Bhattiprolu clone_with_pids() is same as clone(), except that it takes a 'target_pid_set' paramter which lets caller choose a specific pid number for the child process in each of the child process's pid namespace. This system call would be needed to implement Checkpoint/Restart (i.e

[Devel] [RFC][PATCH 6/7] Define do_fork_with_pids()

2009-05-04 Thread sukadev
From: Sukadev Bhattiprolu do_fork_with_pids() is same as do_fork(), except that it takes an additional, target_pids, parameter. This parameter, currently unused, specifies the target_pids of the process in each of its pid namespaces. Signed-off-by: Sukadev Bhattiprolu --- include/linux/sched.h

[Devel] [RFC][PATCH 4/7] Add target_pids parameter to alloc_pid()

2009-05-04 Thread sukadev
From: Sukadev Bhattiprolu This parameter is currently NULL, but will be used in a follow-on patch. Signed-off-by: Sukadev Bhattiprolu --- include/linux/pid.h |2 +- kernel/fork.c |3 ++- kernel/pid.c|9 +++-- 3 files changed, 10 insertions(+), 4 deletions(-) diff

[Devel] [RFC][PATCH 3/7] Add target_pid parameter to alloc_pidmap()

2009-05-04 Thread sukadev
From: Sukadev Bhattiprolu Signed-off-by: Sukadev Bhattiprolu --- kernel/pid.c | 28 ++-- 1 files changed, 26 insertions(+), 2 deletions(-) diff --git a/kernel/pid.c b/kernel/pid.c index fd72ad9..93406c6 100644 --- a/kernel/pid.c +++ b/kernel/pid.c @@ -147,12 +147,36

[Devel] [RFC][PATCH 5/7] Add target_pids parameter to copy_process()

2009-05-04 Thread sukadev
From: Sukadev Bhattiprolu The new parameter will be used in a follow-on patch when clone_with_pids() is implemented. Signed-off-by: Sukadev Bhattiprolu --- kernel/fork.c |7 --- 1 files changed, 4 insertions(+), 3 deletions(-) diff --git a/kernel/fork.c b/kernel/fork.c index d2d69d3..

[Devel] [RFC][PATCH 1/7] Factor out code to allocate pidmap page

2009-05-04 Thread sukadev
From: Sukadev Bhattiprolu Signed-off-by: Sukadev Bhattiprolu --- kernel/pid.c | 43 --- 1 files changed, 28 insertions(+), 15 deletions(-) diff --git a/kernel/pid.c b/kernel/pid.c index b2e5f78..c0aaebe 100644 --- a/kernel/pid.c +++ b/kernel/pid.c @@

[Devel] Re: [RFC v14][PATCH 00/54] Kernel based checkpoint/restart

2009-05-04 Thread Serge E. Hallyn
Quoting Oren Laadan (or...@cs.columbia.edu): > > I see one drawback with this approach if you allow checkpoint of > > application that is not isolated in a container. In that case, you may > > want to select which IPC objects to dump to not dump all the IPC objects > > living in the system. Indeed,

[Devel] Re: [PATCH 4/7] blkio-cgroup: The body of blkio-cgroup

2009-05-04 Thread Alan Cox
> few minor coding style issues reported by checkpatch.pl: checkpatch is a *guide* not some dictator of style. If it's more readable the way it is, or it's following existing style (eg with the export symbols in a group at the bottom) then checkpatch is best ignored. __

[Devel] Re: [PATCH 4/7] blkio-cgroup: The body of blkio-cgroup

2009-05-04 Thread Andrea Righi
On Tue, Apr 28, 2009 at 09:46:04PM +0900, Ryo Tsuruta wrote: > The body of bio-cgroup. > > Based on 2.6.30-rc3-git3 > Signed-off-by: Hirokazu Takahashi > Signed-off-by: Ryo Tsuruta Hi Ryo, few minor coding style issues reported by checkpatch.pl: WARNING: line over 80 characters #138: FILE: in

[Devel] Re: [PATCH] range-bw: Another I/O scheduling policy of dm-ioband supporting the predicable I/O bandwidth (range bandwidth)

2009-05-04 Thread Dong-Jae Kang
Hi, Ryo I released bug-fixed range-bw(V1) controller several minutes ago Although several WARNINGs of checkpatch are remained, but patch file was strictly checked by checkpatch.pl It was very time-consuming job :) Thank you for your advice >> >> > I used fio 1.22. The below is a script which I a

[Devel] [PATCH 2/2] the core of range-bw

2009-05-04 Thread Dong-Jae Kang
This is the core of the range-bw I/O controller From: Dong-Jae Kang or Range-BW is an I/O controller supports the process group-based range bandwidth according to the priority or importance of the group. Range bandwidth means the predicable I/O bandwidth with minimum and maximum value defined

[Devel] [PATCH 1/2] range-bw documentation

2009-05-04 Thread Dong-Jae Kang
This is the patch file for range-bw documentation From: Dong-Jae Kang or Range-BW is an I/O controller supports the process group-based range bandwidth according to the priority or importance of the group. Range bandwidth means the predicable I/O bandwidth with minimum and maximum value define

[Devel] [PATCH 0/2] range-bw : Another I/O scheduling policy of dm-ioband (v1)

2009-05-04 Thread Dong-Jae Kang
Hi, all * Overview range-bw was implemented as another I/O scheduling policy of dm-ioband to support predicable I/O bandwidth between minimum and maximum bandwidth defined by administrator. So, basic advantages and defects are same with dm-ioband. Here, minimum I/O bandwidth shoul

[Devel] Re: [RFC v14][PATCH 00/54] Kernel based checkpoint/restart

2009-05-04 Thread Oren Laadan
Matthieu Fertré wrote: > Hi, > > Louis Rilling a écrit : >> On 29/04/09 18:47 -0400, Oren Laadan wrote: >>> Hi Louis, >>> >>> Louis Rilling wrote: Hi, On 28/04/09 19:23 -0400, Oren Laadan wrote: > Here is the latest and greatest of checkpoint/restart (c/r) patchset. > The

[Devel] Re: [RFC v14][PATCH 08/54] Dump memory address space

2009-05-04 Thread Oren Laadan
Dave Hansen wrote: > On Tue, 2009-04-28 at 19:23 -0400, Oren Laadan wrote: >> +/* return (and detach) first empty page-array in the pool, if exists */ >> +static inline struct ckpt_pgarr *pgarr_from_pool(struct ckpt_ctx *ctx) >> +{ >> + struct ckpt_pgarr *pgarr; >> + >> + if (list_emp

[Devel] Re: [RFC v14][PATCH 07/54] cr: extend arch_setup_additional_pages()

2009-05-04 Thread Oren Laadan
Serge E. Hallyn wrote: > Quoting Dave Hansen (d...@linux.vnet.ibm.com): >> On Fri, 2009-05-01 at 10:42 -0500, Serge E. Hallyn wrote: >>> Quoting Dave Hansen (d...@linux.vnet.ibm.com): On Tue, 2009-04-28 at 19:23 -0400, Oren Laadan wrote: > From: Alexey Dobriyan > > Add "start" a