[Devel] Re: [PATCH 1/2] c/r: Add AF_UNIX support (v5)

2009-07-07 Thread Oren Laadan
Hi Dan, Definitely making good progress ! Dan Smith wrote: > This patch adds basic checkpoint/restart support for AF_UNIX sockets. It > has been tested with a single and multiple processes, and with data inflight > at the time of checkpoint. It supports socketpair()s, path-based, and > abstract

[Devel] Re: [RFC] IO scheduler based IO controller V6

2009-07-07 Thread Balbir Singh
* Vivek Goyal [2009-07-02 16:01:32]: > > Hi All, > > Here is the V6 of the IO controller patches generated on top of 2.6.31-rc1. > > Previous versions of the patches was posted here. > > (V1) http://lkml.org/lkml/2009/3/11/486 > (V2) http://lkml.org/lkml/2009/5/5/275 > (V3) http://lkml.org/lk

[Devel] Re: [PATCH 1/1] Memory usage limit notification addition to memcg

2009-07-07 Thread Balbir Singh
* Vladislav Buzov [2009-07-07 13:25:10]: > This patch updates the Memory Controller cgroup to add > a configurable memory usage limit notification. The feature > was presented at the April 2009 Embedded Linux Conference. > > Signed-off-by: Dan Malek > Signed-off-by: Vladislav Buzov > --- > Do

[Devel] Re: [PATCH 21/25] io-controller: Per cgroup request descriptor support

2009-07-07 Thread Gui Jianfeng
Vivek Goyal wrote: ... > } > +#ifdef CONFIG_GROUP_IOSCHED > +static ssize_t queue_group_requests_show(struct request_queue *q, char *page) > +{ > + return queue_var_show(q->nr_group_requests, (page)); > +} > + > +static ssize_t > +queue_group_requests_store(struct request_queue *q, const char

[Devel] Re: [PATCH 11/25] io-controller: Export disk time used and nr sectors dipatched through cgroups

2009-07-07 Thread Gui Jianfeng
Vivek Goyal wrote: ... > > +static int io_cgroup_disk_time_read(struct cgroup *cgroup, > + struct cftype *cftype, struct seq_file *m) > +{ > + struct io_cgroup *iocg; > + struct io_group *iog; > + struct hlist_node *n; > + > + if (!cgroup_lock_live_grou

[Devel] Re: [PATCH 2/2] c/r: Add AF_INET support (v3)

2009-07-07 Thread Dan Smith
Hi Brian, >> +struct { >> +char saddr[16]; >> +char rcv_saddr[16]; >> +char daddr[16]; >> +} inet6 __attribute__ ((aligned(8))); BH> These should be 'struct in6_addr'. Okay. BH> And just like in your IPv4 section you need a FIXME here for the BH> thin

[Devel] Re: [PATCH 2/2] c/r: Add AF_INET support (v3)

2009-07-07 Thread Brian Haley
Dan Smith wrote: > This patch adds AF_INET c/r support based on the framework established in > my AF_UNIX patch. I've tested it by checkpointing a single app with a > pair of sockets connected over loopback. > +struct ckpt_hdr_socket_inet { > + struct ckpt_hdr h; > + > + __u32 daddr; > +

[Devel] Re: [PATCH 1/1] Memory usage limit notification addition to memcg

2009-07-07 Thread KAMEZAWA Hiroyuki
A few comments. Maybe adding linux...@kvack.org in CC. list makes it easier to find this thread in the next post. On Tue, 7 Jul 2009 13:25:10 -0700 Vladislav Buzov wrote: > This patch updates the Memory Controller cgroup to add > a configurable memory usage limit notification. The feature > was

[Devel] Re: [PATCH 1/2] ppc vdso: make sure rc is defined

2009-07-07 Thread Serge E. Hallyn
Quoting Nathan Lynch (n...@pobox.com): > "Serge E. Hallyn" writes: > > Signed-off-by: Serge Hallyn > > --- > > arch/powerpc/kernel/vdso.c |4 +++- > > 1 files changed, 3 insertions(+), 1 deletions(-) > > > > diff --git a/arch/powerpc/kernel/vdso.c b/arch/powerpc/kernel/vdso.c > > index 48bef

[Devel] Re: [PATCH 1/2] ppc vdso: make sure rc is defined

2009-07-07 Thread Nathan Lynch
"Serge E. Hallyn" writes: > Signed-off-by: Serge Hallyn > --- > arch/powerpc/kernel/vdso.c |4 +++- > 1 files changed, 3 insertions(+), 1 deletions(-) > > diff --git a/arch/powerpc/kernel/vdso.c b/arch/powerpc/kernel/vdso.c > index 48beff6..679b394 100644 > --- a/arch/powerpc/kernel/vdso.c >

[Devel] [PATCH 1/2] c/r: Add AF_UNIX support (v5)

2009-07-07 Thread Dan Smith
This patch adds basic checkpoint/restart support for AF_UNIX sockets. It has been tested with a single and multiple processes, and with data inflight at the time of checkpoint. It supports socketpair()s, path-based, and abstract sockets. Changes in v5: - Change laddr and raddr buffers in socke

[Devel] [PATCH 2/2] c/r: Add AF_INET support (v3)

2009-07-07 Thread Dan Smith
This patch adds AF_INET c/r support based on the framework established in my AF_UNIX patch. I've tested it by checkpointing a single app with a pair of sockets connected over loopback. A couple points about the operation: 1. In order to properly hook up the established sockets with the matching

[Devel] [RFC] Add Checkpoint/Restart support for UNIX and INET sockets

2009-07-07 Thread Dan Smith
This patch set adds support to the Checkpoint/Restart code for UNIX and INET sockets. It supports abstract, path, and socketpair() UNIX sockets, as well as TCP and UDP INET/INET6 sockets. Testing is done using a set of multi-process test programs that have sockets of various types and states ope

[Devel] [PATCH] Add _ckpt_read_hdr_type() helper

2009-07-07 Thread Dan Smith
This helper function gives us a way to read a header object and the subsequent payload from the checkpoint stream directly into our own buffer. This is used by the net/checkpoint.c code to read skb's without a memcpy(). I'm sending this separately so that it doesn't get mixed in with the set goin

[Devel] Re: build breaks when checkpoint unimplemented by arch

2009-07-07 Thread Oren Laadan
Nathan Lynch wrote: > Oren Laadan writes: >> On Tue, 7 Jul 2009, Nathan Lynch wrote: >> >>> Oren Laadan writes: That's what I tried initially, but the problem is that sigset_t may be defined differently for userspace - see /usr/include/asm/sigset_t.h. In fact, for x86_32, it it i

[Devel] Re: build breaks when checkpoint unimplemented by arch

2009-07-07 Thread Nathan Lynch
Oren Laadan writes: > On Tue, 7 Jul 2009, Nathan Lynch wrote: > >> Oren Laadan writes: >> > That's what I tried initially, but the problem is that sigset_t may >> > be defined differently for userspace - see /usr/include/asm/sigset_t.h. >> > In fact, for x86_32, it it is different, defined as 'un

[Devel] Re: kernel summit topic - 'containers end-game'

2009-07-07 Thread Serge E. Hallyn
Quoting Oren Laadan (or...@cs.columbia.edu): > > > Serge E. Hallyn wrote: > > Quoting Oren Laadan (or...@cs.columbia.edu): > >> > >> Serge E. Hallyn wrote: > >>> Quoting Oren Laadan (or...@cs.columbia.edu): > Serge E. Hallyn wrote: > > A topic on ksummit agenda is 'containers end-game an

[Devel] Re: [PATCH] c/r: Add AF_UNIX support (v3)

2009-07-07 Thread Dan Smith
OL> I don't recall such a conclusion. Maybe this will lead you to a pointer in your IRC logs: Jun 11 13:51:53 * orenl in favor of dansmith OL> I argued that it it's kernel's job. I suppose we agree that such OL> pathnames should always be unlinked - so it isn't policy based. OL> Therefor

[Devel] Re: [PATCH] c/r: Add AF_UNIX support (v3)

2009-07-07 Thread Oren Laadan
Dan Smith wrote: > OL> Ahh.. and forgot to ask/mention: you do need to call > OL> sock_unix_unlink() before attempting bind(), for the reasons we > OL> had discussed earlier (consider same example as above, > OL> checkpoint/restart done before the unlink(), then restart will > OL> otherwise fail)

[Devel] Re: kernel summit topic - 'containers end-game'

2009-07-07 Thread Oren Laadan
Serge E. Hallyn wrote: > Quoting Oren Laadan (or...@cs.columbia.edu): >> >> Serge E. Hallyn wrote: >>> Quoting Oren Laadan (or...@cs.columbia.edu): Serge E. Hallyn wrote: > A topic on ksummit agenda is 'containers end-game and how do we > get there'. > > So for starters, look

[Devel] Re: [PATCH] c/r: Add AF_UNIX support (v3)

2009-07-07 Thread Dan Smith
OL> Ahh.. and forgot to ask/mention: you do need to call OL> sock_unix_unlink() before attempting bind(), for the reasons we OL> had discussed earlier (consider same example as above, OL> checkpoint/restart done before the unlink(), then restart will OL> otherwise fail). I thought we agreed that w

[Devel] Re: [PATCH] c/r: Add AF_UNIX support (v3)

2009-07-07 Thread Oren Laadan
Dan Smith wrote: > OL> But there are two cases: if you are CAP_NET_ADMIN you are allowed > OL> to go beyond that limit. So you need to add that test too. > > Okay, fair enough. > > OL> And in general, this helps to keep the checks - be it security, > OL> resource limits, or whatever - in one pl

[Devel] Re: [PATCH] c/r: Add AF_UNIX support (v3)

2009-07-07 Thread Dan Smith
OL> I'm ok with that. My only concern was CAP_NET_ADMIN - so the input OL> should come from network people - is it ok with them to use OL> CAP_SYS_ADMIN there "instead" ? I meant CAP_NET_ADMIN of course :) I'll merge that check in with the sysctl one and then see what they have to say about the w

[Devel] Re: [PATCH] c/r: Add AF_UNIX support (v3)

2009-07-07 Thread Oren Laadan
On Tue, 7 Jul 2009, Dan Smith wrote: > OL> But there are two cases: if you are CAP_NET_ADMIN you are allowed > OL> to go beyond that limit. So you need to add that test too. > > Okay, fair enough. > > OL> And in general, this helps to keep the checks - be it security, > OL> resource limits, or w

[Devel] Re: build breaks when checkpoint unimplemented by arch

2009-07-07 Thread Serge E. Hallyn
Quoting Oren Laadan (or...@cs.columbia.edu): > > So if that's the route we want to take, then again I can > > confirm it did compile on ppc, and compile and boot on > > s390. > > > > Sound good. Cool, so feel free to add my Signed-off-by to your patch. Nathan, this doesn't mean that I don't th

[Devel] Re: build breaks when checkpoint unimplemented by arch

2009-07-07 Thread Oren Laadan
On Tue, 7 Jul 2009, Nathan Lynch wrote: > Oren Laadan writes: > > That's what I tried initially, but the problem is that sigset_t may > > be defined differently for userspace - see /usr/include/asm/sigset_t.h. > > In fact, for x86_32, it it is different, defined as 'unsigned long' > > (and NSIG

[Devel] Re: build breaks when checkpoint unimplemented by arch

2009-07-07 Thread Oren Laadan
On Tue, 7 Jul 2009, Serge E. Hallyn wrote: > Quoting Oren Laadan (or...@cs.columbia.edu): > > On Mon, 6 Jul 2009, Nathan Lynch wrote: > > > > > Oren Laadan writes: > > > > > > > On Mon, 6 Jul 2009, Nathan Lynch wrote: > > > > > > > >> Hi Oren, > > > >> > > > >> With ckpt-v17-rc1 (as well as ck

[Devel] Re: [PATCH] c/r: Add AF_UNIX support (v3)

2009-07-07 Thread Dan Smith
OL> But there are two cases: if you are CAP_NET_ADMIN you are allowed OL> to go beyond that limit. So you need to add that test too. Okay, fair enough. OL> And in general, this helps to keep the checks - be it security, OL> resource limits, or whatever - in one place, instead of having to OL> dup

[Devel] Re: build breaks when checkpoint unimplemented by arch

2009-07-07 Thread Serge E. Hallyn
Quoting Oren Laadan (or...@cs.columbia.edu): > On Mon, 6 Jul 2009, Nathan Lynch wrote: > > > Oren Laadan writes: > > > > > On Mon, 6 Jul 2009, Nathan Lynch wrote: > > > > > >> Hi Oren, > > >> > > >> With ckpt-v17-rc1 (as well as ckpt-v16-dev) the powerpc build is broken: > > >> > > >> In file

[Devel] RE: Using 127.n.x.x/16 for namespace to host

2009-07-07 Thread Elwin Stelzer Eliazer
Thank you for the suggestion. The link local address should be good enough for now. Cheers, Elwin. -Original Message- From: Guenter Roeck [mailto:gro...@redback.com] Sent: Monday, July 06, 2009 5:29 PM To: Elwin Stelzer Eliazer Cc: contain...@lists.linux-foundation.org Subject: Re: Using

[Devel] Re: BUG in tty_open when using containers and ptrace

2009-07-07 Thread Grzegorz Nosek
On pon, lip 06, 2009 at 08:31:35 -0700, Sukadev Bhattiprolu wrote: > | To my untrained eye it looks like the cmpl corresponds to: > | > | 1841if (tty->driver->type == TTY_DRIVER_TYPE_PTY && > | 1842tty->driver->subtype == PTY_TYPE_MASTER) > | > | in drivers/char/tty_io.c > >