[Devel] Re: [RFC] cgroup basic comounting

2011-12-16 Thread Paul Menage
On Fri, Dec 16, 2011 at 4:29 AM, Glauber Costa wrote > diff --git a/kernel/cgroup.c b/kernel/cgroup.c > index 1fd7867..e894a4f 100644 > --- a/kernel/cgroup.c > +++ b/kernel/cgroup.c > @@ -1211,9 +1211,9 @@ static int parse_cgroupfs_options(char *data, struct > cgroup_sb_opts *opts) >            

[Devel] Re: [PATCH v9 1/9] Basic kernel memory functionality for the Memory Controller

2011-12-16 Thread Michal Hocko
On Fri 16-12-11 17:02:51, Glauber Costa wrote: > On 12/16/2011 04:32 PM, Michal Hocko wrote: [...] > >So why do we need kmem accounting when tcp (the only user at the moment) > >doesn't use it? > > Well, a bit historical. I needed a basic placeholder for it, since > it tcp is officially kmem. As t

[Devel] Re: [PATCH 3/6] perf: add ability to record event period

2011-12-16 Thread Andrew Vagin
Hi Arnaldo, Could you review and commit this patch. It's quite common functionality, which allow to get events more effectively and to avoid losing events. All other patches may be postponed, because Arun Sharma wants to suggest your version of "Profiling sleep times". Thanks. On 12/07/201

[Devel] Re: [PATCH v9 1/9] Basic kernel memory functionality for the Memory Controller

2011-12-16 Thread Michal Hocko
On Thu 15-12-11 16:29:18, Glauber Costa wrote: > On 12/14/2011 09:04 PM, Michal Hocko wrote: > >[Now with the current patch version, I hope] > >On Mon 12-12-11 11:47:01, Glauber Costa wrote: [...] > >>@@ -3848,10 +3862,17 @@ static inline u64 mem_cgroup_usage(struct > >>mem_cgroup *memcg, bool swa

[Devel] Re: [PATCH v6 01/10] Basic kernel memory functionality for the Memory Controller

2011-12-16 Thread Michal Hocko
On Wed 14-12-11 17:38:44, Michal Hocko wrote: > Sorry for jumping in that late but I was busy recently... And obviously an old version of the patch in my mailbox. I will comment on the v9 now. Sorry... [...] -- Michal Hocko SUSE Labs SUSE LINUX s.r.o. Lihovarska 1060/12 190 00 Praha 9 Czech R

[Devel] Re: [PATCH v6 01/10] Basic kernel memory functionality for the Memory Controller

2011-12-16 Thread Michal Hocko
Sorry for jumping in that late but I was busy recently... On Fri 25-11-11 15:38:07, Glauber Costa wrote: > This patch lays down the foundation for the kernel memory component > of the Memory Controller. > > As of today, I am only laying down the following files: > > * memory.independent_kmem_li

[Devel] Re: [PATCH v9 1/9] Basic kernel memory functionality for the Memory Controller

2011-12-16 Thread Michal Hocko
[Now with the current patch version, I hope] On Mon 12-12-11 11:47:01, Glauber Costa wrote: > This patch lays down the foundation for the kernel memory component > of the Memory Controller. > > As of today, I am only laying down the following files: > > * memory.independent_kmem_limit Maybe ha

[Devel] Re: [PATCH v9 0/9] Request for inclusion: per-cgroup tcp memory pressure controls

2011-12-16 Thread Christoph Paasch
Hi, On 12/13/2011 01:07 AM, David Miller wrote: > From: Glauber Costa > Date: Mon, 12 Dec 2011 11:47:00 +0400 > >> This series fixes all the few comments raised in the last round, >> and seem to have acquired consensus from the memcg side. >> >> Dave, do you think it is acceptable now from the n

Re: [Devel] Re: [PATCH 1/2] SYSCTL: root unregister routine introduced

2011-12-16 Thread Kinsbursky Stanislav
13.12.2011 14:04, Glauber Costa пишет: On 12/13/2011 02:03 PM, Kinsbursky Stanislav wrote: 13.12.2011 13:13, Glauber Costa пишет: On 12/13/2011 01:02 PM, Stanislav Kinsbursky wrote: 13.12.2011 02:52, Andrew Morton пишет: On Mon, 12 Dec 2011 21:50:00 +0300 Stanislav Kinsbursky wrote: This r

[Devel] [GIT PULL 0/3] perf/core fixes and improvements

2011-12-16 Thread Arnaldo Carvalho de Melo
Hi Ingo, Please consider pulling from: git://github.com/acmel/linux.git perf/core Regards, - Arnaldo Andrew Vagin (1): perf tools: Add ability to synthesize event according to a sample Robert Richter (2): perf script: Fix mem leaks and NULL pointer checks around strdup()s perf s

Re: [Devel] Re: [PATCH 1/2] SYSCTL: root unregister routine introduced

2011-12-16 Thread Kinsbursky Stanislav
13.12.2011 13:13, Glauber Costa пишет: On 12/13/2011 01:02 PM, Stanislav Kinsbursky wrote: 13.12.2011 02:52, Andrew Morton пишет: On Mon, 12 Dec 2011 21:50:00 +0300 Stanislav Kinsbursky wrote: This routine is required for SUNRPC sysctl's, which are going to be allocated, processed and destro

[Devel] Re: [PATCH 3/7] perf: add ability to change event according to sample (v2)

2011-12-16 Thread David Ahern
On 12/06/2011 07:19 AM, Arnaldo Carvalho de Melo wrote: > Em Mon, Nov 28, 2011 at 12:03:31PM +0300, Andrew Vagin escreveu: >> It's opposition of perf_session__parse_sample. >> >> v2: fixed mistakes which David Arhen found > > Ok, I'm taking this one, David, can I added an 'Acked-by: you"? Or eve

[Devel] Re: How to draw values for /proc/stat

2011-12-16 Thread KOSAKI Motohiro
IOW a /proc namespace coupled to cgroup scope would do what you want. Now my head hurts.. Mine too. The idea is good, but too broad. Boils down to: How do you couple them? And none of the methods I thought about seemed to make any sense. If we really want to have the values in /proc being opt

[Devel] Re: [PATCH 3/3] make 'none' field a flag

2011-12-16 Thread KOSAKI Motohiro
(12/11/11 9:45 AM), Glauber Costa wrote: > There is no reason to have a flags field, and then a separate > bool field just to indicate if 'none' subsystem were explicitly > requested. > > Make it a flag > > Signed-off-by: Glauber Costa Reviewed-by: KOSAKI Motohiro ___

[Devel] Re: [PATCH 2/3] make clone_children a flag

2011-12-16 Thread KOSAKI Motohiro
(12/11/11 9:45 AM), Glauber Costa wrote: > There is no reason to have a flags field, and then a separate > bool field just to indicate if the clone_children flag is set. > Make it a flag > > Signed-off-by: Glauber Costa > --- > kernel/cgroup.c |6 +++--- > 1 files changed, 3 insertions(+),

[Devel] [PATCH 3/3] perf tools: Add ability to synthesize event according to a sample

2011-12-16 Thread Arnaldo Carvalho de Melo
From: Andrew Vagin It's the counterpart of perf_session__parse_sample. v2: fixed mistakes found by David Ahern. v3: s/data/sample/ s/perf_event__change_sample/perf_event__synthesize_sample Reviewed-by: David Ahern Cc: Arun Sharma Cc: David Ahern Cc: Ingo Molnar Cc: Paul Mackerras Cc: P

[Devel] Re: [PATCH 1/3] nitpick: make simple functions inline

2011-12-16 Thread KOSAKI Motohiro
> -static int notify_on_release(const struct cgroup *cgrp) > +static inline int notify_on_release(const struct cgroup *cgrp) > { > return test_bit(CGRP_NOTIFY_ON_RELEASE,&cgrp->flags); > } > > -static int clone_children(const struct cgroup *cgrp) > +static inline int clone_children(const

[Devel] RE: [PATCH v8 1/9] Basic kernel memory functionality for the Memory Controller

2011-12-16 Thread David Laight
> How about this? > > val = !!val; > > /* > * This follows the same hierarchy restrictions than > * mem_cgroup_hierarchy_write() > */ > if (!parent || !parent->use_hierarchy) { > if (list_empty(&cgroup->children)) >

[Devel] [GIT PULL 0/2] perf/urgent fixes

2011-12-16 Thread Arnaldo Carvalho de Melo
Hi Ingo, Please consider pulling from: git://github.com/acmel/linux.git perf/urgent Regards, - Arnaldo Andrew Vagin (1): perf header: Use event_name() to get an event name Anton Blanchard (1): perf stat: Failure with "Operation not supported" tools/perf/builtin-stat.c |3 ++-

Re: [Devel] [PATCH 0/7] Profiling sleep times (v3)

2011-12-16 Thread Arun Sharma
On 12/5/11 11:15 PM, Andrey Vagin wrote: Arun Sharma said, that the second versions of patches works ok for him. (Arun is the first user of this functionality after me.) Yes - Andrey's patches (v2) have been functional for me when used via: perf record -agP -e sched:sched_switch --filter "pre

[Devel] [PATCH 2/2] perf header: Use event_name() to get an event name

2011-12-16 Thread Arnaldo Carvalho de Melo
From: Andrew Vagin perf_evsel.name may be not initialized Cc: David Ahern Cc: Paul Mackerras Cc: Peter Zijlstra Cc: Arun Sharma Cc: devel@openvz.org Link: http://lkml.kernel.org/r/1322471015-107825-2-git-send-email-ava...@openvz.org Signed-off-by: Andrew Vagin Signed-off-by: Arnaldo Carval

[Devel] Re: [PATCH 4/5] NFS: remove RPC PipeFS mount point reference from blocklayout routines

2011-12-16 Thread Peng Tao
On Wed, Nov 30, 2011 at 1:19 AM, Trond Myklebust wrote: > On Tue, 2011-11-29 at 11:42 -0500, J. Bruce Fields wrote: >> On Tue, Nov 29, 2011 at 11:40:30AM -0500, Trond Myklebust wrote: >> > I mean that I'm perfectly entitled to do >> > >> > 'modprobe -r blocklayoutdriver' >> > >> > and when I do th

[Devel] Re: Remote processing of core dump

2011-12-16 Thread Dave Anderson
- Original Message - > Hi Dave, > > could you please advise is it possible to process core dump remotely? No, not any more. Actually I did implement that capability several years ago, where you could build a remote "crashd" daemon that you could connect to in order to access dumpfiles

[Devel] RE: [PATCH 4/5] NFS: remove RPC PipeFS mount point reference from blocklayout routines

2011-12-16 Thread tao.peng
> -Original Message- > From: Stanislav Kinsbursky [mailto:skinsbur...@parallels.com] > Sent: Tuesday, November 29, 2011 8:19 PM > To: Peng, Tao > Cc: trond.mykleb...@netapp.com; linux-...@vger.kernel.org; Pavel Emelianov; > ne...@suse.de; > net...@vger.kernel.org; linux-ker...@vger.kernel.

Re: [Devel] [PATCH 0/7] Profiling sleep times (v3)

2011-12-16 Thread Arnaldo Carvalho de Melo
Em Tue, Dec 06, 2011 at 11:15:07AM +0400, Andrey Vagin escreveu: > Hello Arnaldo, > > I found, that you commit patches for perf. Could you review this part? > > Arun Sharma said, that the second versions of patches works ok for him. > (Arun is the first user of this functionality after me.) I'm

[Devel] Re: [PATCH 3/7] perf: add ability to change event according to sample (v2)

2011-12-16 Thread Arnaldo Carvalho de Melo
Em Mon, Nov 28, 2011 at 12:03:31PM +0300, Andrew Vagin escreveu: > It's opposition of perf_session__parse_sample. > > v2: fixed mistakes which David Arhen found Ok, I'm taking this one, David, can I added an 'Acked-by: you"? Or even "reviewed-by:" ? I'm just changing 'data' to 'sample', data is

[Devel] Re: [PATCH 3/7] perf: add ability to change event according to sample (v2)

2011-12-16 Thread Arnaldo Carvalho de Melo
Em Tue, Dec 06, 2011 at 12:19:42PM -0200, Arnaldo Carvalho de Melo escreveu: > Em Mon, Nov 28, 2011 at 12:03:31PM +0300, Andrew Vagin escreveu: > > It's opposition of perf_session__parse_sample. > > > > v2: fixed mistakes which David Arhen found > > Ok, I'm taking this one, David, can I added an

[Devel] Re: [PATCH 2/7] perf: add ability to record event period

2011-12-16 Thread Arnaldo Carvalho de Melo
Em Mon, Nov 28, 2011 at 12:03:30PM +0300, Andrew Vagin escreveu: > Signed-off-by: Andrew Vagin > --- > tools/perf/builtin-record.c |5 + > 1 files changed, 5 insertions(+), 0 deletions(-) This patch doesn't apply in current tip/perf/core as this logic was moved to perf_evsel/perf_evlist,

[Devel] Re: How to draw values for /proc/stat

2011-12-16 Thread Zhu Yanhai
2011/12/5 Glauber Costa : > Hi, > > Specially Peter and Paul, but all the others: > > As you can see in https://lkml.org/lkml/2011/12/4/178, and in my answer to > that, there is a question - one I've asked before but without that much of > an audience - of whether /proc files read from process livi

[Devel] Re: [PATCH] SUNRPC: create svc_xprt in proper network namespace

2011-12-16 Thread Jim Rees
Stanislav Kinsbursky wrote: This patch makes svc_xprt inherit network namespace link from it's socket. Should be "its socket." ___ Devel mailing list Devel@openvz.org https://openvz.org/mailman/listinfo/devel

[Devel] Re: [PATCH 4/5] NFS: remove RPC PipeFS mount point reference from blocklayout routines

2011-12-16 Thread Peng Tao
On Tue, Nov 29, 2011 at 9:13 PM, Stanislav Kinsbursky wrote: > 29.11.2011 16:40, tao.p...@emc.com пишет: > >>> -Original Message- >>> From: Stanislav Kinsbursky [mailto:skinsbur...@parallels.com] >>> Sent: Tuesday, November 29, 2011 8:19 PM >>> To: Peng, Tao >>> Cc: trond.mykleb...@netapp.

[Devel] Re: [PATCH 1/7] perf: use event_name() to get an event name

2011-12-16 Thread Arnaldo Carvalho de Melo
Em Mon, Nov 28, 2011 at 12:03:29PM +0300, Andrew Vagin escreveu: > perf_evsel.name may be not initialized I'm applying this one to my perf/urgent branch and will ask Ingo to merge it today. > Signed-off-by: Andrew Vagin > --- > tools/perf/util/header.c |2 +- > 1 files changed, 1 insertion

[Devel] Re: [PATCH 4/5] NFS: remove RPC PipeFS mount point reference from blocklayout routines

2011-12-16 Thread Peng Tao
On Tue, Nov 29, 2011 at 9:35 PM, Myklebust, Trond wrote: >> -Original Message- >> From: tao.p...@emc.com [mailto:tao.p...@emc.com] >> Sent: Tuesday, November 29, 2011 7:40 AM >> To: skinsbur...@parallels.com >> Cc: Myklebust, Trond; linux-...@vger.kernel.org; xe...@parallels.com; >> ne...@

[Devel] RE: [PATCH 4/5] NFS: remove RPC PipeFS mount point reference from blocklayout routines

2011-12-16 Thread tao.peng
> -Original Message- > From: linux-nfs-ow...@vger.kernel.org > [mailto:linux-nfs-ow...@vger.kernel.org] On Behalf Of Stanislav > Kinsbursky > Sent: Tuesday, November 29, 2011 6:11 PM > To: trond.mykleb...@netapp.com > Cc: linux-...@vger.kernel.org; xe...@parallels.com; ne...@suse.de; > ne

[Devel] Re: [PATCH 4/5] NFS: remove RPC PipeFS mount point reference from blocklayout routines

2011-12-16 Thread Peng Tao
On Tue, Nov 29, 2011 at 11:18 PM, Trond Myklebust wrote: > On Tue, 2011-11-29 at 23:10 +0800, Peng Tao wrote: >> On Tue, Nov 29, 2011 at 9:35 PM, Myklebust, Trond >> wrote: >> >> -Original Message- >> >> From: tao.p...@emc.com [mailto:tao.p...@emc.com] >> >> Sent: Tuesday, November 29, 20

[Devel] Re: [PATCH 3/7] perf: add ability to change event according to sample (v2)

2011-12-16 Thread Arnaldo Carvalho de Melo
Em Tue, Dec 06, 2011 at 07:57:38AM -0700, David Ahern escreveu: > Ditto on that comment. > > I did not test it, but the logic is in the inverse of parse_sample so it > should be correct. > > Arnaldo: you could use remove the 2 comment lines on the commit since > there are no logic impacts. > > R

[Devel] Re: [PATCH 7/7] event: add tracepoint for accounting block time

2011-12-16 Thread Arnaldo Carvalho de Melo
Em Mon, Nov 28, 2011 at 06:43:35AM -0800, Arjan van de Ven escreveu: > > perf_evlist is what you call perf_bundle and perf_evsel is what you call > > perf_event in powertop. > > That part of the API should be ok for wider use and is in fact exported > > in the python binding. > > I don't care abo

[Devel] Re: [PATCH 7/7] event: add tracepoint for accounting block time

2011-12-16 Thread Arnaldo Carvalho de Melo
Em Mon, Nov 28, 2011 at 06:02:27AM -0800, Arjan van de Ven escreveu: > On 11/28/2011 3:42 AM, Peter Zijlstra wrote: > > On Mon, 2011-11-28 at 12:03 +0300, Andrew Vagin wrote: > >> This tracepoint shows how long a task is sleeping in uninterruptible state. > >> E.g. > >> It may show how long and wh

[Devel] Re: [PATCH v9 1/9] Basic kernel memory functionality for the Memory Controller

2011-12-16 Thread Glauber Costa
On 12/16/2011 04:32 PM, Michal Hocko wrote: On Thu 15-12-11 16:29:18, Glauber Costa wrote: On 12/14/2011 09:04 PM, Michal Hocko wrote: [Now with the current patch version, I hope] On Mon 12-12-11 11:47:01, Glauber Costa wrote: [...] @@ -3848,10 +3862,17 @@ static inline u64 mem_cgroup_usage(s

[Devel] [RFC] cgroup basic comounting

2011-12-16 Thread Glauber Costa
Turns out that most of the infrastructure we need to put two controllers in the same hierarchy is by far already into place. All we need to do is not failing when we specify two of them. With this, we can effectively guarantee that by comounting cpu and cpuacct, we'll have the same set of tasks, t