Re: [Devel] [PATCH rh7 1/2] net/skbuff: Don't waste memory reserves

2019-04-08 Thread Andrey Ryabinin
On 4/8/19 4:24 PM, Alexey Kuznetsov wrote: > Hello! > > Does not this mean that now we have a reserve, > which nobody ever uses? > Don't think so. > I am aware this reserve can be used in theory > from mm itself. Yes, it the whole idea of reserves - to use them only for memory reclaim. > Whe

[Devel] [PATCH RHEL7 COMMIT] net/skuff: WARN if kmalloc_reserve() fails to allocate memory.

2019-04-08 Thread Konstantin Khorenko
The commit is pushed to "branch-rh7-3.10.0-957.10.1.vz7.85.x-ovz" and will appear at https://src.openvz.org/scm/ovz/vzkernel.git after rh7-3.10.0-957.10.1.vz7.85.12 --> commit e887ea717df61a5945c0770fe393cb25238f1c75 Author: Andrey Ryabinin Date: Mon Apr 8 19:20:33 2019 +0300 net/skuff

[Devel] [PATCH RHEL7 COMMIT] net/skbuff: Don't waste memory reserves

2019-04-08 Thread Konstantin Khorenko
The commit is pushed to "branch-rh7-3.10.0-957.10.1.vz7.85.x-ovz" and will appear at https://src.openvz.org/scm/ovz/vzkernel.git after rh7-3.10.0-957.10.1.vz7.85.12 --> commit a6b8d2a78d837db8e7a3d8d6c15767042afd5cb2 Author: Andrey Ryabinin Date: Mon Apr 8 19:20:32 2019 +0300 net/skbuf

[Devel] [PATCH RHEL8 COMMIT] ve/net: drop ve_net_lock()/ve_net_unlock() helpers

2019-04-08 Thread Konstantin Khorenko
The commit is pushed to "branch-rh8-4.18.0-32.vz8.1.x" and will appear at https://src.openvz.org/scm/ovz/vzkernel.git after rh8-4.18.0-32.el8 --> commit 399954743511c0f4f0bc85f82156783b351a4dfd Author: Konstantin Khorenko Date: Mon Apr 8 15:29:33 2019 +0300 ve/net: drop ve_net_lock()/v

[Devel] [PATCH RHEL8 COMMIT] ve/net: don't use RCU read lock in ve_dev_can_rename()

2019-04-08 Thread Konstantin Khorenko
The commit is pushed to "branch-rh8-4.18.0-32.vz8.1.x" and will appear at https://src.openvz.org/scm/ovz/vzkernel.git after rh8-4.18.0-32.el8 --> commit cc7a59b151eea9ca8c3da2f57e25c37d81560c51 Author: Konstantin Khorenko Date: Mon Apr 8 15:27:05 2019 +0300 ve/net: don't use RCU read l

[Devel] [PATCH RHEL8 COMMIT] venet: drop redundant RCU lock in venet_newlink()

2019-04-08 Thread Konstantin Khorenko
The commit is pushed to "branch-rh8-4.18.0-32.vz8.1.x" and will appear at https://src.openvz.org/scm/ovz/vzkernel.git after rh8-4.18.0-32.el8 --> commit dcff27bcb8cd799c667b353d623fe8808b486938 Author: Konstantin Khorenko Date: Mon Apr 8 15:23:53 2019 +0300 venet: drop redundant RCU lo

[Devel] [PATCH RHEL8 COMMIT] connector: avoid RCU read-side critical section in cn_init_ve()

2019-04-08 Thread Konstantin Khorenko
The commit is pushed to "branch-rh8-4.18.0-32.vz8.1.x" and will appear at https://src.openvz.org/scm/ovz/vzkernel.git after rh8-4.18.0-32.el8 --> commit 6afaf250252ad08f1ae2a3c670cbb2f07ed28628 Author: Konstantin Khorenko Date: Mon Apr 8 15:04:12 2019 +0300 connector: avoid RCU read-si

[Devel] [PATCH RHEL8 COMMIT] ve/net: don't use RCU read lock in ve_dev_can_rename()

2019-04-08 Thread Konstantin Khorenko
The commit is pushed to "branch-rh8-4.18.0-32.vz8.1.x" and will appear at https://src.openvz.org/scm/ovz/vzkernel.git after rh8-4.18.0-32.el8 --> commit 5b71c68a2f2b4927215f4ade4916a8d75d1eb014 Author: Konstantin Khorenko Date: Mon Apr 8 15:27:05 2019 +0300 ve/net: don't use RCU read l

[Devel] [PATCH RHEL8 COMMIT] ve/net: drop ve_net_lock()/ve_net_unlock() helpers

2019-04-08 Thread Konstantin Khorenko
The commit is pushed to "branch-rh8-4.18.0-32.vz8.1.x" and will appear at https://src.openvz.org/scm/ovz/vzkernel.git after rh8-4.18.0-32.el8 --> commit 9111a3b734be664abd28177b19f760d62eb8297d Author: Konstantin Khorenko Date: Mon Apr 8 15:29:33 2019 +0300 ve/net: drop ve_net_lock()/v

[Devel] [PATCH RHEL8 COMMIT] venet: drop redundant RCU lock in venet_newlink()

2019-04-08 Thread Konstantin Khorenko
The commit is pushed to "branch-rh8-4.18.0-32.vz8.1.x" and will appear at https://src.openvz.org/scm/ovz/vzkernel.git after rh8-4.18.0-32.el8 --> commit 479f57ebc5c6fddb521c9c81e90cbb67683b Author: Konstantin Khorenko Date: Mon Apr 8 15:23:53 2019 +0300 venet: drop redundant RCU lo

[Devel] [PATCH RHEL8 COMMIT] connector: avoid RCU read-side critical section in cn_init_ve()

2019-04-08 Thread Konstantin Khorenko
The commit is pushed to "branch-rh8-4.18.0-32.vz8.1.x" and will appear at https://src.openvz.org/scm/ovz/vzkernel.git after rh8-4.18.0-32.el8 --> commit 5bae346f86aa4b40d00394f5cdfeda9cf5204c60 Author: Konstantin Khorenko Date: Mon Apr 8 15:04:12 2019 +0300 connector: avoid RCU read-si

Re: [Devel] [PATCH rh7 1/2] net/skbuff: Don't waste memory reserves

2019-04-08 Thread Alexey Kuznetsov
Hello! Does not this mean that now we have a reserve, which nobody ever uses? I am aware this reserve can be used in theory from mm itself. When? Tracing showed the only function ever doing ALLOC_NO_WATERMARK used to be dev_alloc_pages. On Mon, Apr 8, 2019 at 3:10 PM Andrey Ryabinin wrote: > >

[Devel] [PATCH RHEL8 COMMIT] ve/tty: drop redundant assert for tty_mutex in vtty_release_init()

2019-04-08 Thread Konstantin Khorenko
The commit is pushed to "branch-rh8-4.18.0-32.vz8.1.x" and will appear at https://src.openvz.org/scm/ovz/vzkernel.git after rh8-4.18.0-32.el8 --> commit 22207eeb944505c88cc6f6812f50bca4d23597b0 Author: Konstantin Khorenko Date: Mon Apr 8 13:01:06 2019 +0300 ve/tty: drop redundant asser

[Devel] [PATCH RHEL8 COMMIT] ve/tty: drop redundant assert for tty_mutex in vtty_release_init()

2019-04-08 Thread Konstantin Khorenko
The commit is pushed to "branch-rh8-4.18.0-32.vz8.1.x" and will appear at https://src.openvz.org/scm/ovz/vzkernel.git after rh8-4.18.0-32.el8 --> commit 22207eeb944505c88cc6f6812f50bca4d23597b0 Author: Konstantin Khorenko Date: Mon Apr 8 13:01:06 2019 +0300 ve/tty: drop redundant asser

[Devel] [PATCH RHEL8 COMMIT] ve/tty: drop redundant assert for tty_mutex in vtty_release_init()

2019-04-08 Thread Konstantin Khorenko
The commit is pushed to "branch-rh8-4.18.0-32.vz8.1.x" and will appear at https://src.openvz.org/scm/ovz/vzkernel.git after rh8-4.18.0-32.el8 --> commit 22207eeb944505c88cc6f6812f50bca4d23597b0 Author: Konstantin Khorenko Date: Mon Apr 8 13:01:06 2019 +0300 ve/tty: drop redundant asser

[Devel] [PATCH rh7 1/2] net/skbuff: Don't waste memory reserves

2019-04-08 Thread Andrey Ryabinin
We were observing network performance issues due to packets being dropped by sk_filter_trim_cap() since the 'skb' was allocated from pfmemalloc reserves: /* * If the skb was allocated from pfmemalloc reserves, only * allow SOCK_MEMALLOC sockets to use it as this socket is * help

[Devel] [PATCH rh7 2/2] net/skuff: WARN if kmalloc_reserve() fails to allocate memory.

2019-04-08 Thread Andrey Ryabinin
Commit c93bdd0e03e8 ("netvm: allow skb allocation to use PFMEMALLOC reserves") removed memory allocation failure message in cases when pfmemalloc reserves are not allowed to use. Warning makes easier to observe network performance issues which might happen due to allocation failures. So remove __G