[Devel] [PATCH RHEL7 COMMIT] ploop: Use kmem_cache for iocb allocation

2020-06-01 Thread Konstantin Khorenko
The commit is pushed to "branch-rh7-3.10.0-1127.8.2.vz7.161.x-ovz" and will appear at https://src.openvz.org/scm/ovz/vzkernel.git after rh7-3.10.0-1127.8.2.vz7.161.4 --> commit 5671c342ee694f51ef6bdff9f8c00908e17f63dc Author: Kirill Tkhai Date: Mon Jun 1 19:01:23 2020 +0300 ploop: Use

[Devel] [PATCH RH7 v2] vtty: possible ERR_PTR dereferencing in vtty_open_master

2020-06-01 Thread Konstantin Khorenko
From: Vasily Averin found by swatch: drivers/tty/pty.c:1306 vtty_open_master() error: 'tty' dereferencing possible ERR_PTR() Signed-off-by: Vasily Averin Acked-by: Konstantin Khorenko v2: do set proper "ret" values on error paths --- drivers/tty/pty.c | 9 - 1 file changed, 8 insert

[Devel] [PATCH RH7] ploop: Use kmem_cache for iocb allocation

2020-06-01 Thread Kirill Tkhai
This should work better in memory pressure. Signed-off-by: Kirill Tkhai --- drivers/block/ploop/io_kaio.c |2 +- fs/aio.c |6 -- 2 files changed, 5 insertions(+), 3 deletions(-) diff --git a/drivers/block/ploop/io_kaio.c b/drivers/block/ploop/io_kaio.c index 7ca

[Devel] [PATCH RHEL7 COMMIT] vtty: fixed error path in vtty_map_alloc

2020-06-01 Thread Konstantin Khorenko
The commit is pushed to "branch-rh7-3.10.0-1127.8.2.vz7.151.x-ovz" and will appear at https://src.openvz.org/scm/ovz/vzkernel.git after rh7-3.10.0-1127.8.2.vz7.151.9 --> commit 45a6784e0d9e25ea0a01c415f099b839e2c4fdfc Author: Vasily Averin Date: Sun May 31 16:23:21 2020 +0300 vtty: fix

Re: [Devel] [PATCH RH7] vtty: possible ERR_PTR dereferencing in vtty_open_master

2020-06-01 Thread Konstantin Khorenko
On 05/31/2020 04:23 PM, Vasily Averin wrote: found by swatch: drivers/tty/pty.c:1306 vtty_open_master() error: 'tty' dereferencing possible ERR_PTR() Signed-off-by: Vasily Averin --- drivers/tty/pty.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/tty/pty.c b/drivers/tty/pty.c

[Devel] [PATCH RHEL7 COMMIT] cbt: endless loop on rollback in blk_cbt_map_copy_once

2020-06-01 Thread Konstantin Khorenko
The commit is pushed to "branch-rh7-3.10.0-1127.8.2.vz7.151.x-ovz" and will appear at https://src.openvz.org/scm/ovz/vzkernel.git after rh7-3.10.0-1127.8.2.vz7.151.9 --> commit 0097499e78476a7a7294513666458fa3b9a9a2de Author: Vasily Averin Date: Mon Jun 1 14:54:09 2020 +0300 cbt: endle

[Devel] [PATCH RHEL7 COMMIT] cbt: endless loop on rollback in ploop_pb_map_alloc()

2020-06-01 Thread Konstantin Khorenko
The commit is pushed to "branch-rh7-3.10.0-1127.8.2.vz7.151.x-ovz" and will appear at https://src.openvz.org/scm/ovz/vzkernel.git after rh7-3.10.0-1127.8.2.vz7.151.9 --> commit 280cfc5f90ca1604d12bef0cafe2f1a57cd05b2c Author: Vasily Averin Date: Mon Jun 1 14:54:08 2020 +0300 cbt: endle

[Devel] [PATCH RHEL7 COMMIT] ploop: possible NULL pointer dereference in ploop_thaw

2020-06-01 Thread Konstantin Khorenko
The commit is pushed to "branch-rh7-3.10.0-1127.8.2.vz7.151.x-ovz" and will appear at https://src.openvz.org/scm/ovz/vzkernel.git after rh7-3.10.0-1127.8.2.vz7.151.9 --> commit 5f6b64fc40675a65e3c9a3f942d499f5d7d3e277 Author: Vasily Averin Date: Mon Jun 1 13:27:21 2020 +0300 ploop: pos

[Devel] [PATCH RHEL7 COMMIT] ploop: variable dereferenced before check 'fbd' in ploop_fb_get_reloc_block

2020-06-01 Thread Konstantin Khorenko
The commit is pushed to "branch-rh7-3.10.0-1127.8.2.vz7.151.x-ovz" and will appear at https://src.openvz.org/scm/ovz/vzkernel.git after rh7-3.10.0-1127.8.2.vz7.151.9 --> commit bd62a6712a2ac2b62b49805d5a97a96469c00fa4 Author: Vasily Averin Date: Mon Jun 1 14:28:17 2020 +0300 ploop: var

Re: [Devel] [PATCH RHEL7 COMMIT] ploop: possible NULL pointer dereference in ploop_thaw

2020-06-01 Thread Konstantin Khorenko
please disregard, i have not committed it yet. On 06/01/2020 01:30 PM, Konstantin Khorenko wrote: The commit is pushed to "branch-rh7-3.10.0-1127.8.2.vz7.151.x-ovz" and will appear at https://src.openvz.org/scm/ovz/vzkernel.git after rh7-3.10.0-1127.8.2.vz7.151.9 --> commit d7b30a8486097ae9

[Devel] [PATCH RHEL7 COMMIT] ploop: possible NULL pointer dereference in ploop_thaw

2020-06-01 Thread Konstantin Khorenko
The commit is pushed to "branch-rh7-3.10.0-1127.8.2.vz7.151.x-ovz" and will appear at https://src.openvz.org/scm/ovz/vzkernel.git after rh7-3.10.0-1127.8.2.vz7.151.9 --> commit d7b30a8486097ae97dfaf04aec1a6928a6b514b3 Author: Konstantin Khorenko Date: Mon Jun 1 13:27:21 2020 +0300 ploo

[Devel] [PATCH RHEL8 COMMIT] kernfs/ve: ignore kernfs 've_perms_map' in cgroups.

2020-06-01 Thread Konstantin Khorenko
The commit is pushed to "branch-rh8-4.18.0-80.1.2.vz8.3.x-ovz" and will appear at https://src.openvz.org/scm/ovz/vzkernel.git after rh8-4.18.0-80.1.2.vz8.3.10 --> commit b1df7c325d67669da2a4b06b8a00e62967fc5f11 Author: Valeriy.Vdovin Date: Mon Jun 1 13:02:47 2020 +0300 kernfs/ve: ignor

[Devel] [PATCH rh8] test! ve/net: allow IPPROTO_ICMPV6 protocol inside a Container

2020-06-01 Thread Konstantin Khorenko
This patch allows "ping6" utility to work via ICMP socket without necessity to failback to RAW socket for ipv6. We do allow this for ipv4, let's allow ICMP socket for ipv6 as well. Note: by default ping6 will still use RAW socket because of default settings in "net.ipv4.ping_group_range", but thi

Re: [Devel] [PATCH VZ8] kernfs/ve: ignore kernfs 've_perms_map' in cgroups.

2020-06-01 Thread Andrey Ryabinin
On 6/1/20 12:15 PM, Valeriy Vdovin wrote: > From: "Valeriy.Vdovin" > > Kernfs implements file permissions logic, that relies on > (struct kernfs_node).ve_perms_map. In VZ8 cgroups have been modified > to use kernfs, but cgroups do not benefit from using ve_perms_map in > any way so it's left u

[Devel] [PATCH VZ8] kernfs/ve: ignore kernfs 've_perms_map' in cgroups.

2020-06-01 Thread Valeriy Vdovin
From: "Valeriy.Vdovin" Kernfs implements file permissions logic, that relies on (struct kernfs_node).ve_perms_map. In VZ8 cgroups have been modified to use kernfs, but cgroups do not benefit from using ve_perms_map in any way so it's left uninitialized in cgroup code. There is no clear way of imp

[Devel] [PATCH rh7 01/19] test! ms/netfilter: conntrack: don't attempt to iterate over empty table

2020-06-01 Thread Konstantin Khorenko
From: Florian Westphal Once we place all conntracks into same table iteration becomes more costly because the table contains conntracks that we are not interested in (belonging to other netns). So don't bother scanning if the current namespace has no entries. Signed-off-by: Florian Westphal Si

Re: [Devel] [PATCH RH7 3/4] ploop: possible NULL pointer dereference in ploop_thaw

2020-06-01 Thread Kirill Tkhai
On 31.05.2020 16:23, Vasily Averin wrote: > found by smatch: > drivers/block/ploop/dev.c:5334 ploop_thaw() error: > we previously assumed 'bdev' could be null (see line 5318) > > Signed-off-by: Vasily Averin Reviewed-by: Kirill Tkhai > --- > drivers/block/ploop/dev.c | 3 +++ > 1 file change

Re: [Devel] [PATCH RH7] ploop: variable dereferenced before check 'fbd' in ploop_fb_get_reloc_block

2020-06-01 Thread Kirill Tkhai
On 31.05.2020 16:23, Vasily Averin wrote: > found by smatch: > drivers/block/ploop/freeblks.c:469 ploop_fb_get_reloc_block() warn: > variable dereferenced before check 'fbd' (see line 467) > > Signed-off-by: Vasily Averin Reviewed-by: Kirill Tkhai > --- > drivers/block/ploop/freeblks.c | 3 +

Re: [Devel] [PATCH RH7 1/2] cbt: endless loop on rollback in ploop_pb_map_alloc()

2020-06-01 Thread Kirill Tkhai
On 01.06.2020 11:12, Kirill Tkhai wrote: > On 01.06.2020 11:00, Kirill Tkhai wrote: >> On 31.05.2020 08:19, Vasily Averin wrote: >>> found by smatch: >>> drivers/block/ploop/push_backup.c:96 ploop_pb_map_alloc() warn: >>> always true condition '(--i >= 0) => (0-u64max >= 0)' >>> >>> it leads to en

Re: [Devel] [PATCH RH7 1/2] cbt: endless loop on rollback in ploop_pb_map_alloc()

2020-06-01 Thread Kirill Tkhai
On 01.06.2020 11:00, Kirill Tkhai wrote: > On 31.05.2020 08:19, Vasily Averin wrote: >> found by smatch: >> drivers/block/ploop/push_backup.c:96 ploop_pb_map_alloc() warn: >> always true condition '(--i >= 0) => (0-u64max >= 0)' >> >> it leads to endless loop on rollback. >> >> https://jira.sw.ru/

[Devel] [PATCH RHEL8 COMMIT] ve/net: allow IPPROTO_ICMPV6 protocol inside a Container

2020-06-01 Thread Konstantin Khorenko
The commit is pushed to "branch-rh8-4.18.0-80.1.2.vz8.3.x-ovz" and will appear at https://src.openvz.org/scm/ovz/vzkernel.git after rh8-4.18.0-80.1.2.vz8.3.10 --> commit 6f99ca4d7397edfd1f80c2eddee54b0c2582334a Author: Konstantin Khorenko Date: Fri May 29 20:04:19 2020 +0300 ve/net: al

[Devel] [PATCH rh8] ve/net: allow IPPROTO_ICMPV6 protocol inside a Container

2020-06-01 Thread Konstantin Khorenko
This patch allows "ping6" utility to work via ICMP socket without necessity to failback to RAW socket for ipv6. We do allow this for ipv4, let's allow ICMP socket for ipv6 as well. Note: by default ping6 will still use RAW socket because of default settings in "net.ipv4.ping_group_range", but thi

Re: [Devel] [PATCH RH7 1/2] cbt: endless loop on rollback in ploop_pb_map_alloc()

2020-06-01 Thread Kirill Tkhai
On 31.05.2020 08:19, Vasily Averin wrote: > found by smatch: > drivers/block/ploop/push_backup.c:96 ploop_pb_map_alloc() warn: > always true condition '(--i >= 0) => (0-u64max >= 0)' > > it leads to endless loop on rollback. > > https://jira.sw.ru/browse/PSBM-104530 > Signed-off-by: Vasily Averi