[Devel] Re: [patch 3/3][netns] remove timewait sockets at cleanup

2007-09-27 Thread Daniel Lezcano
Eric W. Biederman wrote: Daniel Lezcano [EMAIL PROTECTED] writes: From: Daniel Lezcano [EMAIL PROTECTED] Denis Lunev spotted that if we take a reference to the network namespace with the timewait sockets, we will need to wait for their expiration to have the network namespace freed

[Devel] [patch 0/3][NETNS45][V2] remove timewait sockets at namespace exit

2007-09-27 Thread Daniel Lezcano
Denis Lunev spotted that using a reference to the network namespace with the timewait sockets will be a waste of time because they are pointless while we will remove the network stack at network namespace exit. The following patches do the following: - fix missing network namespace

[Devel] [patch 1/3][NETNS45][V2] add a reference to the netns for timewait

2007-09-27 Thread Daniel Lezcano
From: Daniel Lezcano [EMAIL PROTECTED] When a socket changes to a timewait socket, the network namespace is not copied from the original socket. Here we hold a usage reference, not the ref count on the network namespace, so the network namespace will be freed either the usage reference is not 0

[Devel] [patch 3/3][NETNS45][V2] remove timewait sockets at cleanup

2007-09-27 Thread Daniel Lezcano
From: Daniel Lezcano [EMAIL PROTECTED] Denis Lunev spotted that if we take a reference to the network namespace with the timewait sockets, we will need to wait for their expiration to have the network namespace freed. This is a waste of time, the timewait sockets are for avoiding to receive

[Devel] Re: [patch 2/3][NETNS45][V2] make timewait unhash lock free

2007-09-27 Thread Daniel Lezcano
Denis V. Lunev wrote: Sorry for a delay in answer. A was ill last three days. Some stylistic comments inside Daniel Lezcano wrote: From: Daniel Lezcano [EMAIL PROTECTED] The network namespace cleanup will remove all timewait sockets related to it because there are pointless. The problem

[Devel] Re: [patch 3/3][NETNS45][V2] remove timewait sockets at cleanup

2007-09-27 Thread Daniel Lezcano
Denis V. Lunev wrote: Daniel Lezcano wrote: From: Daniel Lezcano [EMAIL PROTECTED] Denis Lunev spotted that if we take a reference to the network namespace with the timewait sockets, we will need to wait for their expiration to have the network namespace freed. This is a waste of time

[Devel] Re: Playing with namespaces and bloat-o-meeter

2007-09-26 Thread Daniel Lezcano
Pavel Emelyanov wrote: Cedric Le Goater wrote: Cedric Le Goater wrote: Serge E. Hallyn wrote: Quoting Pavel Emelyanov ([EMAIL PROTECTED]): Hi, guys! I've noticed that compiling out all the core related to cloning and cleaning the new namespace saves us more than a Kbyte (!) from the

[Devel] [patch 2/3][netns] make timewait unhash lock free

2007-09-24 Thread Daniel Lezcano
From: Daniel Lezcano [EMAIL PROTECTED] The network namespace cleanup will remove all timewait sockets related to it because there are pointless. The problem is we need to browse the established hash table and for that we need to take the lock. For each timesocket we call inet_deschedule

[Devel] [patch 0/3][netns] fix and wipeout timewait sockets

2007-09-24 Thread Daniel Lezcano
Denis Lunev spotted that using a reference to the network namespace with the timewait sockets will be a waste of time because they are pointless while we will remove the network stack at network namespace exit. The following patches do the following: - fix missing network namespace

[Devel] [patch 3/3][netns] remove timewait sockets at cleanup

2007-09-24 Thread Daniel Lezcano
From: Daniel Lezcano [EMAIL PROTECTED] Denis Lunev spotted that if we take a reference to the network namespace with the timewait sockets, we will need to wait for their expiration to have the network namespace freed. This is a waste of time, the timewait sockets are for avoiding to receive

Re: [Devel] [PATCH 06/16] net: Add a network namespace parameter to struct sock

2007-09-21 Thread Daniel Lezcano
Eric W. Biederman wrote: Denis V. Lunev [EMAIL PROTECTED] writes: Daniel Lezcano wrote: This place is a very tricky, indeed. If we keep the namespace until timewait bucket death - we'll keep the namespace alive at least 5 _minutes_ after all process death. Yes, that's right. And for me

Re: [Devel] [PATCH 06/16] net: Add a network namespace parameter to struct sock

2007-09-20 Thread Daniel Lezcano
Denis V. Lunev wrote: Eric W. Biederman wrote: Sockets need to get a reference to their network namespace, or possibly a simple hold if someone registers on the network namespace notifier and will free the sockets when the namespace is going to be destroyed. Signed-off-by: Eric W. Biederman

[Devel] Re: [net-2.6.24][patch 2/2] Dynamically allocate the loopback device

2007-09-17 Thread Daniel Lezcano
Stephen Hemminger wrote: On Mon, 17 Sep 2007 15:45:11 +0200 [EMAIL PROTECTED] wrote: From: Daniel Lezcano [EMAIL PROTECTED] Doing this makes loopback.c a better example of how to do a simple network device, and it removes the special case single static allocation of a struct net_device

[Devel] Re: [PATCH 07/16] net: Make /proc/net per network namespace

2007-09-12 Thread Daniel Lezcano
David Miller wrote: From: [EMAIL PROTECTED] (Eric W. Biederman) Date: Sat, 08 Sep 2007 15:20:36 -0600 This patch makes /proc/net per network namespace. It modifies the global variables proc_net and proc_net_stat to be per network namespace. The proc_net file helpers are modified to take a

[Devel] Re: [net-2.6.24][NETNS][patch 1/3] fix export symbols

2007-09-12 Thread Daniel Lezcano
David Miller wrote: From: [EMAIL PROTECTED] Date: Wed, 12 Sep 2007 14:38:12 +0200 From: Daniel Lezcano [EMAIL PROTECTED] Add the appropriate EXPORT_SYMBOLS for proc_net_create, proc_net_fops_create and proc_net_remove to fix errors when compiling allmodconfig Signed-off-by: Mark Nelson

[Devel] Re: netns45

2007-09-12 Thread Daniel Lezcano
Eric W. Biederman wrote: Ok just to keep everyone in sync. I just uploaded a version of my netns tree up to kernel.org rebased on top of what David Miller has just merged. git://git.kernel.org/pub/scm/linux/kernel/git/ebiederm/linux-2.6-netns.git#netns/v2.6.23-rc5netns45 Once things have

[Devel] Re: [RFC][patch 0/1] fix allnoconfig for net-2.6.24

2007-09-12 Thread Daniel Lezcano
Eric W. Biederman wrote: [EMAIL PROTECTED] writes: The kernel compilation fails with allnoconfig with an unresolved to init_net. I tryed to figure out how to fix that. The problem is raised because the init_net variable is defined as extern in net_namespace.h while the variable is declared in

[Devel] Re: [RFC][patch 3/3] activate filtering for the bind

2007-09-10 Thread Daniel Lezcano
Serge E. Hallyn wrote: Quoting Daniel Lezcano ([EMAIL PROTECTED]): Serge E. Hallyn wrote: Quoting [EMAIL PROTECTED] ([EMAIL PROTECTED]): From: Daniel Lezcano [EMAIL PROTECTED] For the moment, I only made this patch for the RFC. It shows how simple it is to hook different socket syscalls

[Devel] Re: [RFC][patch 0/3] Network container subsystem - bind filtering

2007-09-05 Thread Daniel Lezcano
Serge E. Hallyn wrote: Quoting [EMAIL PROTECTED] ([EMAIL PROTECTED]): Paul Menage mentionned, a few weeks ago, he wanted a bind filtering for containers. Here it is :) The following patches are a proposition to bring IP isolation to a container. After looking more closely at the code I

[Devel] Re: [RFC][patch 3/3] activate filtering for the bind

2007-09-05 Thread Daniel Lezcano
Serge E. Hallyn wrote: Quoting [EMAIL PROTECTED] ([EMAIL PROTECTED]): From: Daniel Lezcano [EMAIL PROTECTED] For the moment, I only made this patch for the RFC. It shows how simple it is to hook different socket syscalls. This patch denies bind to any addresses which are not in the container

[Devel] containers - bug

2007-08-31 Thread Daniel Lezcano
Hi Paul, I was playing with the container filesystem (very nice) and I fall inside a kbug. I did the following: mkdir /dev/container mount -t container -o cpuset cpuset /dev/container cd /dev/container/ mkdir Charlie cd Charlie echo $$

Re: [Devel] [PATCH 1/1] Dynamically allocate the loopback device

2007-08-24 Thread Daniel Lezcano
Denis V. Lunev wrote: [EMAIL PROTECTED] wrote: From: Daniel Lezcano [EMAIL PROTECTED] Doing this makes loopback.c a better example of how to do a simple network device, and it removes the special case single static allocation of a struct net_device, hopefully making maintenance easier

[Devel] Re: [PATCH 0/16] Pid namespaces

2007-07-10 Thread Daniel Lezcano
Pavel Emelianov wrote: Cedric Le Goater wrote: Badari Pulavarty wrote: On Fri, 2007-07-06 at 12:01 +0400, Pavel Emelianov wrote: This is submition for inclusion of hierarchical, not kconfig configurable, zero overheaded ;) pid namespaces. Not able to boot my ppc64 machine with the patchset

[Devel] Re: L2 network namespaces + macvlan performances

2007-07-07 Thread Daniel Lezcano
Benjamin Thery wrote: Following a discussion we had at OLS concerning L2 network namespace performances and how the new macvlan driver could potentially improve them, I've ported the macvlan patchset on top of Eric's net namespace patchset on 2.6.22-rc4-mm2. A little bit of history: Some

[Devel] Network namespace ported to 2.6.21-mm2

2007-06-19 Thread Daniel Lezcano
Hi all, The network namespace patchset has been ported to 2.6.21-mm2. They are still some issues but we are on it, for this reason the patchset is named netns1-beta1. The patchset can be found here : http://lxc.sourceforge.net/patches/2.6.21/2.6.21-mm2-netns1-beta1/ Documentation can be

[Devel] Re: [PATCH 1/2] signal checkpoint: define /proc/pid/sig/

2007-06-14 Thread Daniel Lezcano
Serge E. Hallyn wrote: Quoting Carl-Daniel Hailfinger ([EMAIL PROTECTED]): On 11.06.2007 19:05, Serge E. Hallyn wrote: Quoting Cedric Le Goater ([EMAIL PROTECTED]): should we continue to use /proc ? or switch to some other mechanisms like getnetlink (taskstats) to map kernel structures. We

[Devel] Re: [patch 1/5][RFC - ipv4/udp checkpoint/restart] : add lookup for unhashed inode

2007-06-06 Thread Daniel Lezcano
for now this seems the right approach. Signed-off-by: Daniel Lezcano [EMAIL PROTECTED] Acked-by: Serge E. Hallyn [EMAIL PROTECTED] (Or whatever tag they decide over on lkml that I should be using :) thanks, -serge PS - I won't be acking other patches bc I just haven't looked

Re: [Devel] Re: [PATCH] Virtual ethernet tunnel

2007-06-06 Thread Daniel Lezcano
David Miller wrote: From: Pavel Emelianov [EMAIL PROTECTED] Date: Wed, 06 Jun 2007 19:11:38 +0400 Veth stands for Virtual ETHernet. It is a simple tunnel driver that works at the link layer and looks like a pair of ethernet devices interconnected with each other. I would suggest

[Devel] Re: [PATCH 0/13] Pid namespaces (OpenVZ view)

2007-05-25 Thread Daniel Lezcano
Pavel Emelianov wrote: Daniel Lezcano wrote: Pavel Emelianov wrote: Eric W. Biederman wrote: Pavel Emelianov [EMAIL PROTECTED] writes: That's how OpenVZ sees the pid namespaces. The main idea is that kernel keeps operating with tasks pid as it did before

[Devel] Re: [PATCH 0/13] Pid namespaces (OpenVZ view)

2007-05-24 Thread Daniel Lezcano
Pavel Emelianov wrote: Eric W. Biederman wrote: Pavel Emelianov [EMAIL PROTECTED] writes: That's how OpenVZ sees the pid namespaces. The main idea is that kernel keeps operating with tasks pid as it did before, but each task obtains one more pid for each pid type - the virtual pid.

Re: [Devel] [PATCH] Virtual ethernet device (tunnel)

2007-05-02 Thread Daniel Lezcano
Pavel Emelianov wrote: Veth stands for Virtual ETHernet. It is a simple tunnel driver that works at the link layer and looks like a pair of ethernet devices interconnected with each other. Mainly it allows to communicate between network namespaces but it can be used as is as well. Eric

[Devel] network namespace website

2007-04-06 Thread Daniel Lezcano
Hi, Eric Biederman has posted a few weeks ago a RFC-patchset concerning the network namespace. I ported it to the 2.6.20 kernel and uploaded the patchset to http://lxc.sourceforge.net/network.php For the part I had to used (TCP/UDP-IPV4 with usual ethernet device), I found the patchset pretty

[Devel] L2 network namespace benchmarking (resend with Service Demand)

2007-03-30 Thread Daniel Lezcano
Hi, as suggested Rick, I added the Service Demand results to the matrix. Cheers. Hi, I did some benchmarking on the existing L2 network namespaces. These patches are included in the lxc patchset at: http://lxc.sourceforge.net/patches/2.6.20 The lxc7 patchset series

[Devel] Re: L2 network namespace benchmarking

2007-03-28 Thread Daniel Lezcano
Eric W. Biederman wrote: Daniel Lezcano [EMAIL PROTECTED] writes: 3. General observations --- The objective to have no performances degrations, when the network namespace is off in the kernel, is reached in both solutions. When the network is used outside

[Devel] L2 network namespace benchmarking

2007-03-27 Thread Daniel Lezcano
Hi, I did some benchmarking on the existing L2 network namespaces. These patches are included in the lxc patchset at: http://lxc.sourceforge.net/patches/2.6.20 The lxc7 patchset series contains Dmitry's patchset The lxc8 patchset series contains Eric's patchset Here are the following

[Devel] Re: L2 network namespace benchmarking

2007-03-27 Thread Daniel Lezcano
Herbert Poetzl wrote: On Wed, Mar 28, 2007 at 12:16:34AM +0200, Daniel Lezcano wrote: Hi, [ cut ] 3. General observations --- The objective to have no performances degrations, when the network namespace is off in the kernel, is reached in both solutions. When

[Devel] Re: [PATCHSET] 2.6.20-lxc8

2007-03-21 Thread Daniel Lezcano
Herbert Poetzl wrote: On Tue, Mar 20, 2007 at 09:53:01PM +0100, Cedric Le Goater wrote: All, We've been gathering, porting and testing a whole bunch of patchsets related to namespaces, containers and resource management in what we call the -lxc patchset. great! [ cut ] *

[Devel] Re: [PATCHSET] 2.6.20-lxc8

2007-03-21 Thread Daniel Lezcano
Eric W. Biederman wrote: Daniel Lezcano [EMAIL PROTECTED] writes: Hi Herbert, I played with the L2 namespace patchset from Eric Biederman, I did some benchmarking with netperf: With 2 hosts, Intel EM64T bipro HT / 2,4 GHz , 4Go ram and GB network. Host A is running the netserver

[Devel] Re: [RFC PATCH 0/31] An introduction and A path for merging network namespace work

2007-03-01 Thread Daniel Lezcano
Eric W. Biederman wrote: [ cut ] Dmitry? Daniel? What do you think. Hi Eric, I agree with all the points you presented but I am still 50/50 for both approaches. The major argument in favor of the explicit parameter is that it allows to keep track of the network namespace. But the

[Devel] Re: [RFC PATCH 0/31] An introduction and A path for merging network namespace work

2007-03-01 Thread Daniel Lezcano
Eric W. Biederman wrote: [ cut ] Dmitry? Daniel? What do you think. Hi Eric, I agree with all the points you presented but I am still 50/50 for both approaches. The major argument in favor of the explicit parameter is that it allows to keep track of the network namespace. But the argument

[Devel] Re: [RFC PATCH 0/31] An introduction and A path for merging network namespace work

2007-02-28 Thread Daniel Lezcano
Hi Eric, Do you plan to propose to merge into mainline your patchset ? Shouldn't we ask netdev guys what they think about the explicit network namespace parameter into function you did versus the implicit network context using the push_net_ns/pop_net_ns function ? -- Daniel

[Devel] Re: [PATCH RFC 18/31] net: Implment network device movement between namespaces

2007-02-28 Thread Daniel Lezcano
Eric W. Biederman wrote: From: Eric W. Biederman [EMAIL PROTECTED] - unquoted This patch introduces NETIF_F_NETNS_LOCAL a flag to indicate a network device is local to a single network namespace and should never be moved. Useful for pseudo devices that we need an instance in each network

[Devel] Re: [PATCH RFC 22/31] net: Add network namespace clone support.

2007-02-28 Thread Daniel Lezcano
Eric W. Biederman wrote: From: Eric W. Biederman [EMAIL PROTECTED] - unquoted This patch allows you to create a new network namespace using sys_clone(...). Signed-off-by: Eric W. Biederman [EMAIL PROTECTED] --- include/linux/sched.h|1 + kernel/nsproxy.c | 11

<    1   2   3   4   5   6