[Devel] Re: linux-next: lockdep whinge in cgroup_rmdir

2011-02-24 Thread Nick Piggin
On Fri, Jan 14, 2011 at 3:06 PM, Li Zefan wrote: > Nick Piggin wrote: >> It looks like it is just a missing parent->child lock order annotation, but >> mainline cgroupfs code looks to be OK there. What does >> cgroup_clear_directory() look like in mmotm? > > It

[Devel] Re: linux-next: lockdep whinge in cgroup_rmdir

2011-02-24 Thread Nick Piggin
On Fri, Jan 14, 2011 at 2:34 AM, wrote: > Seen booting yesterday's linux-next, was not present in 2.6.37-rc7-mmotm1202. > > Not sure if it's an selinux or cgroup issue, so I'm throwing it at every > address I can find for either.  This is easily replicatable and happens at > every boot, so I can

[Devel] Re: [C/R v20][PATCH 20/96] c/r: make file_pos_read/write() public

2010-03-22 Thread Nick Piggin
On Mon, Mar 22, 2010 at 08:12:45PM -0400, Oren Laadan wrote: > On Mon, 22 Mar 2010, Nick Piggin wrote: > > > On Thu, Mar 18, 2010 at 08:59:45PM -0400, Oren Laadan wrote: > > > These two are used in the next patch when calling vfs_read/write() > > > > Said nex

[Devel] Re: [C/R v20][PATCH 38/96] c/r: dump open file descriptors

2010-03-22 Thread Nick Piggin
On Mon, Mar 22, 2010 at 06:22:32AM -0700, Matt Helsley wrote: > On Mon, Mar 22, 2010 at 09:30:35PM +1100, Nick Piggin wrote: > > On Thu, Mar 18, 2010 at 08:59:47PM -0400, Oren Laadan wrote: > > > + /* > > > + * if seen first time, this will add 'file' to the

[Devel] Re: [C/R v20][PATCH 37/96] c/r: introduce new 'file_operations': ->checkpoint, ->collect()

2010-03-22 Thread Nick Piggin
On Mon, Mar 22, 2010 at 03:16:35AM -0700, Matt Helsley wrote: > On Mon, Mar 22, 2010 at 05:34:28PM +1100, Nick Piggin wrote: > > On Thu, Mar 18, 2010 at 08:59:46PM -0400, Oren Laadan wrote: > > Hmm, what does generic_file_checkpoint mean? A NULL checkpoint op means > >

[Devel] Re: [C/R v20][PATCH 38/96] c/r: dump open file descriptors

2010-03-22 Thread Nick Piggin
On Thu, Mar 18, 2010 at 08:59:47PM -0400, Oren Laadan wrote: > @@ -531,6 +533,15 @@ static int init_checkpoint_ctx(struct ckpt_ctx *ctx, > pid_t pid) > return -EINVAL; /* cleanup by ckpt_ctx_free() */ > } > > + /* root vfs (FIX: WILL CHANGE with mnt-ns etc */ > + tas

[Devel] Re: [C/R v20][PATCH 37/96] c/r: introduce new 'file_operations': ->checkpoint, ->collect()

2010-03-21 Thread Nick Piggin
On Thu, Mar 18, 2010 at 08:59:46PM -0400, Oren Laadan wrote: > While we assume all normal files and directories can be checkpointed, > there are, as usual in the VFS, specialized places that will always > need an ability to override these defaults. Although we could do this > completely in the chec

[Devel] Re: [C/R v20][PATCH 20/96] c/r: make file_pos_read/write() public

2010-03-21 Thread Nick Piggin
On Thu, Mar 18, 2010 at 08:59:45PM -0400, Oren Laadan wrote: > These two are used in the next patch when calling vfs_read/write() Said next patch didn't seem to make it to fsdevel. Should it at least go to fs/internal.h? > > Signed-off-by: Oren Laadan > Acked-by: Serge E. Hallyn > --- > fs/r

[Devel] Re: How Inactive may be much greather than cached?

2007-10-18 Thread Nick Piggin
Hi, On Thursday 18 October 2007 16:24, Vasily Averin wrote: > Hi all, > > could anybody explain how "inactive" may be much greater than "cached"? > stress test (http://weather.ou.edu/~apw/projects/stress/) that writes into > removed files in cycle puts the node to the following state: > > MemTotal

[Devel] Re: How Inactive may be much greather than cached?

2007-10-18 Thread Nick Piggin
On Thursday 18 October 2007 17:14, Vasily Averin wrote: > Nick Piggin wrote: > > Hi, > > > > On Thursday 18 October 2007 16:24, Vasily Averin wrote: > >> Hi all, > >> > >> could anybody explain how "inactive" may be much greater than "

[Devel] Re: [PATCH] mark read_crX() asm code as volatile

2007-10-03 Thread Nick Piggin
On Wednesday 03 October 2007 16:18, H. Peter Anvin wrote: > Nick Piggin wrote: > >> This should work because the result gets used before reading again: > >> > >> read_cr3(a); > >> write_cr3(a | 1); > >> read_cr3(a); > >> > >>

[Devel] Re: [PATCH] mark read_crX() asm code as volatile

2007-10-02 Thread Nick Piggin
On Wednesday 03 October 2007 04:27, Chuck Ebbert wrote: > On 10/02/2007 11:28 AM, Arjan van de Ven wrote: > > On Tue, 02 Oct 2007 18:08:32 +0400 > > > > Kirill Korotaev <[EMAIL PROTECTED]> wrote: > >> Some gcc versions (I checked at least 4.1.1 from RHEL5 & 4.1.2 from > >> gentoo) can generate inco

[Devel] Re: controlling mmap()'d vs read/write() pages

2007-03-27 Thread Nick Piggin
Eric W. Biederman wrote: > Nick Piggin <[EMAIL PROTECTED]> writes: >>It can be done trivially without performing any IO or swap, yes. > > > Please give me a rough sketch of how to do so. Reading sparse files is just one I had in mind. But I'm not very creative co

[Devel] Re: controlling mmap()'d vs read/write() pages

2007-03-23 Thread Nick Piggin
Eric W. Biederman wrote: > Nick Piggin <[EMAIL PROTECTED]> writes: > > >>Eric W. Biederman wrote: >> >>>Dave Hansen <[EMAIL PROTECTED]> writes: >>> >>> >>> >>>>So, I think we have a difference of opinion. I think

[Devel] Re: controlling mmap()'d vs read/write() pages

2007-03-22 Thread Nick Piggin
Eric W. Biederman wrote: > Dave Hansen <[EMAIL PROTECTED]> writes: > > >>So, I think we have a difference of opinion. I think it's _all_ about >>memory pressure, and you think it is _not_ about accounting for memory >>pressure. :) Perhaps we mean different things, but we appear to >>disagree gr

[Devel] Re: [RFC][PATCH 4/7] RSS accounting hooks over the code

2007-03-14 Thread Nick Piggin
Kirill Korotaev wrote: >>The approaches I have seen that don't have a struct page pointer, do >>intrusive things like try to put hooks everywhere throughout the kernel >>where a userspace task can cause an allocation (and of course end up >>missing many, so they aren't secure anyway)... and basica

[Devel] Re: [RFC][PATCH 4/7] RSS accounting hooks over the code

2007-03-14 Thread Nick Piggin
Vaidyanathan Srinivasan wrote: > Accounting becomes easy if we have a container pointer in struct page. > This can form base ground for building controllers since any memory > related controller would be interested in tracking pages. However we > still want to evaluate if we can build them witho

[Devel] Re: [RFC][PATCH 4/7] RSS accounting hooks over the code

2007-03-13 Thread Nick Piggin
Balbir Singh wrote: > Nick Piggin wrote: >> And strangely, this example does not go outside the parameters of >> what you asked for AFAIKS. In the worst case of one container getting >> _all_ the shared pages, they will still remain inside their maximum >> rss limit. &g

[Devel] Re: [RFC][PATCH 4/7] RSS accounting hooks over the code

2007-03-13 Thread Nick Piggin
Eric W. Biederman wrote: > Nick Piggin <[EMAIL PROTECTED]> writes: > > >>Eric W. Biederman wrote: >> >>>First touch page ownership does not guarantee give me anything useful >>>for knowing if I can run my application or not. Because of page >&

[Devel] Re: [RFC][PATCH 4/7] RSS accounting hooks over the code

2007-03-13 Thread Nick Piggin
Eric W. Biederman wrote: > Herbert Poetzl <[EMAIL PROTECTED]> writes: > > >>On Mon, Mar 12, 2007 at 09:50:08AM -0700, Dave Hansen wrote: >> >>>On Mon, 2007-03-12 at 19:23 +0300, Kirill Korotaev wrote: >>> For these you essentially need per-container page->_mapcount counter, otherwise you

[Devel] Re: [PATCH 2/2] mm: incorrect direct io error handling (v6)

2007-03-12 Thread Nick Piggin
On Mon, Mar 12, 2007 at 12:23:00PM +0300, Dmitriy Monakhov wrote: > Nick Piggin <[EMAIL PROTECTED]> writes: > > > On Mon, Mar 12, 2007 at 11:55:30AM +0300, Dmitriy Monakhov wrote: > >> Nick Piggin <[EMAIL PROTECTED]> writes: > >> > >> > On M

[Devel] Re: [PATCH 2/2] mm: incorrect direct io error handling (v6)

2007-03-12 Thread Nick Piggin
On Mon, Mar 12, 2007 at 11:55:30AM +0300, Dmitriy Monakhov wrote: > Nick Piggin <[EMAIL PROTECTED]> writes: > > > On Mon, Mar 12, 2007 at 10:58:10AM +0300, Dmitriy Monakhov wrote: > >> @@ -2240,6 +2241,29 @@ ssize_t generic_file_aio_write(struct kiocb *iocb, &

[Devel] Re: [PATCH 1/2] mm: move common segment checks to separate helper function (v6)

2007-03-12 Thread Nick Piggin
On Mon, Mar 12, 2007 at 10:57:53AM +0300, Dmitriy Monakhov wrote: > I realy don't want to be annoying by sending this patcheset over and over > again. If anyone think this patch is realy cappy, please comment what > exectly is bad. Thank you. Doesn't seem like a bad idea. > > Changes: > - pat

[Devel] Re: [PATCH 2/2] mm: incorrect direct io error handling (v6)

2007-03-12 Thread Nick Piggin
On Mon, Mar 12, 2007 at 10:58:10AM +0300, Dmitriy Monakhov wrote: > I realy don't want to be annoying by sending this patcheset over and over > again, i just want the issue to be solved. If anyone think this solution > is realy cappy, please comment what exectly is bad. Thank you. If you don't get