[Devel] [PATCH rh7] locks: check for fl->fl_owner != filp in show_fd_locks

2016-06-20 Thread Stanislav Kinsburskiy
NFS emulates flocks via posix lock on server and fl->fl_owner is set to filp. Signed-off-by: Stanislav Kinsburskiy --- fs/locks.c |1 + 1 file changed, 1 insertion(+) diff --git a/fs/locks.c b/fs/locks.c index cb7da61..a5ab0c0 100644 --- a/fs/locks.c +++ b/fs/locks.c @@ -2503,6 +250

Re: [Devel] [TRD] NFS migration

2016-07-26 Thread Stanislav Kinsburskiy
Unlinked files are supported starting from version spfs-0.07.0-1.vz7 27.05.2016 12:09, Stanislav Kinsburskiy пишет: 1. Feature NFS mount point migration via CRIU https://jira.sw.ru/browse/PSBM-26967 2. Description CRIU now supports NFS file system migration (all versions). CRIU itself does

Re: [Devel] [TRD] NFS migration

2016-07-26 Thread Stanislav Kinsburskiy
UNIX sockets are supported starting from version spfs-0.08.0-1.vz7 27.05.2016 12:09, Stanislav Kinsburskiy пишет: 1. Feature NFS mount point migration via CRIU https://jira.sw.ru/browse/PSBM-26967 2. Description CRIU now supports NFS file system migration (all versions). CRIU itself does

[Devel] [PATCH] vz-rst: temove spfs scripts from criu restore parameters

2016-08-03 Thread Stanislav Kinsburskiy
These scripts are obsolete, and their logic is integrated to the source code starting from version 2.4.0.3. This means, that libvzctl wtih this patch applied has to depend on criu 2.4.0.3 Signed-off-by: Stanislav Kinsburskiy --- scripts/vz-rst.in |8 1 file changed, 8 deletions

[Devel] [RFC PATCH] sunrpc: do not allow process to freeze within RPC state machine

2016-08-03 Thread Stanislav Kinsburskiy
ec385c6ab4d58f33b100192a96a. 3) This patch is not aimed to fix the issue, but to show the problem root. Look like this problem moght be applicable to other hunks from the commit, mentioned above. Signed-off-by: Stanislav Kinsburskiy --- net/sunrpc/sched.c |1 - 1 file changed, 1 deletion(-) d

Re: [Devel] [RFC PATCH] sunrpc: do not allow process to freeze within RPC state machine

2016-08-04 Thread Stanislav Kinsburskiy
03.08.2016 19:36, Jeff Layton пишет: On Wed, 2016-08-03 at 20:54 +0400, Stanislav Kinsburskiy wrote: Otherwise freezer cgroup state might never become "FROZEN". Here is a deadlock scheme for 2 processes in one freezer cgroup, which is freezing: CPU 0

Re: [Devel] [RFC PATCH] sunrpc: do not allow process to freeze within RPC state machine

2016-08-04 Thread Stanislav Kinsburskiy
04.08.2016 15:16, Jeff Layton пишет: On Thu, 2016-08-04 at 12:55 +0200, Stanislav Kinsburskiy wrote: 03.08.2016 19:36, Jeff Layton пишет: On Wed, 2016-08-03 at 20:54 +0400, Stanislav Kinsburskiy wrote: Otherwise freezer cgroup state might never become "FROZEN". Here is a deadl

[Devel] [PATCH 2/2] fuse: handle only fatal signals while waiting request answer

2016-10-13 Thread Stanislav Kinsburskiy
est_wait_answer is called, will lead to request interruption, producing SIGBUS error in page fault handler (filemap_fault). https://jira.sw.ru/browse/PSBM-53581 Signed-off-by: Stanislav Kinsburskiy --- fs/fuse/dev.c | 42 -- 1 file changed, 16 in

[Devel] [PATCH 0/2] fuse: fix signals handling while processing request

2016-10-13 Thread Stanislav Kinsburskiy
This patch fixes wrong SIGBUS result in page fault handler for fuse file, when process received a signal. https://jira.sw.ru/browse/PSBM-53581 --- Stanislav Kinsburskiy (2): new helper: wait_event_killable_exclusive() fuse: handle only fatal signals while waiting request answer

[Devel] [PATCH 1/2] new helper: wait_event_killable_exclusive()

2016-10-13 Thread Stanislav Kinsburskiy
Backport of 6a0fb306738994d6f091791aeb11a5dc87ad8f4c. Signed-off-by: Stanislav Kinsburskiy --- include/linux/wait.h | 26 ++ 1 file changed, 26 insertions(+) diff --git a/include/linux/wait.h b/include/linux/wait.h index 65da9e3..8475f2d 100644 --- a/include/linux

Re: [Devel] [PATCH 0/2] fuse: fix signals handling while processing request

2016-10-14 Thread Stanislav Kinsburskiy
signals to block is present in process pending mask, and if so - set (!) TIF_SIGPENDING on the task. IOW, any pending signal remains pending after call to blocks_sigs(). And that's is the root of the issue (as it described in the patch comment). Thanks, Maxim On 10/13/2016 03:03 AM, Stanis

Re: [Devel] [PATCH 0/2] fuse: fix signals handling while processing request

2016-10-17 Thread Stanislav Kinsburskiy
16.10.2016 05:21, Maxim Patlasov пишет: Stas, On 10/14/2016 03:30 AM, Stanislav Kinsburskiy wrote: 14.10.2016 02:23, Maxim Patlasov пишет: Stas, The series look fine, so: Acked-by: Maxim Patlasov But, please, refine the description of the second patch. It must explain clearly why

Re: [Devel] [PATCH 2/2] fuse: handle only fatal signals while waiting request answer

2016-10-17 Thread Stanislav Kinsburskiy
Kostya, please, modify patch comment with the following substitution: s/ it doesn't drop pending signal flag/ it doesn't drop pending signal flag, if processes is traced/ g Thanks. 13.10.2016 12:03, Stanislav Kinsburskiy пишет: This patch is b

Re: [Devel] [PATCH 0/2] fuse: fix signals handling while processing request

2016-10-17 Thread Stanislav Kinsburskiy
> > >IOW, any signal, arrived to the process, which does page fault > handling on fuse > >file, _before_ request_wait_answer() is called, will lead to request > >interruption, producing SIGBUS error in page fault handler > (filemap_fault). > > > Thanks,

[Devel] [TRD] NFS migration - update 1

2016-10-31 Thread Stanislav Kinsburskiy
1. Feature NFS mount point migration via CRIU https://jira.sw.ru/browse/PSBM-26967 2. Description CRIU now supports NFS file system migration (all versions). CRIU itself does mount of SPFS file system (fuse based) instead of NFS and starts SPFS manager program. SPFS-manager does NFS remount an

[Devel] [PATCH vz7] modules: allow NFS modules autoload in containers

2016-12-28 Thread Stanislav Kinsburskiy
Otherwise migration can fail https://jira.sw.ru/browse/PSBM-58178 Signed-off-by: Stanislav Kinsburskiy --- kernel/kmod.c |4 1 file changed, 4 insertions(+) diff --git a/kernel/kmod.c b/kernel/kmod.c index 63748d4..5253cae 100644 --- a/kernel/kmod.c +++ b/kernel/kmod.c @@ -422,6

Re: [Devel] [PATCH vz7] modules: allow NFS modules autoload in containers

2016-12-28 Thread Stanislav Kinsburskiy
28.12.2016 14:49, Dmitry Safonov пишет: On 12/28/2016 04:37 PM, Stanislav Kinsburskiy wrote: Otherwise migration can fail https://jira.sw.ru/browse/PSBM-58178 Signed-off-by: Stanislav Kinsburskiy Just for check - these modules should be loaded on sys_mount()? In this case it should be

[Devel] [PATCH] sunrpc: handle -ENETUNREACH error on connect as fatal if VE is dying

2017-02-22 Thread Stanislav Kinsburskiy
it's dead alredy. Don't see any better solution so far (except investigation, why -ENETUNREACH is returned). So let's simply break the loop when it's called from ve_drop_context(). https://jira.sw.ru/browse/PSBM-60905 Signed-off-by: Stanislav Kinsburskiy --- net/sunrpc/xprt.c

Re: [Devel] [PATCH] sunrpc: handle -ENETUNREACH error on connect as fatal if VE is dying

2017-02-22 Thread Stanislav Kinsburskiy
22.02.2017 18:04, Dmitry Safonov пишет: On 02/22/2017 08:05 PM, Stanislav Kinsburskiy wrote: Have no idea, why kernel_connect() in xs_tcp_setup_socket() return -ENETUNREACH with this call stack: [root@uqvm098 ~]# cat /proc/14753/stack [] rpc_wait_bit_killable+0x11/0x60 [sunrpc

[Devel] [PATCH] sunrpc: fix ve is dying check on -ENETUNREACH error upon connect

2017-03-22 Thread Stanislav Kinsburskiy
This operations can be asynchonious. So, current VE is not the right one. VE from transport network has to be taken instead. Fixes commit 4ad21d242066afcb4f55000c308322c3bad98a2b https://jira.sw.ru/browse/PSBM-62616 Signed-off-by: Stanislav Kinsburskiy --- net/sunrpc/xprt.c |4 +++- 1

[Devel] [PATCH] sunrpc: print connect status value upon retry

2017-04-05 Thread Stanislav Kinsburskiy
And current VE name and VE net_ns pointer. https://jira.sw.ru/browse/PSBM-63769 Signed-off-by: Stanislav Kinsburskiy --- net/sunrpc/xprt.c |9 ++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/net/sunrpc/xprt.c b/net/sunrpc/xprt.c index 1dd1598..c28b3e3 100644 --- a

[Devel] [PATCH] venet: remove SS hook

2017-04-10 Thread Stanislav Kinsburskiy
rowse/PSBM-64015 Notes: this patch obsoletes the following commits: 455d5ba9506998f589b9929266c12627c9baf589 3e48f57a452b597b23039c3278e67788ac48f8d4 ed93afb07e58beb447556adbb25af11b9da1b62c Signed-off-by: Stanislav Kinsburskiy --- drivers/net/venetdev.c | 32 1

[Devel] [PATCH 2/6] venet: treat presence of veip object with the same VEID as error

2017-04-21 Thread Stanislav Kinsburskiy
This shouldn't happen. VEIP object is identified by veid, which is unique per VE structure. Signed-off-by: Stanislav Kinsburskiy --- drivers/net/veip_mgmt.c |2 ++ drivers/net/venetdev.c |2 +- 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/net/veip_mgm

[Devel] [PATCH 0/6] Fix VEIP object handling on container destroy

2017-04-21 Thread Stanislav Kinsburskiy
Major changes to current behaviour: 1) "SHUTDOWN" hook chain added 2) VEIP object is destroyed in "SHUTDOWN" hook 3) Now VEIP object live cycle is tightly bound to VE object. IOW, it won't be reused, but EEXIST will be returned instead. https://jira.sw.ru/browse/PS

[Devel] [PATCH 5/6] ve: add one more SHUTDOWN hooks chain

2017-04-21 Thread Stanislav Kinsburskiy
It will be used to release VEIP object. Signed-off-by: Stanislav Kinsburskiy --- include/linux/ve_proto.h |1 + kernel/ve/ve.c |2 ++ 2 files changed, 3 insertions(+) diff --git a/include/linux/ve_proto.h b/include/linux/ve_proto.h index d2dc12d..02f35e2 100644 --- a/include

[Devel] [PATCH 1/6] venet: make veip_find() helper static

2017-04-21 Thread Stanislav Kinsburskiy
This one is used only in one place. Signed-off-by: Stanislav Kinsburskiy --- drivers/net/venetdev.c |3 +-- include/linux/venet.h |1 - 2 files changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/net/venetdev.c b/drivers/net/venetdev.c index 4a7876f..a4388fd 100644 --- a

[Devel] [PATCH 6/6] venet: VEIP "SHUTDOWN" hook introduced

2017-04-21 Thread Stanislav Kinsburskiy
al net put). https://jira.sw.ru/browse/PSBM-64869 Signed-off-by: Stanislav Kinsburskiy --- drivers/net/venetdev.c | 13 - 1 file changed, 12 insertions(+), 1 deletion(-) diff --git a/drivers/net/venetdev.c b/drivers/net/venetdev.c index b7d7596..5e832d3 100644 --- a/drivers/net

[Devel] [PATCH 3/6] venet: split veip_stop() into protected and unprotected versions

2017-04-21 Thread Stanislav Kinsburskiy
Signed-off-by: Stanislav Kinsburskiy --- drivers/net/venetdev.c | 13 - 1 file changed, 8 insertions(+), 5 deletions(-) diff --git a/drivers/net/venetdev.c b/drivers/net/venetdev.c index 192ca3c..5a09575 100644 --- a/drivers/net/venetdev.c +++ b/drivers/net/venetdev.c @@ -252,13

[Devel] [PATCH 4/6] venet: veip_shutdown() helper introduced

2017-04-21 Thread Stanislav Kinsburskiy
It takes spinlock only once for both __veip_stop and __venet_ext_clean (which is converted to unprotected, because now called only from this helper). New helper is now used in venet_dellink. Signed-off-by: Stanislav Kinsburskiy --- drivers/net/venetdev.c | 22 ++ 1 file

[Devel] [PATCH] net: fix silly mistake with TCP cgroup memory pressure check

2017-05-26 Thread Stanislav Kinsburskiy
Memmory pressure is referenced as a pointer in socket structure. Simple check for pointer address will always return true for each socket, allocated with enabled mem_cg. Memory pressure value has to checked instead. https://jira.sw.ru/browse/PSBM-66468 Signed-off-by: Stanislav Kinsburskiy

[Devel] [PATCH] scripts: use absolute binaries paths nfs-ports-allow.sh

2017-06-01 Thread Stanislav Kinsburskiy
That's the way to support multiple distributions. https://jira.sw.ru/browse/PSBM-66901 Signed-off-by: Stanislav Kinsburskiy --- scripts/nfs-ports-allow.sh | 21 - 1 file changed, 12 insertions(+), 9 deletions(-) diff --git a/scripts/nfs-ports-allow.sh b/scripts/nfs-

[Devel] [PATCH] scripts: use absolute binaries paths systemd-autofs-restart.sh

2017-06-02 Thread Stanislav Kinsburskiy
That's the way to support multiple distributions, including those without $PATH variable being set. https://jira.sw.ru/browse/PSBM-66967 Signed-off-by: Stanislav Kinsburskiy --- scripts/systemd-autofs-restart.sh | 28 ++-- 1 file changed, 18 insertions(+

[Devel] [PATCH] netfilter: allow adding matches from the container initial user namespace

2017-06-05 Thread Stanislav Kinsburskiy
https://jira.sw.ru/browse/PSBM-43609 Signed-off-by: Stanislav Kinsburskiy --- net/netfilter/xt_owner.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/netfilter/xt_owner.c b/net/netfilter/xt_owner.c index 79558fe..942cce1 100644 --- a/net/netfilter/xt_owner.c +++ b

[Devel] [PATCH] netfilter: get UID and GID from container user ns on rule match

2017-06-06 Thread Stanislav Kinsburskiy
It's good enough for us. It won't work properly in case of setting rules by joining container network namespace without VE cgroup, but it's acceptable, because proper fix needs a lot of backporting. https://jira.sw.ru/browse/PSBM-43609 Signed-off-by: Stanislav Kinsburskiy ---

Re: [Devel] [PATCH] netfilter: get UID and GID from container user ns on rule match

2017-06-06 Thread Stanislav Kinsburskiy
06.06.2017 12:27, Cyrill Gorcunov пишет: On Tue, Jun 06, 2017 at 01:23:55PM +0300, Cyrill Gorcunov wrote: On Tue, Jun 06, 2017 at 02:00:32PM +0400, Stanislav Kinsburskiy wrote: It's good enough for us. It won't work properly in case of setting rules by joining container network

[Devel] [PATCH] files: remove extra newline from a message create_ghost_dentry

2017-06-08 Thread Stanislav Kinsburskiy
Signed-off-by: Stanislav Kinsburskiy --- criu/files-reg.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/criu/files-reg.c b/criu/files-reg.c index bcfe1fd..f749445 100644 --- a/criu/files-reg.c +++ b/criu/files-reg.c @@ -219,7 +219,7 @@ again

Re: [Devel] [PATCH] files: remove extra newline from a message create_ghost_dentry

2017-06-08 Thread Stanislav Kinsburskiy
08.06.2017 16:33, Dmitry Safonov пишет: On 06/08/2017 05:00 PM, Stanislav Kinsburskiy wrote: Signed-off-by: Stanislav Kinsburskiy --- criu/files-reg.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/criu/files-reg.c b/criu/files-reg.c index bcfe1fd..f749445

[Devel] [PATCH] fuse: allow to mount if process is in init_user_ns

2017-06-09 Thread Stanislav Kinsburskiy
Regardless its current VE. https://jira.sw.ru/browse/PSBM-67185 Signed-off-by: Stanislav Kinsburskiy --- fs/fuse/inode.c |3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/fs/fuse/inode.c b/fs/fuse/inode.c index 090a7ab..a8d7924 100644 --- a/fs/fuse/inode.c +++ b/fs/fuse

[Devel] [PATCH 2/2] spfs: fix usage of mi->ns_mountpoint

2017-06-09 Thread Stanislav Kinsburskiy
Previously this path had slash at the end. Now it doesn't have. Update usage then. Signed-off-by: Stanislav Kinsburskiy --- criu/files-reg.c |6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/criu/files-reg.c b/criu/files-reg.c index e812b27..2577a48 100644 --- a

[Devel] [PATCH 0/2] spfs: update to work with CRIU v3

2017-06-09 Thread Stanislav Kinsburskiy
SPFS doesn't work with CRIU v3. This patch set fixes the issue on the CRIU side. The following series implements... --- Stanislav Kinsburskiy (2): spfs: pass both "mountpoint" and "ns_mountpoint" paths to manager spfs: fix usage of mi->ns_mountpoin

[Devel] [PATCH 1/2] spfs: pass both "mountpoint" and "ns_mountpoint" paths to manager

2017-06-09 Thread Stanislav Kinsburskiy
mount to. One more difference: "root" is not required anymore. Originally, path to mount SPFS was constructed as follows: SPFS_mnt_path = CT_root + mi->ns_mountpoint Now mounts are created elsewhere and full path is defined in mi->mountpoint. Signed-off-by: Stanislav Kinsburskiy

Re: [Devel] [PATCH 0/2] spfs: update to work with CRIU v3

2017-06-09 Thread Stanislav Kinsburskiy
https://jira.sw.ru/browse/PSBM-66943 09.06.2017 15:44, Stanislav Kinsburskiy пишет: SPFS doesn't work with CRIU v3. This patch set fixes the issue on the CRIU side. The following series implements... --- Stanislav Kinsburskiy (2): spfs: pass both "mountpoint" and

Re: [Devel] Fwd: [PATCH] fuse: allow to mount if process is in init_user_ns

2017-06-13 Thread Stanislav Kinsburskiy
13.06.2017 11:53, Kirill Tkhai пишет: On 09.06.2017 16:27, Stanislav Kinsburskiy wrote: Kirill, please, review. Перенаправленное сообщение Тема: [Devel] [PATCH] fuse: allow to mount if process is in init_user_ns Дата: Fri, 9 Jun 2017 17:09:49 +0400 От: Stanislav

[Devel] [PATCH 0/2] mounts: fix check for overmounted NFS

2017-06-20 Thread Stanislav Kinsburskiy
This series fixes two issues: 1) Moves "NFS is overmounted" check to the right place 2) Apply "NFS is overmounted" check to all versions Also, it prints additional information about nested mountpoint The following series implements... --- Stanislav Kinsburskiy (2

[Devel] [PATCH 1/2] mounts: add unsupported mount helper

2017-06-20 Thread Stanislav Kinsburskiy
: Stanislav Kinsburskiy --- criu/mount.c | 35 ++- 1 file changed, 22 insertions(+), 13 deletions(-) diff --git a/criu/mount.c b/criu/mount.c index cc54e68..46ad66c 100644 --- a/criu/mount.c +++ b/criu/mount.c @@ -397,6 +397,25 @@ static bool mounts_equal(struct

[Devel] [PATCH 2/2] mount: print NFS nested mountpoint info

2017-06-20 Thread Stanislav Kinsburskiy
https://jira.sw.ru/browse/PSBM-67466 Signed-off-by: Stanislav Kinsburskiy --- criu/mount.c |5 + 1 file changed, 5 insertions(+) diff --git a/criu/mount.c b/criu/mount.c index 46ad66c..0b612a3 100644 --- a/criu/mount.c +++ b/criu/mount.c @@ -411,6 +411,11 @@ static bool

[Devel] [PATCH vz7 v2] mounts: add unsupported mount helper

2017-06-20 Thread Stanislav Kinsburskiy
: Stanislav Kinsburskiy --- criu/mount.c | 27 ++- 1 file changed, 22 insertions(+), 5 deletions(-) diff --git a/criu/mount.c b/criu/mount.c index 942515e..46ad66c 100644 --- a/criu/mount.c +++ b/criu/mount.c @@ -397,6 +397,25 @@ static bool mounts_equal(struct mount_info

Re: [Devel] [PATCH 1/2] mounts: add unsupported mount helper

2017-06-20 Thread Stanislav Kinsburskiy
Thanks, Kirill! I'm sorry, but this series is wrong. I'll send another one soon. 20.06.2017 17:46, Kirill Tkhai пишет: One minor nit below On Tue, Jun 20, 2017 at 18:28, Stanislav Kinsburskiy wrote: Call it on mount points tree building and abort in case NFS is overmounted.

Re: [Devel] [PATCH 0/2] mounts: fix check for overmounted NFS

2017-06-20 Thread Stanislav Kinsburskiy
Please, ignore this series 20.06.2017 17:28, Stanislav Kinsburskiy пишет: This series fixes two issues: 1) Moves "NFS is overmounted" check to the right place 2) Apply "NFS is overmounted" check to all versions Also, it prints additional information about nested mount

[Devel] [PATCH vz7 v2 2/2] mounts: print NFS nested mountpoint info

2017-06-20 Thread Stanislav Kinsburskiy
https://jira.sw.ru/browse/PSBM-67466 Signed-off-by: Stanislav Kinsburskiy --- criu/mount.c |7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/criu/mount.c b/criu/mount.c index 667b279..edbd140 100644 --- a/criu/mount.c +++ b/criu/mount.c @@ -751,8 +751,13 @@ static

[Devel] [PATCH vz7 v2 0/2] mounts: fix check for overmounted NFS

2017-06-20 Thread Stanislav Kinsburskiy
This series fixes "NFS is overmounted" check to be appied for all NFS versions. Also, it prints additional information about nested mountpoint The following series implements... --- Stanislav Kinsburskiy (2): mounts: add unsupported mount helper mounts: print NFS nested

[Devel] [PATCH vz7 v2 1/2] mounts: add unsupported mount helper

2017-06-20 Thread Stanislav Kinsburskiy
Call it on mount points validation and abort in case NFS is overmounted. This patch also adds nfs_mount helper, which fixes the issue with skipping this check for NFSv4 mount point. Signed-off-by: Stanislav Kinsburskiy --- criu/mount.c | 23 --- 1 file changed, 20

[Devel] [PATCH 1/2] ve: add boolean "sunrpc_abort" attribute to VE cgroup

2017-06-23 Thread Stanislav Kinsburskiy
Intended to be used to abort all SUNRPC operations. For example in case of fast stop with unreachable network. Signed-off-by: Stanislav Kinsburskiy --- include/linux/ve.h |3 +++ kernel/ve/ve.c | 15 ++- 2 files changed, 17 insertions(+), 1 deletion(-) diff --git a

[Devel] [PATCH 2/2] sunrpc: bring back SUNRPC task abort logic

2017-06-23 Thread Stanislav Kinsburskiy
his solution allows us to mimic hardware behaviour closely. IOW, on normal stop (or migration) SUNRPC operates normally. But when user wants to stop it fast (i.e. he doesn't care about data, etc), then he can use "--fast" option and this patch comes into play. https://jira.sw.ru/

[Devel] [PATCH 0/2] Handle SUNRPC tasks on container stop when network is

2017-06-23 Thread Stanislav Kinsburskiy
unreachable https://jira.sw.ru/browse/PSBM-66510 --- Stanislav Kinsburskiy (2): ve: add boolean "sunrpc_abort" attribute to VE cgroup sunrpc: bring back SUNRPC task abort logic include/linux/ve.h |3 +++ kernel/ve/ve.c | 15 ++- net/sunrpc/sche

[Devel] [PATCH libvzctl] Suppress SUNRPC traffic on "fast stop".

2017-06-23 Thread Stanislav Kinsburskiy
This is needed to break infinite loop in SUNRPC state machine, leading to unstoppable container in case of unreachable network. https://jira.sw.ru/browse/PSBM-67544 Note: needs kernel rh7-3.10.0-514.16.1.vz7.32.12 or newer Signed-off-by: Stanislav Kinsburskiy --- lib/env_nsops.c | 16

[Devel] [PATCH 1/2] scripts: check service mountpoint is not empty in systemd-autofs-restart.sh

2017-06-23 Thread Stanislav Kinsburskiy
Systemctl may fail. Let's check its result and mountpoint string after call. https://jira.sw.ru/browse/PSBM-67544 Signed-off-by: Stanislav Kinsburskiy --- scripts/systemd-autofs-restart.sh | 10 ++ 1 file changed, 10 insertions(+) diff --git a/scripts/systemd-autofs-restart.

[Devel] [PATCH 2/2] scripts: cleanup error output in systemd-autofs-restart.sh

2017-06-23 Thread Stanislav Kinsburskiy
Signed-off-by: Stanislav Kinsburskiy --- scripts/systemd-autofs-restart.sh | 11 --- 1 file changed, 4 insertions(+), 7 deletions(-) diff --git a/scripts/systemd-autofs-restart.sh b/scripts/systemd-autofs-restart.sh index d39e0cd..72d2ef7 100755 --- a/scripts/systemd-autofs

[Devel] [PATCH 0/2] systemd-autofs-restart.sh: check systemctl results more

2017-06-23 Thread Stanislav Kinsburskiy
carefully https://jira.sw.ru/browse/PSBM-67544 The following series implements... --- Stanislav Kinsburskiy (2): scripts: check service mountpoint is not empty in systemd-autofs-restart.sh scripts: cleanup error output in systemd-autofs-restart.sh scripts/systemd-autofs

Re: [Devel] [PATCH 0/2] systemd-autofs-restart.sh: check systemctl results more

2017-06-24 Thread Stanislav Kinsburskiy
Indeed. Sorry about this. My bad. 23.06.2017 22:10, Dmitry Safonov пишет: On 06/23/2017 06:38 PM, Stanislav Kinsburskiy wrote: carefully https://jira.sw.ru/browse/PSBM-67544 The following series implements... --- Stanislav Kinsburskiy (2): scripts: check service mountpoint is not

Re: [Devel] [PATCH libvzctl] Suppress SUNRPC traffic on "fast stop".

2017-06-26 Thread Stanislav Kinsburskiy
Please, drop this patch. I'll sent next version. 23.06.2017 15:42, Stanislav Kinsburskiy пишет: This is needed to break infinite loop in SUNRPC state machine, leading to unstoppable container in case of unreachable network. https://jira.sw.ru/browse/PSBM-67544 Note: needs kernel rh7-3

[Devel] [PATCH v2 2/3] sunrpc: bring back SUNRPC task abort logic

2017-06-26 Thread Stanislav Kinsburskiy
quot;. This solution allows us to mimic hardware behaviour closely. IOW, on normal stop (or migration) SUNRPC operates normally. But when user wants to stop it fast (i.e. he doesn't care about data, etc), then he can use "--fast" option and this patch comes into play. https://jira.sw.ru/

[Devel] [PATCH v2 3/3] sunrpc: pending tasks kill helper added

2017-06-26 Thread Stanislav Kinsburskiy
This patch aborts SUNRPC tasks upon raise of per-net "kill_tasks" toggle. This is needed to abort pernding tasks, which are waiting for timeout. Signed-off-by: Stanislav Kinsburskiy --- net/sunrpc/clnt.c | 18 ++ 1 file changed, 18 insertions(+) diff --git a/net/sun

[Devel] [PATCH v2 1/3] sunrpc: add "kill-tasks" proc entry

2017-06-26 Thread Stanislav Kinsburskiy
Boolean per-net SUNPRC proc entry. Will be used to abort SUNRPC traffic when necessary. Signed-off-by: Stanislav Kinsburskiy --- include/linux/sunrpc/clnt.h |4 ++ net/sunrpc/clnt.c | 71 +++ net/sunrpc/netns.h |3 ++ net

[Devel] [PATCH v2 0/3] Kill SUNRPC tasks on container fast stop

2017-06-26 Thread Stanislav Kinsburskiy
https://jira.sw.ru/browse/PSBM-66510 --- Stanislav Kinsburskiy (3): sunrpc: add "kill-tasks" proc entry sunrpc: bring back SUNRPC task abort logic sunrpc: pending tasks kill helper added include/linux/sunrpc/clnt.h |6 +++ net/sunrpc/clnt.c

[Devel] [PATCH libvzctl v2] Suppress SUNRPC traffic on "fast stop".

2017-06-26 Thread Stanislav Kinsburskiy
it process is used rather than VE cgroup handle. Signed-off-by: Stanislav Kinsburskiy --- lib/env_nsops.c | 52 1 file changed, 48 insertions(+), 4 deletions(-) diff --git a/lib/env_nsops.c b/lib/env_nsops.c index d62dff4..74d6402 100644

[Devel] [PATCH] files-reg: forbid migration of opened device files on NFS

2017-06-27 Thread Stanislav Kinsburskiy
NFS is replaced by FUSE-based SPFS on restore. And SPFS is mounted via libfuse, which uses "MS_NODEV" mount option. Thus it's impossible to open a device file on SPFS. This patch forbids dumping to prevent restore failure. https://jira.sw.ru/browse/PSBM-55590 Signed-off-by: Stanis

[Devel] [PATCH] mount: check for mount is unsupported only on dump

2017-06-28 Thread Stanislav Kinsburskiy
All the mounts on restore stage have to be supported. Signed-off-by: Stanislav Kinsburskiy --- criu/mount.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/criu/mount.c b/criu/mount.c index edbd140..6916974 100644 --- a/criu/mount.c +++ b/criu/mount.c @@ -834,7 +834,7

Re: [Devel] [PATCH] mount: check for mount is unsupported only on dump

2017-06-28 Thread Stanislav Kinsburskiy
Sure! Thanks a lot for the hint! 28 июня 2017 г. 6:47 PM пользователь Kirill Tkhai написал: On Wed, Jun 28, 2017 at 15:01, Stanislav Kinsburskiy wrote: > All the mounts on restore stage have to be supported. > > Signed-off-by: Stanislav Kinsburskiy > --- > criu/mount.c |

[Devel] [PATCH] mounts: support only shared NFS mounts in inits mount namespace

2017-06-29 Thread Stanislav Kinsburskiy
er so far and migration attempt can lead to different issues after restore is completed by CRIU. https://jira.sw.ru/browse/PSBM-66945 Signed-off-by: Stanislav Kinsburskiy --- criu/mount.c | 67 +- 1 file changed, 66 insertions(+), 1 del

[Devel] [PATCH] nfsd: return file system superblock time granulaty on FSINFO request

2017-06-30 Thread Stanislav Kinsburskiy
ve bottleneck when many processes are concurrently trying to lock large file like SQL database. Ported from rhel6. https://jira.sw.ru/browse/PSBM-66572 Signed-off-by: Stanislav Kinsburskiy --- fs/nfsd/nfs3proc.c |3 +++ fs/nfsd/nfs3xdr.c |9 +++-- fs/nfsd/xdr3.h |1 + 3 f

[Devel] [PATCH 0/2] A couple of print fixes

2017-07-03 Thread Stanislav Kinsburskiy
The following series implements... --- Stanislav Kinsburskiy (2): netlink: fix warning print sk-queue: fix non-fatal print log level criu/sk-netlink.c |2 +- criu/sk-queue.c |6 +++--- 2 files changed, 4 insertions(+), 4 deletions

[Devel] [PATCH 2/2] sk-queue: fix non-fatal print log level

2017-07-03 Thread Stanislav Kinsburskiy
Signed-off-by: Stanislav Kinsburskiy --- criu/sk-queue.c |6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/criu/sk-queue.c b/criu/sk-queue.c index 8ab53f6..5e2601c 100644 --- a/criu/sk-queue.c +++ b/criu/sk-queue.c @@ -230,9 +230,9 @@ static int dump_sk_creds(struct

[Devel] [PATCH 1/2] netlink: fix warning print

2017-07-03 Thread Stanislav Kinsburskiy
Signed-off-by: Stanislav Kinsburskiy --- criu/sk-netlink.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/criu/sk-netlink.c b/criu/sk-netlink.c index 9933e10..a1b09e6 100644 --- a/criu/sk-netlink.c +++ b/criu/sk-netlink.c @@ -134,7 +134,7 @@ static int dump_nl_opts(int sk

Re: [Devel] [PATCH libvzctl v2] Suppress SUNRPC traffic on "fast stop".

2017-07-04 Thread Stanislav Kinsburskiy
Igor, could you please review? 26.06.2017 17:04, Stanislav Kinsburskiy пишет: This is needed to break infinite loop in SUNRPC state machine, leading to unstoppable container in case of unreachable network. https://jira.sw.ru/browse/PSBM-67544 Note: needs kernel rh7-3.10.0-514.16.1.vz7.32.12

[Devel] [PATCH] prctl: reduce requirements to exe link change

2017-07-04 Thread Stanislav Kinsburskiy
igned-off-by: Stanislav Kinsburskiy --- kernel/sys.c |6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/kernel/sys.c b/kernel/sys.c index 9a681ae..f8f1dd9 100644 --- a/kernel/sys.c +++ b/kernel/sys.c @@ -2329,12 +2329,12 @@ static int prctl_set_mm(int opt, unsigned long

[Devel] [PATCH] taskstats: allow delivery of task attributes in VE context

2017-07-04 Thread Stanislav Kinsburskiy
This is needed to make iotop work in container: https://jira.sw.ru/browse/PSBM-56171 Signed-off-by: Stanislav Kinsburskiy --- kernel/taskstats.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/kernel/taskstats.c b/kernel/taskstats.c index 37d4456..ae620de 100644 --- a

[Devel] [libvzctl PATCH 1/2] Add "frozen" attribute to tasks kill helper

2017-07-10 Thread Stanislav Kinsburskiy
And print kill error only if it's set. This is a precursor patch, needed to support tasks killing in thawed container. Signed-off-by: Stanislav Kinsburskiy --- lib/env_nsops.c |6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/lib/env_nsops.c b/lib/env_nsops.c

[Devel] [libvzctl PATCH 0/2] Fix container stop with spfs mount and

2017-07-10 Thread Stanislav Kinsburskiy
unreachable network The solution is to kill spfs process before freezing attempt on fast stop stage. And since the spfs pid in unknown, this is implemented by killing container processes before freezing (error are not handled). https://jira.sw.ru/browse/PSBM-68232 --- Stanislav Kinsburskiy (2

[Devel] [libvzctl PATCH 2/2] Kill tasks before freezing on fast stop

2017-07-10 Thread Stanislav Kinsburskiy
l the container tasks without freezing (and optimization), or at least release processes, waiting for spfs reply in kernel. https://jira.sw.ru/browse/PSBM-68232 Signed-off-by: Stanislav Kinsburskiy --- lib/env_nsops.c |4 1 file changed, 4 insertions(+) diff --git a/lib/env_nsops.c b/lib/en

[Devel] [PATCH 1/3] sunrpc: fix race between "kill_tasks" set and actual task killing

2017-07-10 Thread Stanislav Kinsburskiy
There could be a situation, when RPC task is not yet sleeping, but already passed the check for "kill_tasks" in __rpc_execute(). There is a race in such a case, because task will fall into sleep anyway. This patch makes this probability a little bit less. Signed-off-by: Stanislav K

[Devel] [PATCH 3/3] sunrpc: do not place task to sleep if has to be killed

2017-07-10 Thread Stanislav Kinsburskiy
rowse/PSBM-68214 Signed-off-by: Stanislav Kinsburskiy --- net/sunrpc/sched.c |6 ++ 1 file changed, 6 insertions(+) diff --git a/net/sunrpc/sched.c b/net/sunrpc/sched.c index cd41946..a55 100644 --- a/net/sunrpc/sched.c +++ b/net/sunrpc/sched.c @@ -354,6 +354,12 @@ static void __

[Devel] [PATCH 2/3] sunrpc: use rpc_killall_tasks helper when "kill_tasks" toggle is raised

2017-07-10 Thread Stanislav Kinsburskiy
This helper is much better. First, is's in upsteam (I wrote it, but forgot :( ). Second, it kills *all* tasks (including sleeping in other than "pending" queues). Signed-off-by: Stanislav Kinsburskiy --- net/sunrpc/clnt.c |7 ++- 1 file changed, 2 insertions(+), 5 del

[Devel] [PATCH 0/3] SUNRPC: fix races in tasks killing

2017-07-10 Thread Stanislav Kinsburskiy
This series fix two races with SUNRPC tasks killing on fast stop and also fix the kill itself (*all* the tasks are killed now, but not only those in "pending" wait queue). https://jira.sw.ru/browse/PSBM-68214 --- Stanislav Kinsburskiy (3): sunrpc: fix race between "kill

[Devel] [PATCH v2] mounts: support only shared NFS mounts in inits mount namespace

2017-07-11 Thread Stanislav Kinsburskiy
ectly. Signed-off-by: Stanislav Kinsburskiy --- criu/mount.c | 79 +- 1 file changed, 78 insertions(+), 1 deletion(-) diff --git a/criu/mount.c b/criu/mount.c index 6916974..26f3aa5 100644 --- a/criu/mount.c +++ b/criu/mount.c @@ -746,6 +7

[Devel] [PATCH 0/2] module: expose sysfs dentries in container

2017-07-11 Thread Stanislav Kinsburskiy
This is needed to make lsmod happy. https://jira.sw.ru/browse/PSBM-63892 --- Stanislav Kinsburskiy (2): ve sysfs: export sysfs_perms_set helper module: export sysfs dentries in containers fs/sysfs/ve.c |2 +- include/linux/sysfs.h |5 + kernel/module.c

[Devel] [PATCH 2/2] module: export sysfs dentries in containers

2017-07-11 Thread Stanislav Kinsburskiy
time and there is not need to allocate this buffer each time we need to expose or hide module sysfs dentries (allocating on stack gives "the frame size of 4104 bytes is larger than 2048 bytes" warning) https://jira.sw.ru/browse/PSBM-63892 Signed-off-by: Stanislav

[Devel] [PATCH 1/2] ve sysfs: export sysfs_perms_set helper

2017-07-11 Thread Stanislav Kinsburskiy
It's going to be used to expose modules sysfs dentries Signed-off-by: Stanislav Kinsburskiy --- fs/sysfs/ve.c |2 +- include/linux/sysfs.h |5 + 2 files changed, 6 insertions(+), 1 deletion(-) diff --git a/fs/sysfs/ve.c b/fs/sysfs/ve.c index d7eff88..4c6f9ce 100644 ---

Re: [Devel] [PATCH] x86/vdso: Add 64-bit vdso map API

2017-07-12 Thread Stanislav Kinsburskiy
I'm sorry, but this patch can and has to be split into series of patches. 11 июля 2017 г. 20:48 пользователь Dmitry Safonov написал: Mainstream already has arch_prctl(MAP_VDSO_64), but this was ommited for simplicity and we only have arch_prctl(MAP_VDSO_32). This was not a problem as previously

[Devel] [PATCH] ipvs: fix memory leak in ip_vs_ctl.c

2017-07-13 Thread Stanislav Kinsburskiy
vars moved to ipvs struct.") Signed-off-by: Tommi Rantala Acked-by: Julian Anastasov Signed-off-by: Simon Horman Signed-off-by: Stanislav Kinsburskiy --- net/netfilter/ipvs/ip_vs_ctl.c |3 +++ 1 file changed, 3 insertions(+) diff --git a/net/netfilter/ipvs/ip_vs_ctl.c b/net/netfilter/

[Devel] [PATCH] fs/proc/base.c: fix GPF in /proc/$PID/map_files

2017-07-14 Thread Stanislav Kinsburskiy
-by: Andrew Morton Signed-off-by: Linus Torvalds Signed-off-by: Stanislav Kinsburskiy --- fs/proc/base.c |1 + 1 file changed, 1 insertion(+) diff --git a/fs/proc/base.c b/fs/proc/base.c index 0af670c..291e503 100644 --- a/fs/proc/base.c +++ b/fs/proc/base.c @@ -2028,6 +2028,7 @@ static int proc_

[Devel] [PATCH] net/core/flow.c: Fix CPU hotplug callback registration

2017-07-18 Thread Stanislav Kinsburskiy
low.c by using this latter form of callback registration. Cc: Li RongQing Cc: Sasha Levin Cc: Andrew Morton Cc: Chris Metcalf Cc: Ingo Molnar Acked-by: David S. Miller Signed-off-by: Srivatsa S. Bhat Signed-off-by: Rafael J. Wysocki Signed-off-by: Stanislav Kinsburskiy --- net/core/flow.

[Devel] [PATCH] mounts: support NFS bind-mounts in the same shared group

2017-07-19 Thread Stanislav Kinsburskiy
Initial patch was supporting only slave mounts as bind-mounts. https://jira.sw.ru/browse/PSBM-68663 Signed-off-by: Stanislav Kinsburskiy --- criu/mount.c | 13 - 1 file changed, 8 insertions(+), 5 deletions(-) diff --git a/criu/mount.c b/criu/mount.c index 3abdb6e..7ed5d6e

[Devel] [PATCH] mount: allow any types of NFS mount for a while

2017-07-19 Thread Stanislav Kinsburskiy
Current check for unsupported mounts is obviously broken. So, skip it for a while. https://jira.sw.ru/browse/PSBM-68708 Signed-off-by: Stanislav Kinsburskiy --- criu/mount.c |2 ++ 1 file changed, 2 insertions(+) diff --git a/criu/mount.c b/criu/mount.c index 7ed5d6e..2ec94b3 100644 --- a

Re: [Devel] [PATCH] kernel: call task_work_run() before exit_task_namespaces()

2017-07-19 Thread Stanislav Kinsburskiy
19 июля 2017 г. 9:14 PM пользователь Andrey Vagin написал: On Wed, Jul 19, 2017 at 08:04:22PM +0300, Andrey Ryabinin wrote: > > > On 07/19/2017 04:14 AM, Andrei Vagin wrote: > > From: Andrei Vagin > > > > task_work_run() has to be called before exit_task_namespaces(), > > because fuse_abort_co

Re: [Devel] [PATCH] kernel: call task_work_run() before exit_task_namespaces()

2017-07-19 Thread Stanislav Kinsburskiy
19 июля 2017 г. 9:37 PM пользователь Andrey Vagin написал: On Wed, Jul 19, 2017 at 11:31:28AM -0700, Stanislav Kinsburskiy wrote: > > > 19 июля 2017 г. 9:14 PM пользователь Andrey Vagin > написал: > > On Wed, Jul 19, 2017 at 08:04:22PM +0300, And

[Devel] [PATCH 2/3] proc-net: proc_net_create() helper introduced

2017-07-20 Thread Stanislav Kinsburskiy
Signed-off-by: Stanislav Kinsburskiy --- include/linux/proc_fs.h |7 +++ 1 file changed, 7 insertions(+) diff --git a/include/linux/proc_fs.h b/include/linux/proc_fs.h index 4660327..1b516bc 100644 --- a/include/linux/proc_fs.h +++ b/include/linux/proc_fs.h @@ -67,6 +67,13 @@ static

[Devel] [PATCH 1/3] proc-net: revert e5990221bde54d757a5b5d85e81b2535064570ad

2017-07-20 Thread Stanislav Kinsburskiy
Revert "proc-net: mark all files in proc-net directories as virtualized". This tirck doesn't allow to define any non-visible per-net dentry, while we will need it it to support container migration with disabled netfilter. Signed-off-by: Stanislav Kinsburskiy --- fs/proc/generic

[Devel] [PATCH 0/3] proc-net: rework containerization

2017-07-20 Thread Stanislav Kinsburskiy
This is precursor series in scope of https://jira.sw.ru/browse/PSBM-58574 --- Stanislav Kinsburskiy (3): proc-net: revert e5990221bde54d757a5b5d85e81b2535064570ad proc-net: proc_net_create() helper introduced proc-net: virtualize all the network proc entries drivers/net/ppp

[Devel] [PATCH 3/3] proc-net: virtualize all the network proc entries

2017-07-20 Thread Stanislav Kinsburskiy
Use proc_net_create() and proc_net_create_data() for all the per-net dentries. We need this to expose per-net sysfs dentries once commit e5990221bde54d757a5b5d85e81b2535064570ad is reverted Signed-off-by: Stanislav Kinsburskiy --- drivers/net/ppp/pppoe.c|2

  1   2   3   4   5   >