Re: [Devel] [PATCH] vz6 ext4: Discard preallocated block before swap_extents

2017-02-27 Thread Dmitry Monakhov
Vasily Averin writes: > Dima, > please take look at comment below. > > On 2017-02-25 18:16, Dmitry Monakhov wrote: >> Inode preallocation consists of two parts (used and unused) fully controlled >> by inode, so it must be discarded before swap extents. >> Currently we may

[Devel] [PATCH] vz6 ext4: Discard preallocated block before swap_extents

2017-02-27 Thread Dmitry Monakhov
Inode preallocation consists of two parts (used and unused) fully controlled by inode, so it must be discarded before swap extents. Currently we may skip drop_preallocation if file is sparse. This patch does: - Moves ext4_discard_preallocations to ext4_swap_extents. This makes more readable and

[Devel] [PATCH] vz6 ext4: Discard preallocated block before swap_extents v2

2017-02-27 Thread Dmitry Monakhov
Inode preallocation consists of two parts (used and unused) fully controlled by inode, so it must be discarded before swap extents. Currently we may skip drop_preallocation if file is sparse. This patch does: - Moves ext4_discard_preallocations to ext4_swap_extents. This makes more readable and

Re: [Devel] [PATCH] vz6 ext4: Discard preallocated block before swap_extents

2017-02-27 Thread Vasily Averin
Dima, please take look at comment below. On 2017-02-25 18:16, Dmitry Monakhov wrote: > Inode preallocation consists of two parts (used and unused) fully controlled > by inode, so it must be discarded before swap extents. > Currently we may skip drop_preallocation if file is sparse. > > This