Re: [Devel] [PATCH 1/2] memcg: fix memcg_size() calculation

2013-12-17 Thread Michal Hocko
On Tue 17-12-13 11:48:20, Glauber Costa wrote: On Mon, Dec 16, 2013 at 8:47 PM, Michal Hocko mho...@suse.cz wrote: On Sat 14-12-13 12:15:33, Vladimir Davydov wrote: The mem_cgroup structure contains nr_node_ids pointers to mem_cgroup_per_node objects, not the objects themselves. Ouch!

Re: [Devel] [PATCH 1/2] memcg: fix memcg_size() calculation

2013-12-17 Thread Glauber Costa
On Mon, Dec 16, 2013 at 8:47 PM, Michal Hocko mho...@suse.cz wrote: On Sat 14-12-13 12:15:33, Vladimir Davydov wrote: The mem_cgroup structure contains nr_node_ids pointers to mem_cgroup_per_node objects, not the objects themselves. Ouch! This is 2k per node which is wasted. What a shame I

Re: [Devel] [PATCH 1/2] memcg: fix memcg_size() calculation

2013-12-16 Thread Michal Hocko
On Sat 14-12-13 12:15:33, Vladimir Davydov wrote: The mem_cgroup structure contains nr_node_ids pointers to mem_cgroup_per_node objects, not the objects themselves. Ouch! This is 2k per node which is wasted. What a shame I haven't noticed this back then when reviewing 45cf7ebd5a033 (memcg:

[Devel] [PATCH 1/2] memcg: fix memcg_size() calculation

2013-12-14 Thread Vladimir Davydov
The mem_cgroup structure contains nr_node_ids pointers to mem_cgroup_per_node objects, not the objects themselves. Signed-off-by: Vladimir Davydov vdavy...@parallels.com Cc: Michal Hocko mho...@suse.cz Cc: Glauber Costa glom...@openvz.org Cc: Johannes Weiner han...@cmpxchg.org Cc: Balbir Singh