Re: [Devel] [PATCH 3/8] memcg, slab: never try to merge memcg caches

2014-02-06 Thread Vladimir Davydov
On 02/06/2014 07:29 PM, Michal Hocko wrote: > On Thu 06-02-14 18:15:50, Vladimir Davydov wrote: >> On 02/06/2014 06:07 PM, Michal Hocko wrote: >>> On Tue 04-02-14 19:27:19, Vladimir Davydov wrote: >>> [...] What does this patch change? Actually, it introduces no functional changes - it on

Re: [Devel] [PATCH 3/8] memcg, slab: never try to merge memcg caches

2014-02-06 Thread Michal Hocko
On Thu 06-02-14 18:15:50, Vladimir Davydov wrote: > On 02/06/2014 06:07 PM, Michal Hocko wrote: > > On Tue 04-02-14 19:27:19, Vladimir Davydov wrote: > > [...] > >> What does this patch change? Actually, it introduces no functional > >> changes - it only remove the code trying to find an alias for

Re: [Devel] [PATCH 3/8] memcg, slab: never try to merge memcg caches

2014-02-06 Thread Vladimir Davydov
On 02/06/2014 06:07 PM, Michal Hocko wrote: > On Tue 04-02-14 19:27:19, Vladimir Davydov wrote: > [...] >> What does this patch change? Actually, it introduces no functional >> changes - it only remove the code trying to find an alias for a memcg >> cache, because it will fail anyway. So this is ra

Re: [Devel] [PATCH 3/8] memcg, slab: never try to merge memcg caches

2014-02-06 Thread Michal Hocko
On Tue 04-02-14 19:27:19, Vladimir Davydov wrote: [...] > What does this patch change? Actually, it introduces no functional > changes - it only remove the code trying to find an alias for a memcg > cache, because it will fail anyway. So this is rather a cleanup. But this also means that two diffe

Re: [Devel] [PATCH 3/8] memcg, slab: never try to merge memcg caches

2014-02-04 Thread Glauber Costa
On Tue, Feb 4, 2014 at 8:04 PM, Vladimir Davydov wrote: > On 02/04/2014 07:43 PM, Glauber Costa wrote: >> On Tue, Feb 4, 2014 at 7:27 PM, Vladimir Davydov >> wrote: >>> On 02/04/2014 07:11 PM, Michal Hocko wrote: On Tue 04-02-14 18:59:23, Vladimir Davydov wrote: > On 02/04/2014 06:52 PM

Re: [Devel] [PATCH 3/8] memcg, slab: never try to merge memcg caches

2014-02-04 Thread Vladimir Davydov
On 02/04/2014 07:43 PM, Glauber Costa wrote: > On Tue, Feb 4, 2014 at 7:27 PM, Vladimir Davydov > wrote: >> On 02/04/2014 07:11 PM, Michal Hocko wrote: >>> On Tue 04-02-14 18:59:23, Vladimir Davydov wrote: On 02/04/2014 06:52 PM, Michal Hocko wrote: > On Sun 02-02-14 20:33:48, Vladimir D

Re: [Devel] [PATCH 3/8] memcg, slab: never try to merge memcg caches

2014-02-04 Thread Glauber Costa
On Tue, Feb 4, 2014 at 7:27 PM, Vladimir Davydov wrote: > On 02/04/2014 07:11 PM, Michal Hocko wrote: >> On Tue 04-02-14 18:59:23, Vladimir Davydov wrote: >>> On 02/04/2014 06:52 PM, Michal Hocko wrote: On Sun 02-02-14 20:33:48, Vladimir Davydov wrote: > Suppose we are creating memcg cach

Re: [Devel] [PATCH 3/8] memcg, slab: never try to merge memcg caches

2014-02-04 Thread Vladimir Davydov
On 02/04/2014 07:11 PM, Michal Hocko wrote: > On Tue 04-02-14 18:59:23, Vladimir Davydov wrote: >> On 02/04/2014 06:52 PM, Michal Hocko wrote: >>> On Sun 02-02-14 20:33:48, Vladimir Davydov wrote: Suppose we are creating memcg cache A that could be merged with cache B of the same memcg. S

Re: [Devel] [PATCH 3/8] memcg, slab: never try to merge memcg caches

2014-02-04 Thread Michal Hocko
On Tue 04-02-14 18:59:23, Vladimir Davydov wrote: > On 02/04/2014 06:52 PM, Michal Hocko wrote: > > On Sun 02-02-14 20:33:48, Vladimir Davydov wrote: > >> Suppose we are creating memcg cache A that could be merged with cache B > >> of the same memcg. Since any memcg cache has the same parameters as

Re: [Devel] [PATCH 3/8] memcg, slab: never try to merge memcg caches

2014-02-04 Thread Michal Hocko
On Sun 02-02-14 20:33:48, Vladimir Davydov wrote: > Suppose we are creating memcg cache A that could be merged with cache B > of the same memcg. Since any memcg cache has the same parameters as its > parent cache, parent caches PA and PB of memcg caches A and B must be > mergeable too. That means P

Re: [Devel] [PATCH 3/8] memcg, slab: never try to merge memcg caches

2014-02-04 Thread Vladimir Davydov
On 02/04/2014 06:52 PM, Michal Hocko wrote: > On Sun 02-02-14 20:33:48, Vladimir Davydov wrote: >> Suppose we are creating memcg cache A that could be merged with cache B >> of the same memcg. Since any memcg cache has the same parameters as its >> parent cache, parent caches PA and PB of memcg cac

[Devel] [PATCH 3/8] memcg, slab: never try to merge memcg caches

2014-02-02 Thread Vladimir Davydov
Suppose we are creating memcg cache A that could be merged with cache B of the same memcg. Since any memcg cache has the same parameters as its parent cache, parent caches PA and PB of memcg caches A and B must be mergeable too. That means PA was merged with PB on creation or vice versa, i.e. PA =