[Devel] [PATCH criu v7-u5 1/2] mount: restore_task_mnt_ns - Lookup for mount namespace conditionally

2017-07-22 Thread Cyrill Gorcunov
In case if our parent is a dead task (zombie) we should lookup for parent ids which will be inherited on restore. Otherwise parent->ids may be nil and SIGSEGV produced. https://jira.sw.ru/browse/PSBM-68062 Signed-off-by: Cyrill Gorcunov --- criu/mount.c | 7 +-- 1 file changed, 5 insertions

Re: [Devel] [PATCH criu v7-u5 1/2] mount: restore_task_mnt_ns - Lookup for mount namespace conditionally

2017-07-25 Thread Andrey Vagin
On Sat, Jul 22, 2017 at 01:27:08PM +0300, Cyrill Gorcunov wrote: > In case if our parent is a dead task (zombie) we should lookup > for parent ids which will be inherited on restore. Otherwise > parent->ids may be nil and SIGSEGV produced. > > https://jira.sw.ru/browse/PSBM-68062 > > Signed-off-b

Re: [Devel] [PATCH criu v7-u5 1/2] mount: restore_task_mnt_ns - Lookup for mount namespace conditionally

2017-07-25 Thread Cyrill Gorcunov
On Tue, Jul 25, 2017 at 10:26:17AM -0700, Andrey Vagin wrote: > > ^^^ It is incorrect. We want to check that a parent task lives in this > same mount namespace. > > The code has to be something like this: > > if (next->ids == NULL) /* helper or zombie */ >