[Devel] [PATCH rh7] mm/zswap: fix potential deadlock in zswap_frontswap_store()

2017-03-28 Thread Andrey Ryabinin
zswap_frontswap_store() is called during memory reclaim, therefore it can't use __GFP_FS, otherwise we may renter into fs code and deadlock. zswap_frontswap_store() also shouldn't do __GFP_IO, to avoid reentering into zswap code itself. WARNING: at mm/slub.c:1250 slab_pre_alloc_hook.isra.42.part.

Re: [Devel] [PATCH rh7] mm/zswap: fix potential deadlock in zswap_frontswap_store()

2017-03-29 Thread Konstantin Khorenko
Andrey, did you send it to mainstream as well? Please post a link here. -- Best regards, Konstantin Khorenko, Virtuozzo Linux Kernel Team On 03/28/2017 12:17 PM, Andrey Ryabinin wrote: zswap_frontswap_store() is called during memory reclaim, therefore it can't use __GFP_FS, otherwise we may r

Re: [Devel] [PATCH rh7] mm/zswap: fix potential deadlock in zswap_frontswap_store()

2017-03-31 Thread Andrey Ryabinin
On 03/29/2017 03:32 PM, Konstantin Khorenko wrote: > Andrey, did you send it to mainstream as well? > > Please post a link here. > https://lkml.kernel.org/r/20170331153009.11397-1-aryabi...@virtuozzo.com Note it slightly different, after looking at this code again I decided to made small cle

Re: [Devel] [PATCH rh7] mm/zswap: fix potential deadlock in zswap_frontswap_store()

2017-04-03 Thread Konstantin Khorenko
On 03/31/2017 06:34 PM, Andrey Ryabinin wrote: On 03/29/2017 03:32 PM, Konstantin Khorenko wrote: Andrey, did you send it to mainstream as well? Please post a link here. https://lkml.kernel.org/r/20170331153009.11397-1-aryabi...@virtuozzo.com Note it slightly different, after looking at t

Re: [Devel] [PATCH rh7] mm/zswap: fix potential deadlock in zswap_frontswap_store()

2017-05-12 Thread Konstantin Khorenko
No answer from ms guys? To ping once again? -- Best regards, Konstantin Khorenko, Virtuozzo Linux Kernel Team On 04/03/2017 12:52 PM, Konstantin Khorenko wrote: On 03/31/2017 06:34 PM, Andrey Ryabinin wrote: On 03/29/2017 03:32 PM, Konstantin Khorenko wrote: Andrey, did you send it to main

Re: [Devel] [PATCH rh7] mm/zswap: fix potential deadlock in zswap_frontswap_store()

2017-05-12 Thread Andrey Ryabinin
On 05/12/2017 03:36 PM, Konstantin Khorenko wrote: > No answer from ms guys? > To ping once again? > There were answers. It was figured out that there is no bug here, as PF_MEMALLOC protects us from recursion. So, the patch is not needed. > -- > Best regards, > > Konstantin Khorenko, > Virt