Re: [Devel] [PATCH rh7] vtty: Don't close unread master peer if slave is nonzero

2015-12-28 Thread Konstantin Khorenko
On 12/05/2015 08:21 PM, Cyrill Gorcunov wrote: When there are several files opened on /dev/console from inside of a container and noone hooked on master peer, any close called cause master peer to be freed with TTY_CLOSING bit set. So that next "vzctl console $ctid $ttynum" call force kernel to

Re: [Devel] [PATCH rh7] vtty: Don't close unread master peer if slave is nonzero

2015-12-28 Thread Konstantin Khorenko
On 12/11/2015 06:05 PM, Cyrill Gorcunov wrote: On Fri, Dec 11, 2015 at 05:36:25PM +0300, Vladimir Davydov wrote: I suppose we should now drop TTY_PINNED_BY_OTHER. Other than that, the patch looks OK to me: Reviewed-by: Vladimir Davydov TTY_PINNED_BY_OTHER is used

Re: [Devel] [PATCH rh7] vtty: Don't close unread master peer if slave is nonzero

2015-12-28 Thread Cyrill Gorcunov
On Mon, Dec 28, 2015 at 05:23:21PM +0300, Konstantin Khorenko wrote: > On 12/05/2015 08:21 PM, Cyrill Gorcunov wrote: > >When there are several files opened on /dev/console from inside > >of a container and noone hooked on master peer, any close called > >cause master peer to be freed with

Re: [Devel] [PATCH rh7] vtty: Don't close unread master peer if slave is nonzero

2015-12-28 Thread Cyrill Gorcunov
On Mon, Dec 28, 2015 at 04:33:39PM +0300, Konstantin Khorenko wrote: > >>Reviewed-by: Vladimir Davydov > > > >TTY_PINNED_BY_OTHER is used for wirtting into vtty where > >no master connected (in n_tty.c code), so I need to > >add another helper for it and eliminate

Re: [Devel] [PATCH rh7] vtty: Don't close unread master peer if slave is nonzero

2015-12-11 Thread Vladimir Davydov
On Sat, Dec 05, 2015 at 08:21:19PM +0300, Cyrill Gorcunov wrote: > When there are several files opened on /dev/console from inside > of a container and noone hooked on master peer, any close called > cause master peer to be freed with TTY_CLOSING bit set. So that > next "vzctl console $ctid

Re: [Devel] [PATCH rh7] vtty: Don't close unread master peer if slave is nonzero

2015-12-11 Thread Cyrill Gorcunov
On Fri, Dec 11, 2015 at 05:36:25PM +0300, Vladimir Davydov wrote: > > I suppose we should now drop TTY_PINNED_BY_OTHER. Other than that, the > patch looks OK to me: > > Reviewed-by: Vladimir Davydov TTY_PINNED_BY_OTHER is used for wirtting into vtty where no master

[Devel] [PATCH rh7] vtty: Don't close unread master peer if slave is nonzero

2015-12-05 Thread Cyrill Gorcunov
When there are several files opened on /dev/console from inside of a container and noone hooked on master peer, any close called cause master peer to be freed with TTY_CLOSING bit set. So that next "vzctl console $ctid $ttynum" call force kernel to allocate new vtty pair and in result we can't