[Devel] Re: [-mm PATCH 1/8] Memory controller resource counters (v2)

2007-07-09 Thread Dave Hansen
On Mon, 2007-07-09 at 11:16 +0400, Pavel Emelianov wrote: > Dave Hansen wrote: > > On Thu, 2007-07-05 at 22:20 -0700, Balbir Singh wrote: > >> +/* > >> + * the core object. the container that wishes to account for some > >> + * resource may include this counter into its structures and use > >> + *

[Devel] Re: [-mm PATCH 1/8] Memory controller resource counters (v2)

2007-07-09 Thread Pavel Emelianov
Dave Hansen wrote: > On Thu, 2007-07-05 at 22:20 -0700, Balbir Singh wrote: >> +/* >> + * the core object. the container that wishes to account for some >> + * resource may include this counter into its structures and use >> + * the helpers described beyond >> + */ > > I'm going to nitpick a bit h

[Devel] Re: [-mm PATCH 1/8] Memory controller resource counters (v2)

2007-07-06 Thread Balbir Singh
Dave Hansen wrote: > On Fri, 2007-07-06 at 14:03 -0700, Balbir Singh wrote: +ssize_t res_counter_read(struct res_counter *cnt, int member, +const char __user *userbuf, size_t nbytes, loff_t >> *pos) +{ +unsigned long *val; +char buf[64], *s; +

[Devel] Re: [-mm PATCH 1/8] Memory controller resource counters (v2)

2007-07-06 Thread Balbir Singh
Dave Hansen wrote: > On Thu, 2007-07-05 at 22:20 -0700, Balbir Singh wrote: >> +/* >> + * the core object. the container that wishes to account for some >> + * resource may include this counter into its structures and use >> + * the helpers described beyond >> + */ > > I'm going to nitpick a bit h

[Devel] Re: [-mm PATCH 1/8] Memory controller resource counters (v2)

2007-07-06 Thread Dave Hansen
On Fri, 2007-07-06 at 14:03 -0700, Balbir Singh wrote: > > >> +ssize_t res_counter_read(struct res_counter *cnt, int member, > >> +const char __user *userbuf, size_t nbytes, loff_t > *pos) > >> +{ > >> +unsigned long *val; > >> +char buf[64], *s; > >> + > >> +s = buf; > >>

[Devel] Re: [-mm PATCH 1/8] Memory controller resource counters (v2)

2007-07-06 Thread Dave Hansen
On Thu, 2007-07-05 at 22:20 -0700, Balbir Singh wrote: > +/* > + * the core object. the container that wishes to account for some > + * resource may include this counter into its structures and use > + * the helpers described beyond > + */ I'm going to nitpick a bit here. Nothing major, I promise