[Devel] Re: [PATCH] Virtual ethernet device (v2.1)

2007-07-13 Thread Christian Borntraeger
Am Mittwoch, 11. Juli 2007 schrieb Pavel Emelianov: > drivers/net/veth.c | 452 > include/net/veth.h | 14 + I know, I am late in the game, but wont the name collide somewhat with drivers/net/ibmveth.h, drivers/net/iseries_veth.c, and drivers/net/ibmveth.c? Christian ___

[Devel] Re: [PATCH] Virtual ethernet device (v2.1)

2007-07-11 Thread David Miller
From: Christian Borntraeger <[EMAIL PROTECTED]> Date: Wed, 11 Jul 2007 12:54:24 +0200 > Am Mittwoch, 11. Juli 2007 schrieb Pavel Emelianov: > > drivers/net/veth.c | 452 > > include/net/veth.h | 14 + > > I know, I am late in the game, but wont the name collide somewhat with > drivers/ne

[Devel] Re: [PATCH] Virtual ethernet device (v2.1)

2007-07-11 Thread Patrick McHardy
Pavel Emelianov wrote: > OK. I'll try to make the generic call. Could you please send me the > patches with IFLA_ADDRESS support for booth kernel and ip utility. I'll send the kernel patches seperately in a few minutes. iproute doesn't need any further patches. __

[Devel] Re: [PATCH] Virtual ethernet device (v2.1)

2007-07-11 Thread Pavel Emelianov
Patrick McHardy wrote: > Pavel Emelianov wrote: >> Patrick McHardy wrote: >> >>> Mhh doing it later means dealing with compatibility issues, which >>> is why I'm asking now. We currently support IFLA_NAME, IFLA_MTU, >> >> Oh, I see. >> >> >>> IFLA_TXQLEN, IFLA_WEIGTH, IFLA_OPERSTATE and IFLA_LINKMO

[Devel] Re: [PATCH] Virtual ethernet device (v2.1)

2007-07-11 Thread Patrick McHardy
Pavel Emelianov wrote: > Patrick McHardy wrote: > >>Mhh doing it later means dealing with compatibility issues, which >>is why I'm asking now. We currently support IFLA_NAME, IFLA_MTU, > > > Oh, I see. > > >>IFLA_TXQLEN, IFLA_WEIGTH, IFLA_OPERSTATE and IFLA_LINKMODE, and >>with my patch additi

[Devel] Re: [PATCH] Virtual ethernet device (v2.1)

2007-07-11 Thread Pavel Emelianov
Patrick McHardy wrote: > Pavel Emelianov wrote: >> Patrick McHardy wrote: >> >>> Pavel Emelianov wrote: >>> +static const struct nla_policy veth_policy[VETH_INFO_MAX + 1] = { + [VETH_INFO_MAC] = { .type = NLA_BINARY, .len = ETH_ALEN }, + [VETH_INFO_PEER]= { .type =

[Devel] Re: [PATCH] Virtual ethernet device (v2.1)

2007-07-11 Thread Patrick McHardy
Pavel Emelianov wrote: > Patrick McHardy wrote: > >>Pavel Emelianov wrote: >> >>>+static const struct nla_policy veth_policy[VETH_INFO_MAX + 1] = { >>>+[VETH_INFO_MAC] = { .type = NLA_BINARY, .len = ETH_ALEN }, >>>+[VETH_INFO_PEER]= { .type = NLA_STRING }, >>>+[VETH_INF

[Devel] Re: [PATCH] Virtual ethernet device (v2.1)

2007-07-11 Thread Pavel Emelianov
Patrick McHardy wrote: > Pavel Emelianov wrote: >> +static const struct nla_policy veth_policy[VETH_INFO_MAX + 1] = { >> +[VETH_INFO_MAC] = { .type = NLA_BINARY, .len = ETH_ALEN }, >> +[VETH_INFO_PEER]= { .type = NLA_STRING }, >> +[VETH_INFO_PEER_MAC]= { .type = NLA_

[Devel] Re: [PATCH] Virtual ethernet device (v2.1)

2007-07-11 Thread Patrick McHardy
Pavel Emelianov wrote: > +static const struct nla_policy veth_policy[VETH_INFO_MAX + 1] = { > + [VETH_INFO_MAC] = { .type = NLA_BINARY, .len = ETH_ALEN }, > + [VETH_INFO_PEER]= { .type = NLA_STRING }, > + [VETH_INFO_PEER_MAC]= { .type = NLA_BINARY, .len = ETH_ALEN },

[Devel] Re: [PATCH] Virtual ethernet device (v2.1)

2007-07-11 Thread Pavel Emelianov
Christian Borntraeger wrote: > Am Mittwoch, 11. Juli 2007 schrieb Pavel Emelianov: >> drivers/net/veth.c | 452 >> include/net/veth.h | 14 + > > I know, I am late in the game, but wont the name collide somewhat with > drivers/net/ibmveth.h, drivers/net/iseries_veth.c, and drivers/net/ibm

[Devel] Re: [PATCH] Virtual ethernet device (v2.1)

2007-07-11 Thread Evgeniy Polyakov
Hi. On Wed, Jul 11, 2007 at 01:31:15PM +0400, Pavel Emelianov ([EMAIL PROTECTED]) wrote: > Veth stands for Virtual ETHernet. It is a simple tunnel driver > that works at the link layer and looks like a pair of ethernet > devices interconnected with each other. > > Mainly it allows to communicate