[Devel] Re: [PATCH] cgroupfs: create /sys/fs/cgroup to mount cgroupfs on

2010-07-26 Thread Greg KH
On Tue, Jul 27, 2010 at 12:08:03AM +0200, Dhaval Giani wrote: > On Tue, Jul 27, 2010 at 12:05 AM, Greg KH wrote: > > On Mon, Jul 26, 2010 at 02:55:18PM -0700, Paul Menage wrote: > >> On Mon, Jul 26, 2010 at 2:28 PM, Greg KH wrote: > >> > > >> > Ok, again, after all of this, who is going to be app

[Devel] Re: [PATCH] cgroupfs: create /sys/fs/cgroup to mount cgroupfs on

2010-07-26 Thread Greg KH
On Mon, Jul 26, 2010 at 03:09:09PM -0700, Paul Menage wrote: > On Mon, Jul 26, 2010 at 3:05 PM, Greg KH wrote: > > > > Wonderful, can I get some acks from the cgroups maintainers?  I'll > > gladly take it through my tree. > > Sure. > > Acked-by: Paul Menage Wonderful, now queued up. greg k-h

[Devel] Re: [PATCH] cgroupfs: create /sys/fs/cgroup to mount cgroupfs on

2010-07-26 Thread Paul Menage
On Mon, Jul 26, 2010 at 3:05 PM, Greg KH wrote: > > Wonderful, can I get some acks from the cgroups maintainers?  I'll > gladly take it through my tree. Sure. Acked-by: Paul Menage Paul ___ Containers mailing list contain...@lists.linux-foundation.or

[Devel] Re: [PATCH] cgroupfs: create /sys/fs/cgroup to mount cgroupfs on

2010-07-26 Thread Dhaval Giani
On Tue, Jul 27, 2010 at 12:05 AM, Greg KH wrote: > On Mon, Jul 26, 2010 at 02:55:18PM -0700, Paul Menage wrote: >> On Mon, Jul 26, 2010 at 2:28 PM, Greg KH wrote: >> > >> > Ok, again, after all of this, who is going to be applying this patch to >> > their tree for the .36 merge window? >> >> Ther

[Devel] Re: [PATCH] cgroupfs: create /sys/fs/cgroup to mount cgroupfs on

2010-07-26 Thread Greg KH
On Mon, Jul 26, 2010 at 02:55:18PM -0700, Paul Menage wrote: > On Mon, Jul 26, 2010 at 2:28 PM, Greg KH wrote: > > > > Ok, again, after all of this, who is going to be applying this patch to > > their tree for the .36 merge window? > > There's no specific cgroups tree - cgroups patches generally

[Devel] Re: [PATCH] cgroupfs: create /sys/fs/cgroup to mount cgroupfs on

2010-07-26 Thread Paul Menage
On Mon, Jul 26, 2010 at 2:28 PM, Greg KH wrote: > > Ok, again, after all of this, who is going to be applying this patch to > their tree for the .36 merge window? There's no specific cgroups tree - cgroups patches generally go via akpm. > > Or should I apply it to my driver-core one? > That sou

[Devel] Re: [PATCH] cgroupfs: create /sys/fs/cgroup to mount cgroupfs on

2010-07-26 Thread Greg KH
On Mon, Jul 26, 2010 at 11:13:14AM +0200, Dhaval Giani wrote: > On Mon, Jul 26, 2010 at 11:12 AM, Kay Sievers wrote: > > On Mon, Jul 26, 2010 at 11:08, Dhaval Giani > > wrote: > >> On Thu, Jul 22, 2010 at 8:36 PM, Greg KH wrote: > >>> On Thu, Jul 22, 2010 at 11:31:07AM -0700, Paul Menage wrote:

[Devel] Re: [PATCH] cgroupfs: create /sys/fs/cgroup to mount cgroupfs on

2010-07-26 Thread Dhaval Giani
On Mon, Jul 26, 2010 at 11:12 AM, Kay Sievers wrote: > On Mon, Jul 26, 2010 at 11:08, Dhaval Giani wrote: >> On Thu, Jul 22, 2010 at 8:36 PM, Greg KH wrote: >>> On Thu, Jul 22, 2010 at 11:31:07AM -0700, Paul Menage wrote: On Thu, Jul 22, 2010 at 11:26 AM, Greg KH wrote: > We really sh

[Devel] Re: [PATCH] cgroupfs: create /sys/fs/cgroup to mount cgroupfs on

2010-07-26 Thread Kay Sievers
On Mon, Jul 26, 2010 at 11:08, Dhaval Giani wrote: > On Thu, Jul 22, 2010 at 8:36 PM, Greg KH wrote: >> On Thu, Jul 22, 2010 at 11:31:07AM -0700, Paul Menage wrote: >>> On Thu, Jul 22, 2010 at 11:26 AM, Greg KH wrote: >>> > We really shouldn't be asking userspace to create new root filesystems.

[Devel] Re: [PATCH] cgroupfs: create /sys/fs/cgroup to mount cgroupfs on

2010-07-24 Thread Balbir Singh
* Vivek Goyal [2010-07-22 17:26:34]: > On Thu, Jul 22, 2010 at 02:18:56PM -0700, Greg KH wrote: > > On Thu, Jul 22, 2010 at 03:37:41PM -0400, Vivek Goyal wrote: > > > On Thu, Jul 22, 2010 at 11:36:15AM -0700, Greg KH wrote: > > > > On Thu, Jul 22, 2010 at 11:31:07AM -0700, Paul Menage wrote: > >

[Devel] Re: [PATCH] cgroupfs: create /sys/fs/cgroup to mount cgroupfs on

2010-07-23 Thread Matt Helsley
On Fri, Jul 23, 2010 at 01:10:43AM +0200, Kay Sievers wrote: > On Thu, Jul 22, 2010 at 23:48, Matt Helsley wrote: > > So I'd suggest > > those cgroup mounts go in /var/run/systemd/cgroup or something like that. > > Impossible, we need it at bootup, and / is usually read-only, and /var > might eve

[Devel] Re: [PATCH] cgroupfs: create /sys/fs/cgroup to mount cgroupfs on

2010-07-23 Thread Greg KH
On Fri, Jul 23, 2010 at 12:32:26PM +0200, Jan Safranek wrote: > On 07/23/2010 04:07 AM, Vivek Goyal wrote: >> On Thu, Jul 22, 2010 at 04:14:01PM -0700, Greg KH wrote: >>> On Fri, Jul 23, 2010 at 01:08:12AM +0200, Kay Sievers wrote: On Thu, Jul 22, 2010 at 23:18, Greg KH wrote: >> For my t

[Devel] Re: [PATCH] cgroupfs: create /sys/fs/cgroup to mount cgroupfs on

2010-07-23 Thread Jan Safranek
On 07/23/2010 04:07 AM, Vivek Goyal wrote: > On Thu, Jul 22, 2010 at 04:14:01PM -0700, Greg KH wrote: >> On Fri, Jul 23, 2010 at 01:08:12AM +0200, Kay Sievers wrote: >>> On Thu, Jul 22, 2010 at 23:18, Greg KH wrote: > For my testing I now always use /cgroup/ and create directories under it >>>

[Devel] Re: [PATCH] cgroupfs: create /sys/fs/cgroup to mount cgroupfs on

2010-07-22 Thread Vivek Goyal
On Thu, Jul 22, 2010 at 04:14:01PM -0700, Greg KH wrote: > On Fri, Jul 23, 2010 at 01:08:12AM +0200, Kay Sievers wrote: > > On Thu, Jul 22, 2010 at 23:18, Greg KH wrote: > > >> For my testing I now always use /cgroup/ and create directories under it > > >> /cgroup/blkio /cgroup/cpu etc and mount c

[Devel] Re: [PATCH] cgroupfs: create /sys/fs/cgroup to mount cgroupfs on

2010-07-22 Thread Greg KH
On Thu, Jul 22, 2010 at 05:26:34PM -0400, Vivek Goyal wrote: > On Thu, Jul 22, 2010 at 02:18:56PM -0700, Greg KH wrote: > > On Thu, Jul 22, 2010 at 03:37:41PM -0400, Vivek Goyal wrote: > > > On Thu, Jul 22, 2010 at 11:36:15AM -0700, Greg KH wrote: > > > > On Thu, Jul 22, 2010 at 11:31:07AM -0700, P

[Devel] Re: [PATCH] cgroupfs: create /sys/fs/cgroup to mount cgroupfs on

2010-07-22 Thread Greg KH
On Thu, Jul 22, 2010 at 04:12:58PM -0700, Paul Menage wrote: > On Thu, Jul 22, 2010 at 2:19 PM, Greg KH wrote: > > > > Any suggestions from your side? > > > > I'd probably go with Matt's suggestion of /var/run. See Kay's answer for why this will not work. sorry, greg k-h __

[Devel] Re: [PATCH] cgroupfs: create /sys/fs/cgroup to mount cgroupfs on

2010-07-22 Thread Kay Sievers
On Thu, 2010-07-22 at 16:14 -0700, Greg KH wrote: > On Fri, Jul 23, 2010 at 01:08:12AM +0200, Kay Sievers wrote: > > On Thu, Jul 22, 2010 at 23:18, Greg KH wrote: > > >> For my testing I now always use /cgroup/ and create directories under it > > >> /cgroup/blkio /cgroup/cpu etc and mount controll

[Devel] Re: [PATCH] cgroupfs: create /sys/fs/cgroup to mount cgroupfs on

2010-07-22 Thread Paul Menage
On Thu, Jul 22, 2010 at 4:14 PM, Greg KH wrote: > > Ah, that makes it easier.  Paul and Vivek, any objection to this patch > going in now? > Sounds reasonable. Paul ___ Containers mailing list contain...@lists.linux-foundation.org https://lists.linux-f

[Devel] Re: [PATCH] cgroupfs: create /sys/fs/cgroup to mount cgroupfs on

2010-07-22 Thread Greg KH
On Fri, Jul 23, 2010 at 01:08:12AM +0200, Kay Sievers wrote: > On Thu, Jul 22, 2010 at 23:18, Greg KH wrote: > >> For my testing I now always use /cgroup/ and create directories under it > >> /cgroup/blkio /cgroup/cpu etc and mount controllers on respective > >> directories. > > > > Lennart and Ka

[Devel] Re: [PATCH] cgroupfs: create /sys/fs/cgroup to mount cgroupfs on

2010-07-22 Thread Paul Menage
On Thu, Jul 22, 2010 at 2:19 PM, Greg KH wrote: > > Any suggestions from your side? > I'd probably go with Matt's suggestion of /var/run. Paul ___ Containers mailing list contain...@lists.linux-foundation.org https://lists.linux-foundation.org/mailman/

[Devel] Re: [PATCH] cgroupfs: create /sys/fs/cgroup to mount cgroupfs on

2010-07-22 Thread Kay Sievers
On Thu, Jul 22, 2010 at 23:48, Matt Helsley wrote: > So I'd suggest > those cgroup mounts go in /var/run/systemd/cgroup or something like that. Impossible, we need it at bootup, and / is usually read-only, and /var might even be behind the network we need to bring up. It needs to be on tmpfs mou

[Devel] Re: [PATCH] cgroupfs: create /sys/fs/cgroup to mount cgroupfs on

2010-07-22 Thread Kay Sievers
On Thu, Jul 22, 2010 at 23:18, Greg KH wrote: >> For my testing I now always use /cgroup/ and create directories under it >> /cgroup/blkio /cgroup/cpu etc and mount controllers on respective >> directories. > > Lennart and Kay, is this what systemd is doing?  I really don't think we > should be ad

[Devel] Re: [PATCH] cgroupfs: create /sys/fs/cgroup to mount cgroupfs on

2010-07-22 Thread Matt Helsley
On Thu, Jul 22, 2010 at 12:12:00PM -0700, Greg KH wrote: > On Thu, Jul 22, 2010 at 12:07:43PM -0700, Paul Menage wrote: > > On Thu, Jul 22, 2010 at 11:53 AM, Greg KH wrote: > > > > > > If you are using /dev/cgroup/ that's nice, but I don't think that people > > > are expecting a whole filesystem u

[Devel] Re: [PATCH] cgroupfs: create /sys/fs/cgroup to mount cgroupfs on

2010-07-22 Thread Vivek Goyal
On Thu, Jul 22, 2010 at 02:18:56PM -0700, Greg KH wrote: > On Thu, Jul 22, 2010 at 03:37:41PM -0400, Vivek Goyal wrote: > > On Thu, Jul 22, 2010 at 11:36:15AM -0700, Greg KH wrote: > > > On Thu, Jul 22, 2010 at 11:31:07AM -0700, Paul Menage wrote: > > > > On Thu, Jul 22, 2010 at 11:26 AM, Greg KH

[Devel] Re: [PATCH] cgroupfs: create /sys/fs/cgroup to mount cgroupfs on

2010-07-22 Thread Greg KH
On Thu, Jul 22, 2010 at 12:18:13PM -0700, Paul Menage wrote: > On Thu, Jul 22, 2010 at 12:12 PM, Greg KH wrote: > > I don't know if we want to encourage that as a mount point, do you? > > No. Heh. > > What are the different names you are giving to your mount points now for > > cgroupfs so I can

[Devel] Re: [PATCH] cgroupfs: create /sys/fs/cgroup to mount cgroupfs on

2010-07-22 Thread Greg KH
On Thu, Jul 22, 2010 at 03:37:41PM -0400, Vivek Goyal wrote: > On Thu, Jul 22, 2010 at 11:36:15AM -0700, Greg KH wrote: > > On Thu, Jul 22, 2010 at 11:31:07AM -0700, Paul Menage wrote: > > > On Thu, Jul 22, 2010 at 11:26 AM, Greg KH wrote: > > > > We really shouldn't be asking userspace to create

[Devel] Re: [PATCH] cgroupfs: create /sys/fs/cgroup to mount cgroupfs on

2010-07-22 Thread Vivek Goyal
On Thu, Jul 22, 2010 at 11:36:15AM -0700, Greg KH wrote: > On Thu, Jul 22, 2010 at 11:31:07AM -0700, Paul Menage wrote: > > On Thu, Jul 22, 2010 at 11:26 AM, Greg KH wrote: > > > We really shouldn't be asking userspace to create new root filesystems. > > > So follow along with all of the other in-

[Devel] Re: [PATCH] cgroupfs: create /sys/fs/cgroup to mount cgroupfs on

2010-07-22 Thread Paul Menage
On Thu, Jul 22, 2010 at 12:12 PM, Greg KH wrote: > I don't know if we want to encourage that as a mount point, do you? No. > > What are the different names you are giving to your mount points now for > cgroupfs so I can get an idea of how it is used currently? > We don't particularly care about

[Devel] Re: [PATCH] cgroupfs: create /sys/fs/cgroup to mount cgroupfs on

2010-07-22 Thread Paul Menage
On Thu, Jul 22, 2010 at 11:53 AM, Greg KH wrote: > > If you are using /dev/cgroup/ that's nice, but I don't think that people > are expecting a whole filesystem under a /dev/ subdirectory. Sure - as I said that's just for historical reasons from when we migrated from cpusets which were traditiona

[Devel] Re: [PATCH] cgroupfs: create /sys/fs/cgroup to mount cgroupfs on

2010-07-22 Thread Greg KH
On Thu, Jul 22, 2010 at 12:07:43PM -0700, Paul Menage wrote: > On Thu, Jul 22, 2010 at 11:53 AM, Greg KH wrote: > > > > If you are using /dev/cgroup/ that's nice, but I don't think that people > > are expecting a whole filesystem under a /dev/ subdirectory. > > Sure - as I said that's just for hi

[Devel] Re: [PATCH] cgroupfs: create /sys/fs/cgroup to mount cgroupfs on

2010-07-22 Thread Greg KH
On Thu, Jul 22, 2010 at 11:44:50AM -0700, Paul Menage wrote: > On Thu, Jul 22, 2010 at 11:36 AM, Greg KH wrote: > > > > Really?  I see systems mounting it at /cgroups/ in the filesystem today. > > Sure, it *can* be mounted as a single instance, but you then lose > flexibility. E.g. at Google we w

[Devel] Re: [PATCH] cgroupfs: create /sys/fs/cgroup to mount cgroupfs on

2010-07-22 Thread Paul Menage
On Thu, Jul 22, 2010 at 11:36 AM, Greg KH wrote: > > Really?  I see systems mounting it at /cgroups/ in the filesystem today. Sure, it *can* be mounted as a single instance, but you then lose flexibility. E.g. at Google we want to have a different hierarchy for the CPU subsystem (with the tree gr

[Devel] Re: [PATCH] cgroupfs: create /sys/fs/cgroup to mount cgroupfs on

2010-07-22 Thread Greg KH
On Thu, Jul 22, 2010 at 11:31:07AM -0700, Paul Menage wrote: > On Thu, Jul 22, 2010 at 11:26 AM, Greg KH wrote: > > We really shouldn't be asking userspace to create new root filesystems. > > So follow along with all of the other in-kernel filesystems, and provide > > a mount point in sysfs. > > >

[Devel] Re: [PATCH] cgroupfs: create /sys/fs/cgroup to mount cgroupfs on

2010-07-22 Thread Paul Menage
On Thu, Jul 22, 2010 at 11:26 AM, Greg KH wrote: > We really shouldn't be asking userspace to create new root filesystems. > So follow along with all of the other in-kernel filesystems, and provide > a mount point in sysfs. > > For cgroupfs, this should be in /sys/fs/cgroup/  This change provides