[Devel] Re: [PATCH -mmotm 3/4] memcg: dirty pages accounting and limiting infrastructure

2010-03-30 Thread Andrea Righi
On Mon, Mar 08, 2010 at 05:31:00PM +0900, KAMEZAWA Hiroyuki wrote: > On Mon, 8 Mar 2010 17:07:11 +0900 > Daisuke Nishimura wrote: > > > On Mon, 8 Mar 2010 11:37:11 +0900, KAMEZAWA Hiroyuki > > wrote: > > > On Mon, 8 Mar 2010 11:17:24 +0900 > > > Daisuke Nishimura wrote: > > > > > > > > But II

[Devel] Re: [PATCH -mmotm 3/4] memcg: dirty pages accounting and limiting infrastructure

2010-03-30 Thread Andrea Righi
On Mon, Mar 08, 2010 at 05:07:11PM +0900, Daisuke Nishimura wrote: > On Mon, 8 Mar 2010 11:37:11 +0900, KAMEZAWA Hiroyuki > wrote: > > On Mon, 8 Mar 2010 11:17:24 +0900 > > Daisuke Nishimura wrote: > > > > > > But IIRC, clear_writeback is done under treelock No ? > > > > > > > The place wh

[Devel] Re: [PATCH -mmotm 3/4] memcg: dirty pages accounting and limiting infrastructure

2010-03-30 Thread Andrea Righi
On Fri, Mar 05, 2010 at 10:58:55AM +0900, KAMEZAWA Hiroyuki wrote: > On Fri, 5 Mar 2010 10:12:34 +0900 > Daisuke Nishimura wrote: > > > On Thu, 4 Mar 2010 11:40:14 +0100, Andrea Righi wrote: > > > Infrastructure to account dirty pages per cgroup and add dirty limit > > > static int mem_cgroup_

[Devel] Re: [PATCH -mmotm 3/4] memcg: dirty pages accounting and limiting infrastructure

2010-03-30 Thread Andrea Righi
On Fri, Mar 05, 2010 at 10:12:34AM +0900, Daisuke Nishimura wrote: > On Thu, 4 Mar 2010 11:40:14 +0100, Andrea Righi wrote: > > Infrastructure to account dirty pages per cgroup and add dirty limit > > interfaces in the cgroupfs: > > > > - Direct write-out: memory.dirty_ratio, memory.dirty_bytes

[Devel] Re: [PATCH -mmotm 3/4] memcg: dirty pages accounting and limiting infrastructure

2010-03-08 Thread Daisuke Nishimura
On Tue, 9 Mar 2010 09:20:54 +0900, KAMEZAWA Hiroyuki wrote: > On Tue, 9 Mar 2010 09:18:45 +0900 > Daisuke Nishimura wrote: > > > On Mon, 8 Mar 2010 17:31:00 +0900, KAMEZAWA Hiroyuki > > wrote: > > > On Mon, 8 Mar 2010 17:07:11 +0900 > > > Daisuke Nishimura wrote: > > > > Hmm...accepatable ?

[Devel] Re: [PATCH -mmotm 3/4] memcg: dirty pages accounting and limiting infrastructure

2010-03-08 Thread KAMEZAWA Hiroyuki
On Tue, 9 Mar 2010 09:18:45 +0900 Daisuke Nishimura wrote: > On Mon, 8 Mar 2010 17:31:00 +0900, KAMEZAWA Hiroyuki > wrote: > > On Mon, 8 Mar 2010 17:07:11 +0900 > > Daisuke Nishimura wrote: > > Hmm...accepatable ? (sounds it's in error-range) > > > > BTW, why local_irq_disable() ? > > local

[Devel] Re: [PATCH -mmotm 3/4] memcg: dirty pages accounting and limiting infrastructure

2010-03-08 Thread KAMEZAWA Hiroyuki
On Tue, 9 Mar 2010 01:12:52 +0100 Andrea Righi wrote: > On Mon, Mar 08, 2010 at 05:31:00PM +0900, KAMEZAWA Hiroyuki wrote: > > On Mon, 8 Mar 2010 17:07:11 +0900 > > Daisuke Nishimura wrote: > > > > > On Mon, 8 Mar 2010 11:37:11 +0900, KAMEZAWA Hiroyuki > > > wrote: > > > > On Mon, 8 Mar 2010

[Devel] Re: [PATCH -mmotm 3/4] memcg: dirty pages accounting and limiting infrastructure

2010-03-08 Thread Daisuke Nishimura
On Mon, 8 Mar 2010 17:31:00 +0900, KAMEZAWA Hiroyuki wrote: > On Mon, 8 Mar 2010 17:07:11 +0900 > Daisuke Nishimura wrote: > > > On Mon, 8 Mar 2010 11:37:11 +0900, KAMEZAWA Hiroyuki > > wrote: > > > On Mon, 8 Mar 2010 11:17:24 +0900 > > > Daisuke Nishimura wrote: > > > > > > > > But IIRC, c

[Devel] Re: [PATCH -mmotm 3/4] memcg: dirty pages accounting and limiting infrastructure

2010-03-08 Thread KAMEZAWA Hiroyuki
On Mon, 8 Mar 2010 17:07:11 +0900 Daisuke Nishimura wrote: > On Mon, 8 Mar 2010 11:37:11 +0900, KAMEZAWA Hiroyuki > wrote: > > On Mon, 8 Mar 2010 11:17:24 +0900 > > Daisuke Nishimura wrote: > > > > > > But IIRC, clear_writeback is done under treelock No ? > > > > > > > The place where NR

[Devel] Re: [PATCH -mmotm 3/4] memcg: dirty pages accounting and limiting infrastructure

2010-03-08 Thread Daisuke Nishimura
On Mon, 8 Mar 2010 11:37:11 +0900, KAMEZAWA Hiroyuki wrote: > On Mon, 8 Mar 2010 11:17:24 +0900 > Daisuke Nishimura wrote: > > > > But IIRC, clear_writeback is done under treelock No ? > > > > > The place where NR_WRITEBACK is updated is out of tree_lock. > > > >1311 int test_clear_pa

[Devel] Re: [PATCH -mmotm 3/4] memcg: dirty pages accounting and limiting infrastructure

2010-03-07 Thread KAMEZAWA Hiroyuki
On Mon, 8 Mar 2010 11:17:24 +0900 Daisuke Nishimura wrote: > > But IIRC, clear_writeback is done under treelock No ? > > > The place where NR_WRITEBACK is updated is out of tree_lock. > >1311 int test_clear_page_writeback(struct page *page) >1312 { >1313 struct address_s

[Devel] Re: [PATCH -mmotm 3/4] memcg: dirty pages accounting and limiting infrastructure

2010-03-07 Thread Daisuke Nishimura
On Mon, 8 Mar 2010 10:56:41 +0900, KAMEZAWA Hiroyuki wrote: > On Mon, 8 Mar 2010 10:44:47 +0900 > Daisuke Nishimura wrote: > > > > +/* > > > + * mem_cgroup_update_page_stat_locked() - update memcg file cache's > > > accounting > > > + * @page:the page involved in a file cache operation

[Devel] Re: [PATCH -mmotm 3/4] memcg: dirty pages accounting and limiting infrastructure

2010-03-07 Thread KAMEZAWA Hiroyuki
On Mon, 8 Mar 2010 10:44:47 +0900 Daisuke Nishimura wrote: > > +/* > > + * mem_cgroup_update_page_stat_locked() - update memcg file cache's > > accounting > > + * @page: the page involved in a file cache operation. > > + * @idx: the particular file cache statistic. > > + * @charge:tru

[Devel] Re: [PATCH -mmotm 3/4] memcg: dirty pages accounting and limiting infrastructure

2010-03-07 Thread Daisuke Nishimura
> +/* > + * mem_cgroup_update_page_stat_locked() - update memcg file cache's > accounting > + * @page:the page involved in a file cache operation. > + * @idx: the particular file cache statistic. > + * @charge: true to increment, false to decrement the statistic specified > + *

[Devel] Re: [PATCH -mmotm 3/4] memcg: dirty pages accounting and limiting infrastructure

2010-03-04 Thread Balbir Singh
* KAMEZAWA Hiroyuki [2010-03-05 10:58:55]: > On Fri, 5 Mar 2010 10:12:34 +0900 > Daisuke Nishimura wrote: > > > On Thu, 4 Mar 2010 11:40:14 +0100, Andrea Righi wrote: > > > Infrastructure to account dirty pages per cgroup and add dirty limit > > > static int mem_cgroup_count_children_cb(stru

[Devel] Re: [PATCH -mmotm 3/4] memcg: dirty pages accounting and limiting infrastructure

2010-03-04 Thread KAMEZAWA Hiroyuki
On Fri, 5 Mar 2010 10:12:34 +0900 Daisuke Nishimura wrote: > On Thu, 4 Mar 2010 11:40:14 +0100, Andrea Righi wrote: > > Infrastructure to account dirty pages per cgroup and add dirty limit > > static int mem_cgroup_count_children_cb(struct mem_cgroup *mem, void *data) > > { > > int *val =

[Devel] Re: [PATCH -mmotm 3/4] memcg: dirty pages accounting and limiting infrastructure

2010-03-04 Thread Daisuke Nishimura
On Thu, 4 Mar 2010 11:40:14 +0100, Andrea Righi wrote: > Infrastructure to account dirty pages per cgroup and add dirty limit > interfaces in the cgroupfs: > > - Direct write-out: memory.dirty_ratio, memory.dirty_bytes > > - Background write-out: memory.dirty_background_ratio, > memory.dirty

[Devel] Re: [PATCH -mmotm 3/4] memcg: dirty pages accounting and limiting infrastructure

2010-03-04 Thread Kirill A. Shutemov
On Thu, Mar 4, 2010 at 12:40 PM, Andrea Righi wrote: > Infrastructure to account dirty pages per cgroup and add dirty limit > interfaces in the cgroupfs: > >  - Direct write-out: memory.dirty_ratio, memory.dirty_bytes > >  - Background write-out: memory.dirty_background_ratio, > memory.dirty_back