[Devel] Re: [PATCH 1/3] cgroup : add clone_children control file

2010-09-07 Thread Daniel Lezcano
On 09/07/2010 11:22 PM, Paul Menage wrote: > On Tue, Sep 7, 2010 at 2:13 PM, Daniel Lezcano wrote: > >> The clone_children option behaves like the release-agent mount option no ? >> > Not quite, since it can be controlled on a per-cgroup basis. > > >> We can mount with a specific rel

[Devel] Re: [PATCH 1/3] cgroup : add clone_children control file

2010-09-07 Thread Paul Menage
On Tue, Sep 7, 2010 at 2:13 PM, Daniel Lezcano wrote: > > The clone_children option behaves like the release-agent mount option no ? Not quite, since it can be controlled on a per-cgroup basis. > We can mount with a specific release agent and change it at runtime. IMHO it > would be better to gi

[Devel] Re: [PATCH 1/3] cgroup : add clone_children control file

2010-09-07 Thread Daniel Lezcano
On 09/07/2010 10:26 PM, Paul Menage wrote: > On Tue, Sep 7, 2010 at 1:23 PM, Daniel Lezcano wrote: > >>> This bit is awkward - you're storing the original value of the >>> clone_children flag to report in the mount options, but this isn't >>> necessarily the current state. Might it be better t

[Devel] Re: [PATCH 1/3] cgroup : add clone_children control file

2010-09-07 Thread Paul Menage
On Tue, Sep 7, 2010 at 1:23 PM, Daniel Lezcano wrote: >> This bit is awkward - you're storing the original value of the >> clone_children flag to report in the mount options, but this isn't >> necessarily the current state. Might it be better to not store this >> and just report the current value

[Devel] Re: [PATCH 1/3] cgroup : add clone_children control file

2010-09-07 Thread Daniel Lezcano
On 09/07/2010 09:34 PM, Paul Menage wrote: > On Sat, Sep 4, 2010 at 12:31 AM, Daniel Lezcano > wrote: > >> @@ -229,6 +229,7 @@ inline int cgroup_is_removed(const struct cgroup *cgrp) >> /* bits in struct cgroupfs_root flags field */ >> enum { >> ROOT_NOPREFIX, /* mounted subsystem

[Devel] Re: [PATCH 1/3] cgroup : add clone_children control file

2010-09-07 Thread Paul Menage
On Sat, Sep 4, 2010 at 12:31 AM, Daniel Lezcano wrote: > @@ -229,6 +229,7 @@ inline int cgroup_is_removed(const struct cgroup *cgrp) >  /* bits in struct cgroupfs_root flags field */ >  enum { >        ROOT_NOPREFIX, /* mounted subsystems have no named prefix */ > +       ROOT_CLONE_CHILDREN, /* m

[Devel] Re: [PATCH 1/3] cgroup : add clone_children control file

2010-08-03 Thread Li Zefan
Cc: Andrew Morton (to pick up those patches) Serge E. Hallyn wrote: > This patch is sent as an answer to a previous thread around the ns_cgroup. > > https://lists.linux-foundation.org/pipermail/containers/2009-June/018627.html > > It adds a control file 'clone_children' for a cgroup. > This cont