Alan Cox [EMAIL PROTECTED] wrote:
| Ok I'm happy with this patch set. It appears correct as far as the tty
| side is concerned, it looks sensible in terms of interface with the
| devpts layer.
Alan, Peter: Thanks for review and feedback.
|
| Really depends what everyone else thinks about the
Serge E. Hallyn [EMAIL PROTECTED] wrote:
| No luck yet finding my random lockup (it *should* be obvious), but do
| notice that you ignore the return value of get_sb_single() in
| init_pts_mount(). Certainly that should be fixed.
Good catch. Will fix it. Thanks,
Suka
Serge E. Hallyn [EMAIL PROTECTED] wrote:
| + Or, in general, container-startup scripts should use:
| +
| + mount -t devpts -o newinstance -o ptmxmode 0666 devpts /dev/pts
|
| ptmxmode=0666
|
| That is, of course, crucial, this being the documentation :)
Agree :-)
Quoting [EMAIL PROTECTED] ([EMAIL PROTECTED]):
From 6d2fe9386880157f871667077db3180e9f0083a1 Mon Sep 17 00:00:00 2001
From: Sukadev Bhattiprolu [EMAIL PROTECTED]
Date: Tue, 9 Sep 2008 10:43:50 -0700
Subject: [PATCH 10/10] Document usage of multiple-instances of devpts
Signed-off-by:
Quoting [EMAIL PROTECTED] ([EMAIL PROTECTED]):
Alan Cox [EMAIL PROTECTED] wrote:
| Ok I'm happy with this patch set. It appears correct as far as the tty
| side is concerned, it looks sensible in terms of interface with the
| devpts layer.
Alan, Peter: Thanks for review and feedback.
|
Quoting [EMAIL PROTECTED] ([EMAIL PROTECTED]):
Alan Cox [EMAIL PROTECTED] wrote:
| Ok I'm happy with this patch set. It appears correct as far as the tty
| side is concerned, it looks sensible in terms of interface with the
| devpts layer.
Alan, Peter: Thanks for review and feedback.
|
Quoting Serge E. Hallyn ([EMAIL PROTECTED]):
Quoting [EMAIL PROTECTED] ([EMAIL PROTECTED]):
Alan Cox [EMAIL PROTECTED] wrote:
| Ok I'm happy with this patch set. It appears correct as far as the tty
| side is concerned, it looks sensible in terms of interface with the
| devpts layer.
Ok I'm happy with this patch set. It appears correct as far as the tty
side is concerned, it looks sensible in terms of interface with the
devpts layer.
Really depends what everyone else thinks about the vfs bits and the API
___
Containers mailing list
Alan Cox wrote:
Ok I'm happy with this patch set. It appears correct as far as the tty
side is concerned, it looks sensible in terms of interface with the
devpts layer.
Really depends what everyone else thinks about the vfs bits and the API
The last version looks fine to me. To be fair, I
