Re: [ovirt-devel] make check on master fails due to UnicodeDecodeError

2018-04-11 Thread Shani Leviim
HI, *Regards,* *Shani Leviim* On Tue, Apr 10, 2018 at 5:32 PM, Nir Soffer wrote: > On Tue, Apr 10, 2018 at 5:21 PM Shani Leviim wrote: > >> Hi, >> >> Yes, I did clean the root directory but it didn't solve the issue. >> I'm currently running the tests on fedora27, using python version 2.1.1

Re: [ovirt-devel] [ OST Failure Report ] [ oVirt 4.2 ] [ 2018-04-04 ] [006_migrations.prepare_migration_attachments_ipv6]

2018-04-11 Thread Alona Kaplan
Hi Ravi, Added comments to the patch. Regarding the lock - the lock shouldn't be released until the command and its callbacks were finished. The treatment of a delayed failure should be under lock since it doesn't make sense to take care of the failure while other monitoring process is possibly r

Re: [ovirt-devel] dynamic ownership changes

2018-04-11 Thread Eyal Edri
Please make sure to run as much OST suites on this patch as possible before merging ( using 'ci please build' ) On Tue, Apr 10, 2018 at 4:09 PM, Martin Polednik wrote: > Hey, > > I've created a patch[0] that is finally able to activate libvirt's > dynamic_ownership for VDSM while not negatively

Re: [ovirt-devel] dynamic ownership changes

2018-04-11 Thread Nir Soffer
On Wed, Apr 11, 2018 at 12:31 PM Eyal Edri wrote: > Please make sure to run as much OST suites on this patch as possible > before merging ( using 'ci please build' ) > But note that OST is not a way to verify the patch. Such changes require testing with all storage types we support. Nir On Tu

Re: [ovirt-devel] dynamic ownership changes

2018-04-11 Thread Eyal Edri
On Wed, Apr 11, 2018 at 12:34 PM, Nir Soffer wrote: > On Wed, Apr 11, 2018 at 12:31 PM Eyal Edri wrote: > >> Please make sure to run as much OST suites on this patch as possible >> before merging ( using 'ci please build' ) >> > > But note that OST is not a way to verify the patch. > > Such chan

Re: [ovirt-devel] [ OST Failure Report ] [ oVirt 4.2 ] [ 2018-04-04 ] [006_migrations.prepare_migration_attachments_ipv6]

2018-04-11 Thread Alona Kaplan
On Tue, Apr 10, 2018 at 6:52 PM, Gal Ben Haim wrote: > I'm seeing the same error in [1], during 006_migrations.migrate_vm. > > [1] http://jenkins.ovirt.org/job/ovirt-4.2_change-queue-tester/1650/ > Seems like another bug. The migration failed since for some reason the vm is already defined on th

Re: [ovirt-devel] [ OST Failure Report ] [ oVirt 4.2 ] [ 2018-04-04 ] [006_migrations.prepare_migration_attachments_ipv6]

2018-04-11 Thread Arik Hadas
On Wed, Apr 11, 2018 at 12:45 PM, Alona Kaplan wrote: > > > On Tue, Apr 10, 2018 at 6:52 PM, Gal Ben Haim wrote: > >> I'm seeing the same error in [1], during 006_migrations.migrate_vm. >> >> [1] http://jenkins.ovirt.org/job/ovirt-4.2_change-queue-tester/1650/ >> > > Seems like another bug. The

Re: [ovirt-devel] make check on master fails due to UnicodeDecodeError

2018-04-11 Thread Shani Leviim
A patch was uploaded: https://gerrit.ovirt.org/#/c/90093/ *Regards,* *Shani Leviim* On Wed, Apr 11, 2018 at 9:59 AM, Shani Leviim wrote: > HI, > > > > *Regards,* > > *Shani Leviim* > > On Tue, Apr 10, 2018 at 5:32 PM, Nir Soffer wrote: > >> On Tue, Apr 10, 2018 at 5:21 PM Shani Leviim wrote

Re: [ovirt-devel] dynamic ownership changes

2018-04-11 Thread Nir Soffer
On Wed, Apr 11, 2018 at 12:38 PM Eyal Edri wrote: > On Wed, Apr 11, 2018 at 12:34 PM, Nir Soffer wrote: > >> On Wed, Apr 11, 2018 at 12:31 PM Eyal Edri wrote: >> >>> Please make sure to run as much OST suites on this patch as possible >>> before merging ( using 'ci please build' ) >>> >> >> But

Re: [ovirt-devel] dynamic ownership changes

2018-04-11 Thread Martin Polednik
On 11/04/18 12:27 +, Nir Soffer wrote: On Wed, Apr 11, 2018 at 12:38 PM Eyal Edri wrote: On Wed, Apr 11, 2018 at 12:34 PM, Nir Soffer wrote: On Wed, Apr 11, 2018 at 12:31 PM Eyal Edri wrote: Please make sure to run as much OST suites on this patch as possible before merging ( using '

Re: [ovirt-devel] dynamic ownership changes

2018-04-11 Thread Nir Soffer
On Wed, Apr 11, 2018 at 3:30 PM Martin Polednik wrote: > On 11/04/18 12:27 +, Nir Soffer wrote: > >On Wed, Apr 11, 2018 at 12:38 PM Eyal Edri wrote: > > > >> On Wed, Apr 11, 2018 at 12:34 PM, Nir Soffer > wrote: > >> > >>> On Wed, Apr 11, 2018 at 12:31 PM Eyal Edri wrote: > >>> > Plea

Re: [ovirt-devel] [ OST Failure Report ] [ oVirt 4.2 ] [ 2018-04-04 ] [006_migrations.prepare_migration_attachments_ipv6]

2018-04-11 Thread Milan Zamazal
Arik Hadas writes: > On Wed, Apr 11, 2018 at 12:45 PM, Alona Kaplan wrote: > >> >> >> On Tue, Apr 10, 2018 at 6:52 PM, Gal Ben Haim wrote: >> >>> I'm seeing the same error in [1], during 006_migrations.migrate_vm. >>> >>> [1] http://jenkins.ovirt.org/job/ovirt-4.2_change-queue-tester/1650/ >>>

Re: [ovirt-devel] dynamic ownership changes

2018-04-11 Thread Yaniv Kaul
On Wed, Apr 11, 2018 at 3:27 PM, Nir Soffer wrote: > On Wed, Apr 11, 2018 at 12:38 PM Eyal Edri wrote: > >> On Wed, Apr 11, 2018 at 12:34 PM, Nir Soffer wrote: >> >>> On Wed, Apr 11, 2018 at 12:31 PM Eyal Edri wrote: >>> Please make sure to run as much OST suites on this patch as possible

Re: [ovirt-devel] dynamic ownership changes

2018-04-11 Thread Dan Kenigsberg
On Wed, Apr 11, 2018 at 12:34 PM, Nir Soffer wrote: > On Wed, Apr 11, 2018 at 12:31 PM Eyal Edri wrote: > >> Please make sure to run as much OST suites on this patch as possible >> before merging ( using 'ci please build' ) >> > > But note that OST is not a way to verify the patch. > > Such chan

Re: [ovirt-devel] dynamic ownership changes

2018-04-11 Thread Martin Polednik
On 11/04/18 16:28 +0300, Dan Kenigsberg wrote: On Wed, Apr 11, 2018 at 12:34 PM, Nir Soffer wrote: On Wed, Apr 11, 2018 at 12:31 PM Eyal Edri wrote: Please make sure to run as much OST suites on this patch as possible before merging ( using 'ci please build' ) But note that OST is not a

Re: [ovirt-devel] dynamic ownership changes

2018-04-11 Thread Elad Ben Aharon
We can test this on iSCSI, NFS and GlusterFS. As for ceph and cinder, will have to check, since usually, we don't execute our automation on them. On Wed, Apr 11, 2018 at 4:38 PM, Raz Tamir wrote: > +Elad > > On Wed, Apr 11, 2018 at 4:28 PM, Dan Kenigsberg wrote: > >> On Wed, Apr 11, 2018 at 12: