[ovirt-devel] Re: Gerrit Hooks will Start to Check for "Bug-Url" Keyword Explicitly

2019-02-06 Thread Yedidyah Bar David
On Wed, Feb 6, 2019 at 5:53 PM Nir Soffer wrote: > > On Wed, Feb 6, 2019 at 5:33 PM Greg Sheremeta wrote: >> >> On Wed, Feb 6, 2019 at 10:18 AM Anton Marchukov wrote: >>> >>> Hello All. >>> >>> Also. Based on the comments I am going to do the exact match, thus it will >>> require the following:

[ovirt-devel] Nicer URLs in jenkins

2019-02-06 Thread Nir Soffer
Jenkinks OST URLs are too ugly. When looking for OST manual job, we go to: https://jenkins.ovirt.org/view/oVirt%20system%20tests/ This should be something like: https://jenkins.ovirt.org/view/ost/ Or https://jenkins.ovirt.org/view/ovirt-system-tests Then we click on "ovirt-system-tests_manual"

[ovirt-devel] Re: imageio proxy and engine dev setup

2019-02-06 Thread Nir Soffer
On Wed, Feb 6, 2019 at 12:43 PM Greg Sheremeta wrote: > > > On Wed, Feb 6, 2019, 5:26 AM Fedor Gavrilov wrote: > >> Thanks, Roy! I will try setting it up according to what you suggested. >> Last attempt failed indeed: according to logs, both daemon and proxy >> tried establishing a connection wi

[ovirt-devel] Re: imageio proxy and engine dev setup

2019-02-06 Thread Nir Soffer
On Wed, Feb 6, 2019 at 12:24 PM Fedor Gavrilov wrote: First, please keep Daniel in the CC, this is your best chance to get a help on this, and a good practice for most issues :-) Thanks, Roy! I will try setting it up according to what you suggested. > Last attempt failed indeed: according to log

[ovirt-devel] Re: Gerrit Hooks will Start to Check for "Bug-Url" Keyword Explicitly

2019-02-06 Thread Nir Soffer
On Wed, Feb 6, 2019 at 5:33 PM Greg Sheremeta wrote: > On Wed, Feb 6, 2019 at 10:18 AM Anton Marchukov > wrote: > >> Hello All. >> >> Also. Based on the comments I am going to do the exact match, thus it >> will require the following: >> >> 1. "Bug-Url:" should be at the beginning of the new lin

[ovirt-devel] Re: Gerrit Hooks will Start to Check for "Bug-Url" Keyword Explicitly

2019-02-06 Thread Greg Sheremeta
On Wed, Feb 6, 2019 at 10:18 AM Anton Marchukov wrote: > Hello All. > > Also. Based on the comments I am going to do the exact match, thus it will > require the following: > > 1. "Bug-Url:" should be at the beginning of the new line with no spaces > allowed in between. > 2. No space is allowed be

[ovirt-devel] Re: Gerrit Hooks will Start to Check for "Bug-Url" Keyword Explicitly

2019-02-06 Thread Anton Marchukov
Hello All. Also. Based on the comments I am going to do the exact match, thus it will require the following: 1. "Bug-Url:" should be at the beginning of the new line with no spaces allowed in between. 2. No space is allowed between "Bug-Url" and ":". 3. I will allow space characters (or tab chara

[ovirt-devel] Re: Gerrit Hooks will Start to Check for "Bug-Url" Keyword Explicitly

2019-02-06 Thread Anton Marchukov
Thanks for comments. Yeah, I think since it does not produce extra side effect over the previous behaviour in dead case just something will stop working based on the old assumptions rather than it starts moving incorrect bugs around. I have prepared a change [1], will give it some test on staging

[ovirt-devel] Re: Silent errors in storage code on Vdsm startup

2019-02-06 Thread Nir Soffer
On Wed, Feb 6, 2019 at 11:11 AM Milan Zamazal wrote: > Nir Soffer writes: > > > Even if you port entire vdsm to python 3, sanlock does not ship yet > > python 3 bindings, so you cannot have any storage except local storage, > > iso domain and export domain. > > I started working on porting sanlo

[ovirt-devel] Re: package versioning problem causing failure on CQ ovirt-master on all projects

2019-02-06 Thread Dafna Ron
On Wed, Feb 6, 2019 at 11:05 AM Barak Korren wrote: > > > בתאריך יום ד׳, 6 בפבר׳ 2019, 12:25, מאת Simone Tiraboschi ‏< > stira...@redhat.com>: > >> >> >> On Wed, Feb 6, 2019 at 11:17 AM Barak Korren wrote: >> >>> >>> >>> On Wed, 6 Feb 2019 at 11:57, Simone Tiraboschi >>> wrote: >>> >>

[ovirt-devel] Re: package versioning problem causing failure on CQ ovirt-master on all projects

2019-02-06 Thread Barak Korren
בתאריך יום ד׳, 6 בפבר׳ 2019, 12:25, מאת Simone Tiraboschi ‏< stira...@redhat.com>: > > > On Wed, Feb 6, 2019 at 11:17 AM Barak Korren wrote: > >> >> >> On Wed, 6 Feb 2019 at 11:57, Simone Tiraboschi >> wrote: >> >>> >>> >>> On Wed, Feb 6, 2019 at 10:44 AM Barak Korren wrote: >>>

[ovirt-devel] Re: imageio proxy and engine dev setup

2019-02-06 Thread Greg Sheremeta
On Wed, Feb 6, 2019, 5:26 AM Fedor Gavrilov wrote: > Thanks, Roy! I will try setting it up according to what you suggested. > Last attempt failed indeed: according to logs, both daemon and proxy tried > establishing a connection with each other with some 200 OK in logs, no > error messages but ne

[ovirt-devel] Re: Gerrit Hooks will Start to Check for "Bug-Url" Keyword Explicitly

2019-02-06 Thread Yedidyah Bar David
On Wed, Feb 6, 2019 at 12:36 PM Anton Marchukov wrote: > > Hello All. > > I have checked the hooks code. And it indeed just extracts all the links > pointing to bugzilla. This is not correct and fails when somebody just > mentions a bug in commit message. > > We are about to fix this and adjust

[ovirt-devel] Gerrit Hooks will Start to Check for "Bug-Url" Keyword Explicitly

2019-02-06 Thread Anton Marchukov
Hello All. I have checked the hooks code. And it indeed just extracts all the links pointing to bugzilla. This is not correct and fails when somebody just mentions a bug in commit message. We are about to fix this and adjust the regexp used to explicitly check for "Bug-Url" keyword. I think this

[ovirt-devel] Re: package versioning problem causing failure on CQ ovirt-master on all projects

2019-02-06 Thread Simone Tiraboschi
On Wed, Feb 6, 2019 at 11:17 AM Barak Korren wrote: > > > On Wed, 6 Feb 2019 at 11:57, Simone Tiraboschi > wrote: > >> >> >> On Wed, Feb 6, 2019 at 10:44 AM Barak Korren wrote: >> >>> >>> >>> On Wed, 6 Feb 2019 at 11:34, Simone Tiraboschi >>> wrote: >>> On Wed, Feb 6, 2019 at 10

[ovirt-devel] Re: imageio proxy and engine dev setup

2019-02-06 Thread Fedor Gavrilov
Thanks, Roy! I will try setting it up according to what you suggested. Last attempt failed indeed: according to logs, both daemon and proxy tried establishing a connection with each other with some 200 OK in logs, no error messages but nevertheless upload did not happen after all. Speaking about

[ovirt-devel] Re: package versioning problem causing failure on CQ ovirt-master on all projects

2019-02-06 Thread Barak Korren
On Wed, 6 Feb 2019 at 11:57, Simone Tiraboschi wrote: > > > On Wed, Feb 6, 2019 at 10:44 AM Barak Korren wrote: > >> >> >> On Wed, 6 Feb 2019 at 11:34, Simone Tiraboschi >> wrote: >> >>> >>> >>> On Wed, Feb 6, 2019 at 10:23 AM Barak Korren wrote: >>> On Wed, 6 Feb 2019 at 11:15,

[ovirt-devel] Re: package versioning problem causing failure on CQ ovirt-master on all projects

2019-02-06 Thread Simone Tiraboschi
On Wed, Feb 6, 2019 at 10:44 AM Barak Korren wrote: > > > On Wed, 6 Feb 2019 at 11:34, Simone Tiraboschi > wrote: > >> >> >> On Wed, Feb 6, 2019 at 10:23 AM Barak Korren wrote: >> >>> >>> >>> On Wed, 6 Feb 2019 at 11:15, Simone Tiraboschi >>> wrote: >>> On Wed, Feb 6, 2019 at 10

[ovirt-devel] Re: package versioning problem causing failure on CQ ovirt-master on all projects

2019-02-06 Thread Barak Korren
On Wed, 6 Feb 2019 at 11:34, Simone Tiraboschi wrote: > > > On Wed, Feb 6, 2019 at 10:23 AM Barak Korren wrote: > >> >> >> On Wed, 6 Feb 2019 at 11:15, Simone Tiraboschi >> wrote: >> >>> >>> >>> On Wed, Feb 6, 2019 at 10:00 AM Dan Kenigsberg >>> wrote: >>> On Wed, Feb 6, 2019 at 10:54 AM

[ovirt-devel] Re: package versioning problem causing failure on CQ ovirt-master on all projects

2019-02-06 Thread Simone Tiraboschi
On Wed, Feb 6, 2019 at 10:23 AM Barak Korren wrote: > > > On Wed, 6 Feb 2019 at 11:15, Simone Tiraboschi > wrote: > >> >> >> On Wed, Feb 6, 2019 at 10:00 AM Dan Kenigsberg wrote: >> >>> On Wed, Feb 6, 2019 at 10:54 AM Simone Tiraboschi >>> wrote: >>> > >>> > >>> > >>> > On Wed, Feb 6, 2019 at

[ovirt-devel] Re: package versioning problem causing failure on CQ ovirt-master on all projects

2019-02-06 Thread Barak Korren
On Wed, 6 Feb 2019 at 11:15, Simone Tiraboschi wrote: > > > On Wed, Feb 6, 2019 at 10:00 AM Dan Kenigsberg wrote: > >> On Wed, Feb 6, 2019 at 10:54 AM Simone Tiraboschi >> wrote: >> > >> > >> > >> > On Wed, Feb 6, 2019 at 9:45 AM Dan Kenigsberg >> wrote: >> >> >> >> On Wed, Feb 6, 2019 at 10:1

[ovirt-devel] Re: package versioning problem causing failure on CQ ovirt-master on all projects

2019-02-06 Thread Simone Tiraboschi
On Wed, Feb 6, 2019 at 10:00 AM Dan Kenigsberg wrote: > On Wed, Feb 6, 2019 at 10:54 AM Simone Tiraboschi > wrote: > > > > > > > > On Wed, Feb 6, 2019 at 9:45 AM Dan Kenigsberg wrote: > >> > >> On Wed, Feb 6, 2019 at 10:16 AM Simone Tiraboschi > wrote: > >> > > >> > > >> > > >> > On Tue, Feb 5

[ovirt-devel] Re: package versioning problem causing failure on CQ ovirt-master on all projects

2019-02-06 Thread Barak Korren
On Wed, 6 Feb 2019 at 11:00, Dan Kenigsberg wrote: > On Wed, Feb 6, 2019 at 10:54 AM Simone Tiraboschi > wrote: > > > > > > > > On Wed, Feb 6, 2019 at 9:45 AM Dan Kenigsberg wrote: > >> > >> On Wed, Feb 6, 2019 at 10:16 AM Simone Tiraboschi > wrote: > >> > > >> > > >> > > >> > On Tue, Feb 5, 2

[ovirt-devel] Re: Silent errors in storage code on Vdsm startup

2019-02-06 Thread Milan Zamazal
Nir Soffer writes: > Even if you port entire vdsm to python 3, sanlock does not ship yet > python 3 bindings, so you cannot have any storage except local storage, > iso domain and export domain. I started working on porting sanlock Python bindings to Python 3 in order to be able to access storag

[ovirt-devel] Re: package versioning problem causing failure on CQ ovirt-master on all projects

2019-02-06 Thread Dan Kenigsberg
On Wed, Feb 6, 2019 at 10:54 AM Simone Tiraboschi wrote: > > > > On Wed, Feb 6, 2019 at 9:45 AM Dan Kenigsberg wrote: >> >> On Wed, Feb 6, 2019 at 10:16 AM Simone Tiraboschi >> wrote: >> > >> > >> > >> > On Tue, Feb 5, 2019 at 7:07 PM Dafna Ron wrote: >> >> >> >> Hi, >> >> >> >> Please note th

[ovirt-devel] Re: package versioning problem causing failure on CQ ovirt-master on all projects

2019-02-06 Thread Simone Tiraboschi
On Wed, Feb 6, 2019 at 9:45 AM Dan Kenigsberg wrote: > On Wed, Feb 6, 2019 at 10:16 AM Simone Tiraboschi > wrote: > > > > > > > > On Tue, Feb 5, 2019 at 7:07 PM Dafna Ron wrote: > >> > >> Hi, > >> > >> Please note that ovirt-ansible-hosted-engine-setup has a versioning > problem with the packag

[ovirt-devel] Re: imageio proxy and engine dev setup

2019-02-06 Thread Roy Golan
On Tue, 5 Feb 2019 at 20:58, Nir Soffer wrote: > On Tue, Feb 5, 2019 at 6:46 PM Fedor Gavrilov wrote: > >> Right! >> >> Oh, it just occured to me that imageio prject is two parts and they >> expect me to be in proxy/ directory in the installation docs. >> There is indeed a make-install goal ther

[ovirt-devel] Re: package versioning problem causing failure on CQ ovirt-master on all projects

2019-02-06 Thread Dan Kenigsberg
On Wed, Feb 6, 2019 at 10:16 AM Simone Tiraboschi wrote: > > > > On Tue, Feb 5, 2019 at 7:07 PM Dafna Ron wrote: >> >> Hi, >> >> Please note that ovirt-ansible-hosted-engine-setup has a versioning problem >> with the package and is causing bootstrap to fail for upgrade suite [1] >> >> This is ef

[ovirt-devel] Re: package versioning problem causing failure on CQ ovirt-master on all projects

2019-02-06 Thread Simone Tiraboschi
On Tue, Feb 5, 2019 at 7:07 PM Dafna Ron wrote: > Hi, > > Please note that ovirt-ansible-hosted-engine-setup has a versioning > problem with the package and is causing bootstrap to fail for upgrade suite > [1] > > This is effecting all projects, its been reported to the developers and > should be