Re: [ovirt-devel] [VDSM] vdsm_master_verify-error-codes_created running on master - why?

2016-07-19 Thread Dan Kenigsberg
On Wed, Jul 20, 2016 at 01:51:51AM +0300, Nir Soffer wrote: > On Tue, Jul 19, 2016 at 6:20 PM, Eyal Edri wrote: > > And also, feel free to move it to check-patch.sh code as well. > > Including this in vdsm seem like the best option. > > Can you point me to the source of this job? > > > > > On T

Re: [ovirt-devel] [VDSM] vdsm_master_verify-error-codes_created running on master - why?

2016-07-19 Thread Eyal Edri
It wasn't yamelized until recently, so you can see the open patch for it at [1]. I guess you can checkout the patch to jenkins repo and take the script from there. If you're moving it to vdsm repo, I'll abandon this patch, please let me know. [1] https://gerrit.ovirt.org/#/c/60630/2 On Wed, Jul 2

Re: [ovirt-devel] [VDSM] vdsm_master_verify-error-codes_created running on master - why?

2016-07-19 Thread Nir Soffer
On Tue, Jul 19, 2016 at 6:20 PM, Eyal Edri wrote: > And also, feel free to move it to check-patch.sh code as well. Including this in vdsm seem like the best option. Can you point me to the source of this job? > > On Tue, Jul 19, 2016 at 6:19 PM, Eyal Edri wrote: >> >> This isn't new, it was ru

Re: [ovirt-devel] [VDSM] vdsm_master_verify-error-codes_created running on master - why?

2016-07-19 Thread Eyal Edri
And also, feel free to move it to check-patch.sh code as well. On Tue, Jul 19, 2016 at 6:19 PM, Eyal Edri wrote: > This isn't new, it was running for a few years, just on old jenkins, > Maybe you just noticed it. > > Allon & Dan are familiar with that job and it already found in the past > real

Re: [ovirt-devel] [VDSM] vdsm_master_verify-error-codes_created running on master - why?

2016-07-19 Thread Eyal Edri
This isn't new, it was running for a few years, just on old jenkins, Maybe you just noticed it. Allon & Dan are familiar with that job and it already found in the past real issues. If you want to remove/disable it, I have no problem - just make sure you're synced with all VDSM people that requeste

[ovirt-devel] [VDSM] vdsm_master_verify-error-codes_created running on master - why?

2016-07-19 Thread Nir Soffer
Hi all, Since yesterday, vdsm_master_verify-error-codes_created job is running on master. I guess that this was a unintended change in jenkins - please revert this change. If someone want to add a job for vdsm master, it must be approved by vdsm maintainers first. The best would be to run every