Re: [ovirt-devel] [vdsm] pep8 issue

2014-05-15 Thread Dan Kenigsberg
On Thu, May 15, 2014 at 05:21:48PM +0200, Matthias Runge wrote: > On Thu, May 15, 2014 at 10:15:33AM +0100, Dan Kenigsberg wrote: > > > This update is pushed to updates-testing (for f20), though due the system > > > maintenance currently running, there was no mail sent about that. > > > Please leav

Re: [ovirt-devel] [vdsm] pep8 issue

2014-05-15 Thread Matthias Runge
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On Thu, May 15, 2014 at 10:15:33AM +0100, Dan Kenigsberg wrote: > > This update is pushed to updates-testing (for f20), though due the system > > maintenance currently running, there was no mail sent about that. > > Please leave feedback on bodhi. Than

Re: [ovirt-devel] [vdsm] pep8 issue

2014-05-15 Thread Dan Kenigsberg
On Wed, May 14, 2014 at 04:33:13PM +0200, Matthias Runge wrote: > On Tue, May 13, 2014 at 06:15:31PM -0300, Amador Pahim wrote: > > >> > > >> I'm using python-pep8-1.5.4-1.fc20.noarch > > > > > > It seems like a bug in pep8 tool, and I see that it does not reproduce > > > with v1.5.6 thereof. > > >

Re: [ovirt-devel] [vdsm] pep8 issue

2014-05-14 Thread Matthias Runge
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On Tue, May 13, 2014 at 06:15:31PM -0300, Amador Pahim wrote: > >> > >> I'm using python-pep8-1.5.4-1.fc20.noarch > > > > It seems like a bug in pep8 tool, and I see that it does not reproduce > > with v1.5.6 thereof. > > > > I'm adding Matthias who ma

Re: [ovirt-devel] [vdsm] pep8 issue

2014-05-14 Thread Matthias Runge
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On Tue, May 13, 2014 at 06:15:31PM -0300, Amador Pahim wrote: > On Tue, May 13, 2014 at 5:43 PM, Dan Kenigsberg wrote: > >> > >> I'm using python-pep8-1.5.4-1.fc20.noarch > > > > It seems like a bug in pep8 tool, and I see that it does not reproduce >

Re: [ovirt-devel] [vdsm] pep8 issue

2014-05-13 Thread Amador Pahim
On Tue, May 13, 2014 at 5:43 PM, Dan Kenigsberg wrote: > On Tue, May 13, 2014 at 05:22:15PM -0300, Amador Pahim wrote: >> Building vdsm/master in F20, I've got: >> >> ./vdsm/virt/migration.py:223:19: E225 missing whitespace around operator >> >> In vdsm/virt/migration.py: >> >> 218 e.err =

[ovirt-devel] [vdsm] pep8 issue

2014-05-13 Thread Amador Pahim
Building vdsm/master in F20, I've got: ./vdsm/virt/migration.py:223:19: E225 missing whitespace around operator In vdsm/virt/migration.py: 223 -1, -1) # int1, int2$ pep8 is not accepting the negative integer. Instead, it is handling the minus sign as

Re: [ovirt-devel] [vdsm] pep8 issue

2014-05-13 Thread Dan Kenigsberg
On Tue, May 13, 2014 at 05:22:15PM -0300, Amador Pahim wrote: > Building vdsm/master in F20, I've got: > > ./vdsm/virt/migration.py:223:19: E225 missing whitespace around operator > > In vdsm/virt/migration.py: > > 218 e.err = (libvirt.VIR_ERR_OPERATION_ABORTED, # error code$ > 219