Re: [ovirt-devel] Abusing injection and DB access

2017-04-24 Thread Roy Golan
On Thu, Apr 6, 2017 at 11:26 AM Roy Golan wrote: > On Wed, Apr 5, 2017 at 11:34 PM Moti Asayag wrote: > >> On Wed, Apr 5, 2017 at 11:17 PM, Roy Golan wrote: >> >> >> >> On Wed, Apr 5, 2017 at 9:06 PM Moti Asayag

Re: [ovirt-devel] Abusing injection and DB access

2017-04-05 Thread Tal Nisan
Took the storage ones, expect them early last week or right after the holiday. On Wed, Apr 5, 2017 at 11:34 PM, Moti Asayag wrote: > > > On Wed, Apr 5, 2017 at 11:17 PM, Roy Golan wrote: > >> >> >> On Wed, Apr 5, 2017 at 9:06 PM Moti Asayag

Re: [ovirt-devel] Abusing injection and DB access

2017-04-05 Thread Moti Asayag
On Wed, Apr 5, 2017 at 11:17 PM, Roy Golan wrote: > > > On Wed, Apr 5, 2017 at 9:06 PM Moti Asayag wrote: > >> Hi All, >> >> ATM, there are 78 occurrences of "Injector.injectMembers(new >> AuditLogableBase())" in ovirt-engine project, which their main

Re: [ovirt-devel] Abusing injection and DB access

2017-04-05 Thread Moti Asayag
Here is a list of cases which misuse injection. Please assign yourself and update the status (assigned/published/merged) https://docs.google.com/spreadsheets/d/1leEk0EYZgQPsG_Xddlk7FctBYYm4WOU8BsoETGR2xtQ/edit?usp=sharing Thanks, Moti On Wed, Apr 5, 2017 at 9:05 PM, Moti Asayag

[ovirt-devel] Abusing injection and DB access

2017-04-05 Thread Moti Asayag
Hi All, ATM, there are 78 occurrences of "Injector.injectMembers(new AuditLogableBase())" in ovirt-engine project, which their main purpose is to ease the resolve of the placeholders of the audit log message while logging an event. For instance AuditLogType.MAC_ADDRESS_IS_EXTERNAL is being used