Re: [ovirt-devel] Line of death for tests

2017-03-16 Thread Allon Mureinik
Issue reported on Mockito: https://github.com/mockito/mockito/issues/990 On Thu, Mar 16, 2017 at 8:36 PM, Allon Mureinik wrote: > The root cause seems to be MigrateVmCommandTest and its relation to > MigrateVmCommand. > > A common misconception is that if an object is annotated with > @InjectMo

Re: [ovirt-devel] Line of death for tests

2017-03-16 Thread Allon Mureinik
The root cause seems to be MigrateVmCommandTest and its relation to MigrateVmCommand. A common misconception is that if an object is annotated with @InjectMocks, Mockito will inject its @Mocks and @Spys to fields annotated with @Inject. This is, as noted, not correct - Mockito will attempt to injc

[ovirt-devel] Line of death for tests

2017-03-16 Thread Shmuel Melamud
Hi! I've found yesterday a very strange bug, most likely in Mockito. Hard to believe it really happens, but I've reproduced it in different environmentы and several revisions of oVirt master. I've added the following line into MigrateVmCommand: private Integer actualDowntime; +private O