Re: [ovirt-devel] Useless AddVmPoolCommand class

2015-03-30 Thread Michal Skrivanek
On Mar 30, 2015, at 12:35 , Omer Frenkel wrote: > > > - Original Message - >> From: "Shmuel Melamud" >> To: devel@ovirt.org >> Sent: Sunday, March 29, 2015 5:45:52 PM >> Subject: [ovirt-devel] Useless AddVmPoolCommand class >> >

Re: [ovirt-devel] Useless AddVmPoolCommand class

2015-03-30 Thread Omer Frenkel
- Original Message - > From: "Shmuel Melamud" > To: devel@ovirt.org > Sent: Sunday, March 29, 2015 5:45:52 PM > Subject: [ovirt-devel] Useless AddVmPoolCommand class > > Hi! > > Do we really need the AddVmPoolCommand class? What I see currently:

[ovirt-devel] Useless AddVmPoolCommand class

2015-03-29 Thread Shmuel Melamud
Hi! Do we really need the AddVmPoolCommand class? What I see currently: 1. VdcActionType.AddVmPool is never used. 2. CommonVmPoolWithVmsCommand extends AddVmPoolCommand, but this inheritance is useless: a. AddVmPoolCommand.executeCommand() is never called from CommonVmPoolWithVmsCommand.execu