Re: [ovirt-devel] oVirt 4.2 and UI plugin infrastructure

2017-11-30 Thread Vojtech Szocs
Hello Martin, UI plugin API in 4.2 should be generally backwards compatible with 4.1. Comparing PluginManager.java between master and 4.1.8 - the exposePluginApi() function is exactly the same for now. However, we might do some API changes in the future, mainly due to 4.2 UI redesign. For exampl

Re: [ovirt-devel] oVirt 4.2 and UI plugin infrastructure

2017-11-30 Thread Alexander Wels
On Thursday, November 30, 2017 10:48:26 AM EST Martin Sivak wrote: > It stays on a single line with just slightly wider window than I normally > have. But all plugins will be adding buttons here so the line can > theoretically get really long. > > Btw, is 1920px the required resolution now? Becaus

Re: [ovirt-devel] oVirt 4.2 and UI plugin infrastructure

2017-11-30 Thread Martin Sivak
It stays on a single line with just slightly wider window than I normally have. But all plugins will be adding buttons here so the line can theoretically get really long. Btw, is 1920px the required resolution now? Because I have no screen or machine with that :D Martin On Thu, Nov 30, 2017 at 4

Re: [ovirt-devel] oVirt 4.2 and UI plugin infrastructure

2017-11-30 Thread Greg Sheremeta
How does it look at 1920px wide? On Thu, Nov 30, 2017 at 10:40 AM, Martin Sivak wrote: > Hi, > > I see it working with a small UI glitch: > > Martin > > On Wed, Nov 29, 2017 at 6:25 PM, Martin Sivak wrote: > >> I will try finding time tomorrow. Thanks. >> >> Martin >> >> On Wed, Nov 29, 2017 at

Re: [ovirt-devel] oVirt 4.2 and UI plugin infrastructure

2017-11-30 Thread Martin Sivak
Hi, I see it working with a small UI glitch: Martin On Wed, Nov 29, 2017 at 6:25 PM, Martin Sivak wrote: > I will try finding time tomorrow. Thanks. > > Martin > > On Wed, Nov 29, 2017 at 6:02 PM, Greg Sheremeta > wrote: > >> Martin, we've merged the fix. (Thanks to Alexander for the super fa

Re: [ovirt-devel] oVirt 4.2 and UI plugin infrastructure

2017-11-29 Thread Martin Sivak
I will try finding time tomorrow. Thanks. Martin On Wed, Nov 29, 2017 at 6:02 PM, Greg Sheremeta wrote: > Martin, we've merged the fix. (Thanks to Alexander for the super fast fix.) > > Care to test with master? > > On Wed, Nov 29, 2017 at 10:50 AM, Alexander Wels wrote: > >> On Wednesday, Nov

Re: [ovirt-devel] oVirt 4.2 and UI plugin infrastructure

2017-11-29 Thread Greg Sheremeta
Martin, we've merged the fix. (Thanks to Alexander for the super fast fix.) Care to test with master? On Wed, Nov 29, 2017 at 10:50 AM, Alexander Wels wrote: > On Wednesday, November 29, 2017 10:16:27 AM EST Martin Sivak wrote: > > Thanks to you too for checking. > > > > Martin > > > > Fix is p

Re: [ovirt-devel] oVirt 4.2 and UI plugin infrastructure

2017-11-29 Thread Alexander Wels
On Wednesday, November 29, 2017 10:16:27 AM EST Martin Sivak wrote: > Thanks to you too for checking. > > Martin > Fix is pending review [1]. We moved the main views to a different class hierarchy and it wasn't inheriting the methods to add the buttons. Alexander [1] https://gerrit.ovirt.org/

Re: [ovirt-devel] oVirt 4.2 and UI plugin infrastructure

2017-11-29 Thread Martin Sivak
Thanks to you too for checking. Martin On Wed, Nov 29, 2017 at 3:07 PM, Greg Sheremeta wrote: > Discussed with Alexander, and yep this is an issue. > I opened https://bugzilla.redhat.com/show_bug.cgi?id=1518724 > > Thanks for checking and reporting! > > On Wed, Nov 29, 2017 at 8:35 AM, Greg She

Re: [ovirt-devel] oVirt 4.2 and UI plugin infrastructure

2017-11-29 Thread Greg Sheremeta
Discussed with Alexander, and yep this is an issue. I opened https://bugzilla.redhat.com/show_bug.cgi?id=1518724 Thanks for checking and reporting! On Wed, Nov 29, 2017 at 8:35 AM, Greg Sheremeta wrote: > +Alexander, can you take a look? > > On Wed, Nov 29, 2017 at 8:33 AM, Martin Sivak wrote:

Re: [ovirt-devel] oVirt 4.2 and UI plugin infrastructure

2017-11-29 Thread Greg Sheremeta
+Alexander, can you take a look? On Wed, Nov 29, 2017 at 8:33 AM, Martin Sivak wrote: > Hi, > > I think I found one issue.. I do not see the extra menu items that were > supposed to be added to VMs (used to be available in context menu as well). > > You can check it with > > http://jenkins.ovirt

Re: [ovirt-devel] oVirt 4.2 and UI plugin infrastructure

2017-11-29 Thread Martin Sivak
Hi, I think I found one issue.. I do not see the extra menu items that were supposed to be added to VMs (used to be available in context menu as well). You can check it with http://jenkins.ovirt.org/job/ovirt-optimizer_master_check-patch-el7-x86_64/65/ Martin On Wed, Nov 29, 2017 at 1:22 AM, G

Re: [ovirt-devel] oVirt 4.2 and UI plugin infrastructure

2017-11-28 Thread Greg Sheremeta
Hey, We haven't changed the API, so everything should still work. For example, I just installed 4.1 versions of dashboard and support-plugin in master, and all's well [*]: API: api.addSubTab('Template', 'Red Hat Documentation', 'my-host-subtab-template', '', {alignRight: true}); api.setTabAccess

[ovirt-devel] oVirt 4.2 and UI plugin infrastructure

2017-11-28 Thread Martin Sivak
Hi, I just got a question from an ovirt-optimizer user about the support in 4.2. And I realized I haven't heard anything about how UI plugins should be updated to work with the new UI. Is there anything special that needs to be done to make the plugin functional? Or will everything still work som